From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8412C4345F for ; Thu, 11 Apr 2024 16:14:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 611326B0095; Thu, 11 Apr 2024 12:14:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BE776B00AB; Thu, 11 Apr 2024 12:14:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 486516B00BF; Thu, 11 Apr 2024 12:14:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28C6E6B0095 for ; Thu, 11 Apr 2024 12:14:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FDC01C0E0B for ; Thu, 11 Apr 2024 16:14:36 +0000 (UTC) X-FDA: 81997748952.09.6AC90CC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf26.hostedemail.com (Postfix) with ESMTP id B44E1140028 for ; Thu, 11 Apr 2024 16:14:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YM38g1xS; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712852073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0U4zcX5SDHU+U6G/PRMRZdh51JHhjpiJtENbvr6rwf4=; b=tOJo276eXmTpWqUqQJQ/AsGS5pY0zm/dhmuQl1AL8nUPY5japNYi+Z5sb2A6vAJSQBKapK q99hBVFSTcFVUGXv/Dsem4BAvKwkDEZQWUzWUK1mFP0NW1nCYi/r05eMKASlcEmcRqjJv+ i+SVNlxarKMpMG2Quk+pN9/OUM3vgPs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YM38g1xS; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712852073; a=rsa-sha256; cv=none; b=WCABLpbENeaA/JTcS3bpRP73QQmqsa91vZlX0tBjwkfo6yJ0BNaPj8bNLuY1fpLPO3CwAD zGWRweeJLDA6u24hcJSnsOzP4dyhgWaCTu5Ummw5x/+32iOZhVoE41GMdKjweq65rKpWmX HeqFduv8sTCzDNSJRQJQ4bY9hn5m7Hg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5A227CE091E; Thu, 11 Apr 2024 16:14:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B668C113CD; Thu, 11 Apr 2024 16:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712852068; bh=uy6pGGPi2qIFBjcqu+esBQhfAfEpW75so9lpYL8foVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YM38g1xSJomnSJBxpc1G3XJXuXFXfzuZmZw9W1ZEJ2gQ5zLFk89wRK3YeEd05lTLE AAQ5RrPsZ5STh/Mt3QsaebAuGXzLhY0x8u9SLtyZjSLakLJFJsOPWjUHpDYpQw4UsE EGpr+8ZyDBFn0cJIG0DdXdWmcKPdYbHUmmc3RgjxJyX7211rYBWIDupiicGBP5ulWC pU8h5N9KPShuMKX+zU5CTgJIwDXvd2hwSdddZaIhBWMU6GOshdqKWpzhP3BCMhNy2g xirdpOcf8E+xuqkj36d9IEYmTi06aCT/RwyYVyb///3tCpj5gaiPT7lAiPhSSDeVQ0 Rg0oZvpbCDGEw== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: SeongJae Park , akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com Subject: Re: [PATCH v2 5/5] mm: add per-order mTHP swpin_refault counter Date: Thu, 11 Apr 2024 09:14:25 -0700 Message-Id: <20240411161425.77677-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240411014636.14023-1-21cnbao@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B44E1140028 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mz5ssaqkdw3cqaboydmequkjjb438ynm X-HE-Tag: 1712852072-224404 X-HE-Meta: U2FsdGVkX1+OFh1PNR66o2yqtzdsQH949wcqnV9+DMkHWmFcXWnWL9LMQpG5E6mamBa8d3oZmSkwpFH3xhMw5H1HKJjTDIft0I3hF66dDOMqB/UlAA/ErEus2o5MN0x3iu3ZdF3bOTjlsTHgu82CWg1Djhtt0MSHUOsX7bX5NxKhMi3iZYHsxuKxQiufoqqJr0ETNX/QFRawDTuYRTKUY5BDJjdG3McHBBLDiGVZ4WbpwBZn0LlL1OUAYDic7olr0jQB/bJ0IqhvNlRv/Za8ByJM1O5iN5tm2oLdndghn3/WzOZI8x+MBP/xdTVv33qqmnR9ILqfWnWf2XVJzScGQlStImj/YWJ8rClBG8Nn0b0ZYT81Xu4k0yvKaw5JziuZMU5ezEvtt/bijo8PVXMQnhZoKwPu4znMTd4GnWHiZwiw2D5TwbIDlhNv8lrNfqLr8WwdEnZXLFszVXFIVmjimerRa2Hvgpequ6D60RFb6A+6gx/dA8uoGAFe1h21X14ndvwqWQmY1wR65wm0RBCQwYrQa/g65btqmbBClr4mLalSjbP7e8BOjbpSii8WcS+NQvisABvjdMh1VMOooIIthTDlDAdP+V1Vj0ipOIzPym7FpKlLhOwP7wj3DB3GvBm8y/CcX2W82X8bVS0eMoTVLSb2ifdyatsUEkc8yICy5DOuKMX5CN1fcpr+veJe9CWAiM8Urp/sbs/JlghOdCsQ/7ThBOooHLpcAZOc/gbyva/vbiArmL8VrRZUDkrZobFmCifjcjdG/C6M7M2dY9nWjheFD1nS2MiJSRwEqN3gDaZ4GMw6IbMhCjazoc8Jz2endSAbso7o+OH9g3xp24Ls53uvMFk9gcxsZwG2uaZ5o5EkZu9C5LheX4hx8PDshuAj20jTwvQfnuXeRmBq0eFByEXs3Kh15OtcXQPWaPIEzP3QkPA+k37hyuM3mDUK2vMMKgyAuOd6oYF8LspkPwC gMzzVUdJ zubu0Xxg5FK8zTNRDmxMlblQMVl/mEnl3s3JQ7iX3U2uHJ//czFXRhEF94uNmO81clXl73Iy5tYmLLgZzrSU5DVrvIY9hi72v+F31zX+FODrCmbNvRck4JXY1ANYvSTXvGeJlmHv0n/A5aGvcItss9nGC5FfYmUcIEKkTW9C9hQpMgeKPMDSqIpx5cJE2ez0BBh64nKjU31LzlLx8Qe/iav6L0txm20LeNk2jVkz2fzgwNeR30YoPC0YQh/MHlL1h81Z+/Z6YpPAKa73y50Nn/LVWrxnA3hWnl8ZJMV+KqVWWyJ7A0cZxfVSTkUxPsHqCqWVFQ5lhezgw1kbilnFJ+pQja0R8Ye1dW+v8vjc6SayBcthBrcCFCAkc5yBc0otHQSDi3GZ5r4h8r23+/fdEDjbVBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On Thu, 11 Apr 2024 13:46:36 +1200 Barry Song <21cnbao@gmail.com> wrote: > >> + count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPIN_REFAULT); > >> } > >> > > From the latest mm-unstable tree, I get below kunit build failure and > > 'git bisect' points this patch. > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > [16:07:40] Configuring KUnit Kernel ... > > [16:07:40] Building KUnit Kernel ... > > Populating config with: > > $ make ARCH=um O=../kunit.out/ olddefconfig > > Building with: > > $ make ARCH=um O=../kunit.out/ --jobs=36 > > ERROR:root:.../mm/memory.c: In function ‘do_swap_page’: > > .../mm/memory.c:4169:17: error: implicit declaration of function ‘count_mthp_stat’ [-Werror=implicit-function-declaration] > > 4169 | count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPIN_REFAULT); > > | ^~~~~~~~~~~~~~~ > > .../mm/memory.c:4169:53: error: ‘MTHP_STAT_ANON_SWPIN_REFAULT’ undeclared (first use in this function) > > 4169 | count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPIN_REFAULT); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > .../mm/memory.c:4169:53: note: each undeclared identifier is reported only once for each function it appears in > > cc1: some warnings being treated as errors > > > > My kunit build config doesn't have CONFIG_TRANSPARE_HUGEPAGE. Maybe that's the > > reason and this patch, or the patch that introduced the function and the enum > > need to take care of the case? > > Hi SeongJae, > Thanks very much, can you check if the below fix the build? If yes, I will > include this fix while sending v3. Thank you for quick and kind reply :) I confirmed this fixes the build failure. > > Subject: [PATCH] mm: fix build errors on CONFIG_TRANSPARENT_HUGEPAGE=N > > Signed-off-by: Barry Song Tested-by: SeongJae Park Thanks, SJ > --- > mm/memory.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/memory.c b/mm/memory.c > index acc023795a4d..1d587d1eb432 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4142,6 +4142,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, > &vmf->ptl); > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > /* We hit large folios in swapcache */ > if (start_pte && folio_test_large(folio) && folio_test_swapcache(folio)) { > int nr = folio_nr_pages(folio); > @@ -4171,6 +4172,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > } > > check_pte: > +#endif > if (unlikely(!vmf->pte || !pte_same(ptep_get(vmf->pte), vmf->orig_pte))) > goto out_nomap; > > -- > 2.34.1 > >