From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261BEC4345F for ; Thu, 11 Apr 2024 20:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 772146B0083; Thu, 11 Apr 2024 16:42:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FA2A6B0087; Thu, 11 Apr 2024 16:42:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59BE56B0088; Thu, 11 Apr 2024 16:42:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 38D4E6B0083 for ; Thu, 11 Apr 2024 16:42:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8C15540CF5 for ; Thu, 11 Apr 2024 20:42:38 +0000 (UTC) X-FDA: 81998424396.26.7B130B5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id C568DA001B for ; Thu, 11 Apr 2024 20:42:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="V6EvwT/B"; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712868156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HE3Z7J4mNxAZDAoU8DRzGm1ylBTge7ujIkBxUyqDGAI=; b=b05s+NjRL8nAPrcZI7IqxzG7CVjTHrzQZCqSQTIka91VT2oC79mrPUhjEMh82HYNu4gsMu EG8pRcy3P9+BaoiGOejRl1WRQVvKHTVlXbwhJ/TrePEI/2fiPIkXJ0bl4QM2yVcJSsAuV9 ExeqXQC9jxjf31Vo7Rw3x1MAaCdCq1o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712868156; a=rsa-sha256; cv=none; b=2QeNXoN0NVHlEkkW58xu6OIKOaX4gfxrSvfLs/K3W4XO+rnbBC8L2AHI1T2eyxgr5ft0yz TlJKTOz91htk6BDAVxNjeoQEu5jrbdeeTVo/h8EHUBSGcxBDV6h7HVrbM/YEkPmdeoUvum 8YaX82vwaaNpXQ7n+ECOuVgSg5haUPY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="V6EvwT/B"; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B782E6209D; Thu, 11 Apr 2024 20:42:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8AF0C072AA; Thu, 11 Apr 2024 20:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712868155; bh=RUpCOmxxQLYhny5QSsaGDLDBRwT82ixFwRhLg360/4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V6EvwT/BrScs+PjqKRsxFJSoFDvE1Z2RqEMa3vf/gpBb1vNWnbPLoPvqw368a7/xj 9SQvkz0bpRsVMN3JNHV7X7Bu6sTrpdhC2tZMeCPmnr1NbEJ54YC6Vs/BtbGS56KJW1 zi6Bux8l92d8uSMLnLElzEyrK8Q/aEH0h0SHXmqc= Date: Thu, 11 Apr 2024 13:42:34 -0700 From: Andrew Morton To: David Hildenbrand Cc: Alex Shi , alexs@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, hughd@google.com, chrisw@sous-sol.org Subject: Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags Message-Id: <20240411134234.09920cdb641b3aa001526284@linux-foundation.org> In-Reply-To: <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com> References: <20240411061713.1847574-1-alexs@kernel.org> <20240411061713.1847574-10-alexs@kernel.org> <192aaa5c-3ff3-40c1-b12a-b674518bf5de@redhat.com> <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C568DA001B X-Rspam-User: X-Stat-Signature: u5e6uuzsi5ya4doko4hs6796qe6gaxxr X-Rspamd-Server: rspam03 X-HE-Tag: 1712868156-359295 X-HE-Meta: U2FsdGVkX1+yIQ0xOLhIZOckjncGcGsOaRHrvRAZasJZNFxluLkoRImTcTc9C/Wz+JjuFqSN+OcAzU+mdYcCt0wDkLyyBdOlgUwmiLICjvo0lUKHNinlX1VfkDqUavQAnJAZtBWUeSQIzBgc5BXeKKwPM5A4wdCLZqAD1tfmZRXio8ZytmGuHOhYfZRMDoPvdMVFFbsB+hplhhClxUgujM3jBso0i4GXm2dWG/PC8CzpdyNr2o7zAQX4pHlpcpfgpPqIy6+dD7eVuvHrt5otTPh+U5iKoIdaajrITair6+Y2ylsOCXd/3fWKeMeYYfn4DgpjYLMgzGuV3MzoFtJdaxvJtVdV2VabImpyK7v7W7ZwAXvCNjY0JOkn7Vc5xvWXo6jJ6fggvYXuQonemymcgAhUkNmTA/1QoekxiyEfFGejICq8yo7vHYiAxYR8hInLzlKxB/3zwzwBcqKj/KVD7OgnUlen+SDk3vGJ76khDksQu71O5hbDwH9gO0PYAHYfo06IIqJ7RFcqTE0K4mH53TnfV4iFVwCDECyb4HKSJcaKTX8xkrT8ivrNOiGpod+uZ97LkRM9PaTnwrdX7QDiHZWbCadkloc/sq4lUG3G/1/Haen0CLXQnrbewV1YRG5ELd5pHGlZQP2GoR95BmpiMpMlCXfW4mg9HWISf5RUY6rjKD4nsYdGCD6edhHnDFmueodhAXZX2R5++lhdxHf4N3iehfMr4JnpzUGk9f80etafhOINIRtjAtaXCu+wtHiWumYHX6psM09MwR7Ppsy8fFN6b6DND57wilbW3O+vkHQDTToip0O0BD9Xna/JH50FHwXbDkIPQPLVd1HhwfitrH1SxusJ2Nqko2p3eUYSyMZ6fPKuAaeZuChVGd9qcrER+ZW17UrGLhRM8vZUj2bNIZIcRIEBegDgDVy+/smHcYpOjllKugulvW6eSEW+9r8EkxHilpCnXIMPYevYD/x UIwOx1Ah G6BAYoM4vHCIWMMQoGYuRmNHsu23Ai17Gni9rikINEjnqj8BWvSxd7v6w92jQW3Kwh2bG6ChJeUTYGm49x1Xg9Gf1rQ0G44OAZzjvuDYvZjtxEwH7R3hwujhvxMwrRs16rSR1hv+d9qH+ska3ImWr7gAfNse2mFEs7xKhdDUyf61+leb60VdnsF2H64nHrGRjYWfRb1Cc8NwImXV0+pqGZ8j/UT6YeR238efcVGaPKA9UddiKhtteK9EkXCEfIysE25Rm2tMtk8SjEGlSnsISDz1fGa6N+gZJirD6uVoUCCIhVR/FanJs2tJ9sHtGtVctmr3eb0nvnW9ssUDzlPBbv+4es/2RxYLTGKr6+nrSa8ylXIw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 11 Apr 2024 13:46:23 +0200 David Hildenbrand wrote: > On 11.04.24 13:42, Alex Shi wrote: > > > > > > On 4/11/24 3:51 PM, David Hildenbrand wrote: > >> On 11.04.24 08:17, alexs@kernel.org wrote: > >>> From: David Hildenbrand > >>> > >>> As we are removing get_ksm_page_flags(), make the flags match the new > >>> function name. > >>> > >>> Signed-off-by: David Hildenbrand > >>> Reviewed-by: Alex Shi > >>> --- > >> > >> s/get_ksm_page_flags()/get_ksm_page_flags/ in title, otherwise LGTM. > >> > > > > Uh, for this trivial issue, do I need to sent a new version? or left to maintainer for a quick fix? > > I'm sure Andrew can fix that up :) He indeed can. Although he prefers foo() to foo. Those two characters have a good information-per-byte ratio. Also I added Alex's Signed-off-by to this. (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.