From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: Alex Shi <seakeel@gmail.com>,
alexs@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, zik.eidus@ravellosystems.com,
willy@infradead.org, aarcange@redhat.com, hughd@google.com,
chrisw@sous-sol.org
Subject: Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags
Date: Thu, 11 Apr 2024 13:42:34 -0700 [thread overview]
Message-ID: <20240411134234.09920cdb641b3aa001526284@linux-foundation.org> (raw)
In-Reply-To: <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com>
On Thu, 11 Apr 2024 13:46:23 +0200 David Hildenbrand <david@redhat.com> wrote:
> On 11.04.24 13:42, Alex Shi wrote:
> >
> >
> > On 4/11/24 3:51 PM, David Hildenbrand wrote:
> >> On 11.04.24 08:17, alexs@kernel.org wrote:
> >>> From: David Hildenbrand <david@redhat.com>
> >>>
> >>> As we are removing get_ksm_page_flags(), make the flags match the new
> >>> function name.
> >>>
> >>> Signed-off-by: David Hildenbrand <david@redhat.com>
> >>> Reviewed-by: Alex Shi <alexs@kernel.org>
> >>> ---
> >>
> >> s/get_ksm_page_flags()/get_ksm_page_flags/ in title, otherwise LGTM.
> >>
> >
> > Uh, for this trivial issue, do I need to sent a new version? or left to maintainer for a quick fix?
>
> I'm sure Andrew can fix that up :)
He indeed can. Although he prefers foo() to foo. Those two characters
have a good information-per-byte ratio.
Also I added Alex's Signed-off-by to this.
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
next prev parent reply other threads:[~2024-04-11 20:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 6:17 [PATCH v5 0/10] transfer page to folio in KSM alexs
2024-04-11 6:17 ` [PATCH v5 01/10] mm/ksm: add ksm_get_folio alexs
2024-04-11 6:17 ` [PATCH v5 02/10] mm/ksm: use folio in remove_rmap_item_from_tree alexs
2024-04-11 6:17 ` [PATCH v5 03/10] mm/ksm: add folio_set_stable_node alexs
2024-04-11 6:17 ` [PATCH v5 04/10] mm/ksm: use folio in remove_stable_node alexs
2024-04-11 6:17 ` [PATCH v5 05/10] mm/ksm: use folio in stable_node_dup alexs
2024-04-11 6:17 ` [PATCH v5 06/10] mm/ksm: use ksm_get_folio in scan_get_next_rmap_item alexs
2024-04-11 6:17 ` [PATCH v5 07/10] mm/ksm: use folio in write_protect_page alexs
2024-04-11 6:17 ` [PATCH v5 08/10] mm/ksm: Convert chain series funcs and replace get_ksm_page alexs
[not found] ` <8a79bfbd-b01d-4425-8fd9-de2d3e6cd1af@redhat.com>
2024-04-11 11:38 ` Alex Shi
2024-04-11 6:17 ` [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags alexs
[not found] ` <192aaa5c-3ff3-40c1-b12a-b674518bf5de@redhat.com>
2024-04-11 11:42 ` Alex Shi
[not found] ` <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com>
2024-04-11 20:42 ` Andrew Morton [this message]
2024-04-12 1:57 ` Alex Shi
2024-04-11 6:17 ` [PATCH v5 10/10] mm/ksm: replace set_page_stable_node by folio_set_stable_node alexs
2024-04-11 7:55 ` [PATCH v5 0/10] transfer page to folio in KSM David Hildenbrand
2024-04-11 11:45 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411134234.09920cdb641b3aa001526284@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=alexs@kernel.org \
--cc=chrisw@sous-sol.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=seakeel@gmail.com \
--cc=willy@infradead.org \
--cc=zik.eidus@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox