From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2ADBCD1299 for ; Thu, 11 Apr 2024 12:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A07B16B0099; Thu, 11 Apr 2024 08:42:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B7216B009B; Thu, 11 Apr 2024 08:42:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 795446B009D; Thu, 11 Apr 2024 08:42:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 574CD6B0099 for ; Thu, 11 Apr 2024 08:42:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1B2C1A09E8 for ; Thu, 11 Apr 2024 12:42:15 +0000 (UTC) X-FDA: 81997213830.09.E182598 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf30.hostedemail.com (Postfix) with ESMTP id BE3E98000A for ; Thu, 11 Apr 2024 12:42:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712839332; a=rsa-sha256; cv=none; b=W8vaxtcd613+O3w9uutkLz7p8jsYN58Wr3xujfCTSFy/9z1wqvZRzSPRm9+ovYEfBaAlSe rIZ5i3Y8htWqmcqixqUtc49kAhBJnqs39EwlV6by+8SeR7bttEX7px1ZDTe99GbsHDCQZm NcMsz2jw7Y6sJieg5sR82KvRO+430og= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712839332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QFdHNQXcpU0BF6xHOTfPGJY6ysWRVSKq6JKrnc7RimA=; b=HbcjETqQ67sy1LtZECpAdm1VDg50D3tlTLls1rFkx3aj/hVjzlcet0ioPERoXuf9uyV/vD aqaLEUWK7RmboipzYySE3UBuc80S4LalGlMqCrUMvEfsweeo179/cS13hm1OidlF+SUfaj uFTbeiiUPEx2IIbYx4Q2dUw9fDCoeC8= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VFfQR2lNyzwS29; Thu, 11 Apr 2024 20:39:11 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 0E0AE1400D1; Thu, 11 Apr 2024 20:42:08 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Apr 2024 20:42:07 +0800 From: Kefeng Wang To: Andrew Morton , Russell King , Catalin Marinas CC: Will Deacon , , , Cristian Marussi , Mark Brown , Aishwarya TCV , Kefeng Wang Subject: [PATCH v2 1/2] arm64: mm: drop VM_FAULT_BADMAP/VM_FAULT_BADACCESS Date: Thu, 11 Apr 2024 21:09:24 +0800 Message-ID: <20240411130925.73281-2-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240411130925.73281-1-wangkefeng.wang@huawei.com> References: <20240411130925.73281-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BE3E98000A X-Stat-Signature: 9mbtyodaw9tk7cww3kuanb633tk4grwq X-HE-Tag: 1712839331-569558 X-HE-Meta: U2FsdGVkX19Q3pE+z/67NSosZ5LBWxug0v9adavNFuIbAQHR0YPuGaLFI8pwcQiI0sI/XdnHEfoVjjT0hqmm5mkxc51AaOUWwuFrJE12mtfzKO94lE9NEM8+b4aVZsLS0bL+IAuilmF/HMNP6Egg1bDmfQ989d4BHwdMsrxaDUPDJDTtpVSksbU/fsoDzvkyc9OdPT4kkq5Q1qn9tdoJpppCxFvcpQKH/g825eubxuJ79UDgs/1LVSOLOx4jadRGfVkB7wK+mvMw1vDgtFMlZofP3HTWRkssQS7FeJHO8WNQ5U/TbSavaDOBmRJoPS0KIz0dqnZZ7nIB5CJXNSyazvp1O3Oy9QgnzDEi9/WRbcncwW81HEky5HmvSNnbEHI7QYYMrv6KFw1Xjwm8UQ5gBonOR6KeU/sjWpPIGG3LwPumaZ/RmGsACp9ojFuHBJGLlYRzHYYIgV0w4r7Afo7uUbBdpjS28Zdhch2cRfuZ60lxYgA4TTIeVtDWuVYYRrzrVqe6Mo2uNkwojsBeBXGukib75Z74gzUfj8aZLycPHzh73RCrpkIMK5trBEAe3R8RgAqBDdyiNasqzlmAPIYAxdykNfA9bN+V66h5/nx8BYj8cTO6abPptr3Kkog4SIxEE+udLAYLzzPiweDa1Y2SI4fd4DHkuT/kW6t3SRkmbwnwiGqmH82lDJNU3DTaZaSUiroj1vb2+SWPpDV0a7FlrjwQ62xbx8MIOA1vX82himSXNgvOlN4MIsbGG0Tq+1D9p+hCEOLcEUwGV7ucfX05RdIcJ4/ZEViBjDmfl4geDaI57Z58oX6BBNfhlDyYGv9mAoB4qUnnGOo/w6r1OTpe0Y3IRmg0Al5p3Sj0GAXe4F3Yqu4OU5ObhSFAiThqx9CqQdQvk3WdjSZT/pRWW5Dhhk0/S8H4xJbUdpquRMsyfxQghEiBSkoDiIcASjwvBFhWkLR5yOqNyctYFiH+lPc 6F8cDldD 6B/FYngJBe2c48JfbkkRUbNVz7E5dv4Wh77QOPsa/jv5SxzfEgSy1aKMs1alzaITiBUe0kghpLN9DfdXu1hJ9S5ug/lmGpynin60yZqJKd/OkiNvlamGpeKWwRl5LVY7425yPMQqZP//mdhs9hLf5Q2aCa+B6aQfmfBmV3N4gDzs7DGVaVM3wsybpp8DNWSnq/DOG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If bad map or access, directly set si_code to SEGV_MAPRR or SEGV_ACCERR, also set fault to 0 and goto error handling, which make us to drop the arch's special vm fault reason. Signed-off-by: Kefeng Wang --- arch/arm64/mm/fault.c | 43 ++++++++++++++++++++----------------------- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index 405f9aa831bd..5b7e6ada3125 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -500,9 +500,6 @@ static bool is_write_abort(unsigned long esr) return (esr & ESR_ELx_WNR) && !(esr & ESR_ELx_CM); } -#define VM_FAULT_BADMAP ((__force vm_fault_t)0x010000) -#define VM_FAULT_BADACCESS ((__force vm_fault_t)0x020000) - static int __kprobes do_page_fault(unsigned long far, unsigned long esr, struct pt_regs *regs) { @@ -513,6 +510,7 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, unsigned int mm_flags = FAULT_FLAG_DEFAULT; unsigned long addr = untagged_addr(far); struct vm_area_struct *vma; + int si_code; if (kprobe_page_fault(regs, esr)) return 0; @@ -572,9 +570,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, if (!(vma->vm_flags & vm_flags)) { vma_end_read(vma); - fault = VM_FAULT_BADACCESS; + fault = 0; + si_code = SEGV_ACCERR; count_vm_vma_lock_event(VMA_LOCK_SUCCESS); - goto done; + goto bad_area; } fault = handle_mm_fault(vma, addr, mm_flags | FAULT_FLAG_VMA_LOCK, regs); if (!(fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED))) @@ -599,15 +598,19 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, retry: vma = lock_mm_and_find_vma(mm, addr, regs); if (unlikely(!vma)) { - fault = VM_FAULT_BADMAP; - goto done; + fault = 0; + si_code = SEGV_MAPERR; + goto bad_area; } - if (!(vma->vm_flags & vm_flags)) - fault = VM_FAULT_BADACCESS; - else - fault = handle_mm_fault(vma, addr, mm_flags, regs); + if (!(vma->vm_flags & vm_flags)) { + mmap_read_unlock(mm); + fault = 0; + si_code = SEGV_ACCERR; + goto bad_area; + } + fault = handle_mm_fault(vma, addr, mm_flags, regs); /* Quick path to respond to signals */ if (fault_signal_pending(fault, regs)) { if (!user_mode(regs)) @@ -626,13 +629,12 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, mmap_read_unlock(mm); done: - /* - * Handle the "normal" (no error) case first. - */ - if (likely(!(fault & (VM_FAULT_ERROR | VM_FAULT_BADMAP | - VM_FAULT_BADACCESS)))) + /* Handle the "normal" (no error) case first. */ + if (likely(!(fault & VM_FAULT_ERROR))) return 0; + si_code = SEGV_MAPERR; +bad_area: /* * If we are in kernel mode at this point, we have no context to * handle this fault with. @@ -667,13 +669,8 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, arm64_force_sig_mceerr(BUS_MCEERR_AR, far, lsb, inf->name); } else { - /* - * Something tried to access memory that isn't in our memory - * map. - */ - arm64_force_sig_fault(SIGSEGV, - fault == VM_FAULT_BADACCESS ? SEGV_ACCERR : SEGV_MAPERR, - far, inf->name); + /* Something tried to access memory that out of memory map */ + arm64_force_sig_fault(SIGSEGV, si_code, far, inf->name); } return 0; -- 2.41.0