From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C63CD11C2 for ; Wed, 10 Apr 2024 23:38:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF04B6B0083; Wed, 10 Apr 2024 19:38:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA0936B0085; Wed, 10 Apr 2024 19:38:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB5E56B0088; Wed, 10 Apr 2024 19:38:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D3176B0083 for ; Wed, 10 Apr 2024 19:38:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 323D6C097D for ; Wed, 10 Apr 2024 23:38:05 +0000 (UTC) X-FDA: 81995237730.02.282BA27 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id B012C10000A for ; Wed, 10 Apr 2024 23:38:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cvXvIjwP; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712792283; a=rsa-sha256; cv=none; b=r8BGhfK2cVVgnIPJAkbIL2fO5y3S57jlkjkDPHSaXpfIOLB9AmYFKevx3FVClL+7VpYpTQ TCvdqOoHfZIDMW8IahQYWlgD3SMZCw/maJqH9BYaZKrR/bhSuZVEir3SCjEDOx2zOu5TRl OUSAlMrqdPpnuYieLABoCqNqce8911U= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cvXvIjwP; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712792283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4mEVmQj6ljzTugvWtfu25YZXKKJNitalhTdtyvv/vfs=; b=w6D4/FG3fY38vhWUCmWhZsLUcNzP4BxGE8xE9AwHdfveY8JY3T2ap0kOJyZdGoBB4/nArS y5xS5SUbNFGzpJlkNpytFI1wPtmsHd25U+ciBxljpGQI+0D+qNAxbANxON2IY8p5N2vbGZ it4q23vMHgozBkXtLRT/93wEh+ZUtWQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD7C761C99; Wed, 10 Apr 2024 23:38:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD4B0C433F1; Wed, 10 Apr 2024 23:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712792282; bh=3byiQjOlvBOYMNbK6uEXscUW916rvSbm1e6sOuZO2So=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cvXvIjwPSCnfCmSnpW/0FRKt63OYDwaSd3sGBvBeX9ca3DM9v2IgaupUkBXqLGATm LWJfndtPLFIkiAEaLFeVZHzhdqqmzSQu/+vKGEPZL+NQ7ClHdN6IvKcd3f5NNg5DT0 HFAaTvJHQCzRl5/Co98X+HWI98sliDpvGLuU4tWMtzs7c+EVagp1nBtPp5sqDCn36H ZZrC/vG5VTKf1L47SFAMLcA5wgYhe4e1hUrEAQc6hhBm1/KYym+5nC3ZIlVR6zIj64 8FIxRi1f7Gd1WfWh0US0s2Pqk3w+KS9ENjxE/IrOAa8vT8uMH8BkIB8Q7Xvwo3Lh1V eC2Pk0ZalgooA== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] mm: swap: introduce swap_free_nr() for batched swap_free() Date: Wed, 10 Apr 2024 16:37:59 -0700 Message-Id: <20240410233759.274907-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240409082631.187483-2-21cnbao@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B012C10000A X-Stat-Signature: 7guyxhtffftcf5fd8qni5436qyu1j8jj X-Rspam-User: X-HE-Tag: 1712792283-673381 X-HE-Meta: U2FsdGVkX1/cj4Ioj7hMy/mqsrDHUP/6VQfHGcPbXwzPyqz/6Us+uDdhJ7fVQaSQcjkuCkyCOaA1Wjfpvf+7eMWg2DT3GKfZLTa3T4gC2/lASQCIDaqhcKWn/kLLZe+AE3eCiFcVY9rdCrKI9wYYQ2ZMbRDLOuzRT5L4H433ARqoViy7KrAhAhyAMBO/3CQ+bfpwXrcpNJ7hqAkVsWVvhCIFBbc7TKx/3CKfNpssf7O0hH1vm3eGV3lWqhMplUGm233b72hjy/3tM1xyxdk6L2gBhRiChafRAQQXszaIjkIm8QXu+cZwRaCLugrBVI/XwHNA9bbhT3MFxhptU1IvfH1Sp4GsYgLv8xYcKun0I0fsgIFuaz2fZPIHJ5XoIyVDREf9rBo9Vl9GC27ScCGP88A6hXKaRjbz/+ggDxVYK7ZF4TVe7Y/eDPDVulmR+u5oIyyJpOhkAa3xQGezPEvVtkXFWQ7I9sRCrQxdD+t/Ck6NFsVx8ed6q8HyPQdvOJeNJph7Y+h/MaGqgaYh5jn/kXHy2uKS3iV9cQleu7uzOCAa3ReRqJUku0/lbJVo0g/p6UZD+pzUOqYyW1izf7d+Qw3Ft+WhXmK7vCoTvjBD/O+idcxBwIDseyn+ML7BedUQm8dYkFYiH2JqK+aWQ8M3+n4AWo3QasaDedfi/oYpfeIA07D1mmKca+FbCD//lU3Ersockyv+yK4Fj/HeLpwhJTwHZmsLYGwsmJujbrEhyVtiuBiuab5GnxGgrSiRT9bPtT5NIMUpkLWuHsS30OHzjtb3S8tTo6lgq2m32avJHGd+LakxsQn02WIoveFLcQqE4coK2C+Azp8t0R27MI0WpsrKKccc/8GPVFwsCfI0rwfl5+awg5vxGsjtxDLqCo4M5+6N5EsMt6X85DIj29YriENDq5dhA1cUZ49jbXCxJ6s4IRw8S2YaU6ivEE+1YPUC3bCaNgIWvEq1GZRyMk1 pC8aKl5E vjiVw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On Tue, 9 Apr 2024 20:26:27 +1200 Barry Song <21cnbao@gmail.com> wrote: > From: Chuanhua Han > > While swapping in a large folio, we need to free swaps related to the whole > folio. To avoid frequently acquiring and releasing swap locks, it is better > to introduce an API for batched free. > > Signed-off-by: Chuanhua Han > Co-developed-by: Barry Song > Signed-off-by: Barry Song > --- > include/linux/swap.h | 5 +++++ > mm/swapfile.c | 51 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 56 insertions(+) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 11c53692f65f..b7a107e983b8 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h [...] > +void swap_free_nr(swp_entry_t entry, int nr_pages) > +{ > +} I found the latest mm-unstable fails build when CONFIG_SWAP is not set with errors including below, and 'git bisect' points this patch. do_mounts.c:(.text+0x6): multiple definition of `swap_free_nr'; init/main.o:main.c:(.text+0x9c): first defined here I think this should be defined as 'static inline'? I confirmed adding the two keywords as below fixes the build failure. diff --git a/include/linux/swap.h b/include/linux/swap.h index 4bf5090de0fd..5fd60d733ba8 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -562,7 +562,7 @@ static inline void swap_free(swp_entry_t swp) { } -void swap_free_nr(swp_entry_t entry, int nr_pages) +static inline void swap_free_nr(swp_entry_t entry, int nr_pages) { } Thanks, SJ [...]