From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B1BCD11C2 for ; Wed, 10 Apr 2024 23:15:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 678C46B0087; Wed, 10 Apr 2024 19:15:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 601D06B0088; Wed, 10 Apr 2024 19:15:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B8F6B0089; Wed, 10 Apr 2024 19:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 261F36B0087 for ; Wed, 10 Apr 2024 19:15:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E1E471407DC for ; Wed, 10 Apr 2024 23:15:53 +0000 (UTC) X-FDA: 81995181786.04.3004B6C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 472851C0016 for ; Wed, 10 Apr 2024 23:15:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V78ag95D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712790948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z6/XsF9wTcVbwuYshETzwCTsuur+Mkx5rLvN9O4/jVg=; b=1XPPX8c/4aWjUQI0My0u7/fy9Kge3kOjo3gZiIA/f5mF+Sbqp3GIZMY3BeifDoPS4ISntp JiNb0jl1GlhBW6uMlAGzMF6/wj9MbLkayRerTnFHgyWWaPxEdZOoO2mZw1fKRQ8PIYqAOd mUPyFpB9kpz0yVgNdqCsXi5esmF1jTQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V78ag95D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712790948; a=rsa-sha256; cv=none; b=FL/8DuWhNCGuTQjPQfz5iHQQ4z7BmEqH9kWBSnTJoZXfw3qbuYv4we4FJt1cW5KkuxMRrU htP7THtWTSPw6xIlRLslQLzcn4v6PNXdY0bAFSB3zmM7K7z3j4WPH+2d12qtjaMyNW3xIw LMCInkAS1venrp2lZHh2cSpkhpPdI5M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CFF65CE2C60; Wed, 10 Apr 2024 23:15:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CB5FC433C7; Wed, 10 Apr 2024 23:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712790942; bh=RG8EDwScn2pYwAp6imeAEaKH30shjBDDs2FDWBIIxsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V78ag95DM2OQzdzXqdQc0VPA12CdXdwyKfa/n0L8utxcuegK+NFdYhB8xZ9cPOgxE UT7vbVQ7pDnUSgtSc3EMQbuCT5GMTp1JeUdEQaEiUCRQ6SC7xLMZaT2mObm9UtbqLg uFWWu+6AX5UG5D1LqDG/38bpXJn6Zo0/cjcG9x8AXYcS1LKDuf6rlPuNOndOQTACgC ebl5LTM5WwjDsUDELVHz/ZPxm4uIfc50KtSzdUFTCj82Omyp8PdwgjOj4TBaD2udPM INJ+q+mwv1+WXyUOpdyAAv3TMqW8dtmjXAatq88UZFwAUCCgo0imrLHR9wwcE67gFL Z3mX3vUgQBlyQ== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] mm: add per-order mTHP swpin_refault counter Date: Wed, 10 Apr 2024 16:15:38 -0700 Message-Id: <20240410231538.131175-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240409082631.187483-6-21cnbao@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 472851C0016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: f7ag1yxsrh8s5aee7udmpdmajkpqfz9y X-HE-Tag: 1712790946-750699 X-HE-Meta: U2FsdGVkX18l7Y2ZEp8x3n+7Bz8KNRJOdDCmx00MA3LL9ur+g3dIZBuALcx/DyBQHeYIUPvjX40c7pA4X+bpqWlJmINmbFWWgv9ApnQQkibiLDhpJTXleHRKvBVfdPVmPg9pbuH1mBmS3iJnlaJyq8pd1CLSo8mQBBD+SKOYA/q6stvx+p12T7pqlmW1inEC2suQ9ANpLtraTkgrN4vHolVNxUZko5FEWmwmUyMR4LvW+k5bALVrU3FbAJ9ZhsjAaocHmT/eLpSDpiC4HNZWp9UAVMlK4yzeWY/+iUDqvqcz11dkh1HQCx0vejciXeTU7j36oepuP7fwdxEJROGXWcn+y97uHQoE/EHLBvHMJEsWPcaiaT95+q8vS3VTiPYP1g3DXlpiz86U6WHGvZNHOkB4ZlpvXnlOkHilklMpasVcUnQIc6wlkn0mNQtSCxZVwnG21UN2gzOEbpOVbnXE2A9FrAeZwn9KJ/2JJwXkm1qEdAezXPIHxrcsJcuyw/vZK9TCxCTco1U3E+0ERgqvmBg5tiuaPEtfiGcNEgnKM0YSksMgxS4vVH7EbytnSFqf25q08RXIC9Ki2nkS/pcHFxW6k/gI5CYRE9yJLutVEUF0LpMQVVtKyVy5E74gOYWpGCvf7h2SBJ02SuhycXt0MD27PCatuuItqy+05jIkLdMOIdyIxoC7EYf8yqCdVmWAPzbku3p1AGCQy92SxsvgQ/agYeCM9l51zdiAXEt49R8Zx6Gkz+hZ+h4a3pxpNylM5nPxkRHQmWPQdQvxFv0tH1mjT8ky8BO6H9O3mftjXDUOyuZdzKy+NzBtw/m+An1N/h6IOJR78p6yMwH8Lrqix5kLnY9RvwtPRzPzdFS7wLGfxoAb13DJuv6Zfuv6uLnnF+58oNB9Q8TuY/6/154jaTTisw9vodOTMqnSFvV/q/GzLZ4eLy6gBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On Tue, 9 Apr 2024 20:26:31 +1200 Barry Song <21cnbao@gmail.com> wrote: > From: Barry Song > > Currently, we are handling the scenario where we've hit a > large folio in the swapcache, and the reclaiming process > for this large folio is still ongoing. > > Signed-off-by: Barry Song > --- > include/linux/huge_mm.h | 1 + > mm/huge_memory.c | 2 ++ > mm/memory.c | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index c8256af83e33..b67294d5814f 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -269,6 +269,7 @@ enum mthp_stat_item { > MTHP_STAT_ANON_ALLOC_FALLBACK, > MTHP_STAT_ANON_SWPOUT, > MTHP_STAT_ANON_SWPOUT_FALLBACK, > + MTHP_STAT_ANON_SWPIN_REFAULT, > __MTHP_STAT_COUNT > }; > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d8d2ed80b0bf..fb95345b0bde 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -556,12 +556,14 @@ DEFINE_MTHP_STAT_ATTR(anon_alloc, MTHP_STAT_ANON_ALLOC); > DEFINE_MTHP_STAT_ATTR(anon_alloc_fallback, MTHP_STAT_ANON_ALLOC_FALLBACK); > DEFINE_MTHP_STAT_ATTR(anon_swpout, MTHP_STAT_ANON_SWPOUT); > DEFINE_MTHP_STAT_ATTR(anon_swpout_fallback, MTHP_STAT_ANON_SWPOUT_FALLBACK); > +DEFINE_MTHP_STAT_ATTR(anon_swpin_refault, MTHP_STAT_ANON_SWPIN_REFAULT); > > static struct attribute *stats_attrs[] = { > &anon_alloc_attr.attr, > &anon_alloc_fallback_attr.attr, > &anon_swpout_attr.attr, > &anon_swpout_fallback_attr.attr, > + &anon_swpin_refault_attr.attr, > NULL, > }; > > diff --git a/mm/memory.c b/mm/memory.c > index 9818dc1893c8..acc023795a4d 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4167,6 +4167,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > nr_pages = nr; > entry = folio->swap; > page = &folio->page; > + count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPIN_REFAULT); > } >From the latest mm-unstable tree, I get below kunit build failure and 'git bisect' points this patch. $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ [16:07:40] Configuring KUnit Kernel ... [16:07:40] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=../kunit.out/ olddefconfig Building with: $ make ARCH=um O=../kunit.out/ --jobs=36 ERROR:root:.../mm/memory.c: In function ‘do_swap_page’: .../mm/memory.c:4169:17: error: implicit declaration of function ‘count_mthp_stat’ [-Werror=implicit-function-declaration] 4169 | count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPIN_REFAULT); | ^~~~~~~~~~~~~~~ .../mm/memory.c:4169:53: error: ‘MTHP_STAT_ANON_SWPIN_REFAULT’ undeclared (first use in this function) 4169 | count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPIN_REFAULT); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../mm/memory.c:4169:53: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors My kunit build config doesn't have CONFIG_TRANSPARE_HUGEPAGE. Maybe that's the reason and this patch, or the patch that introduced the function and the enum need to take care of the case? Thanks, SJ [...]