From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4048FCD129A for ; Wed, 10 Apr 2024 17:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6F7F6B0088; Wed, 10 Apr 2024 13:44:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4A1B6B008C; Wed, 10 Apr 2024 13:44:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 900226B0089; Wed, 10 Apr 2024 13:44:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 69D7F6B0088 for ; Wed, 10 Apr 2024 13:44:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2D0751208AF for ; Wed, 10 Apr 2024 17:44:55 +0000 (UTC) X-FDA: 81994347750.17.526A5BA Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf24.hostedemail.com (Postfix) with ESMTP id 34824180016 for ; Wed, 10 Apr 2024 17:44:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GjhU9grd; spf=pass (imf24.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712771092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hnZXVJfZAGwBsrkzwM2xdVFKDTfnQrp2RglJ2YFkNR0=; b=UY49/JoI/JexkjBw9xuZFj9mkuDMSi7fTvPVnlABXicTiHSne/AahrAQe2T3kqpzIZyqkK awpwYcF+LczC+G1yizkSajiKKhbUbKf9KzsfQzraOSTtpAO1gyDn6q7ssp6udpKB66Gn0O v1nwCroEsuAwhv0TZl9hmD6cRf3xWa0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GjhU9grd; spf=pass (imf24.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712771092; a=rsa-sha256; cv=none; b=sT4Z/QsNfC1BNCuINre3dYKt3n8lQJiFa4MqhY4d/cBpwxyKAJMFRy0hZTtDCozmOIcmUH ucjhcYAb6+sZA1PQc97rnD50DNvnx5jZOFhB84r+m6BsyTsgXKJ2JAgP+HqOKu+1PuXh1j kCzMFxCLWU/wGrdAwq0JSoEl1fO/JeE= Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43AHWA3o027252; Wed, 10 Apr 2024 17:44:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=hnZXVJfZAGwBsrkzwM2xdVFKDTfnQrp2RglJ2YFkNR0=; b=GjhU9grdNrWmZ6/6MG/XB8Slz/gvTkdJT4so7iW2UO6/VK94Rd8ff8aNEt9bkY7t1PpM lZNQxcssjZSU8P2QFPYHFpdCXy/VrMsvQMgBHk8Y1okpI78Hc8TSIlkvLzwjmlsavIJW j0/1NxuFhOXtBAC/D0WWF+1XjrMSP1tYkmBYaN7KDe4RRQAlUD8RUbaTK4+ouh6DnZ7d EAksI/W7LQKC40yERBsbESkekWWpYUmK7/c2v1oJaOkD8DkXcnFUf+1zCpewtbEi1KsI DzrE0Dik0c6ykHl01sXwYt60U7X3ViI/h8zJI2d4XvWjowuZVyyunBvouxicaRBtn+q3 +g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xdy8j00rx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 17:44:46 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43AHikO6012015; Wed, 10 Apr 2024 17:44:46 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xdy8j00rr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 17:44:46 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43AGqclR029940; Wed, 10 Apr 2024 17:44:45 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbj7me5hc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 17:44:44 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43AHidQM28181168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2024 17:44:41 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 537ED2004B; Wed, 10 Apr 2024 17:44:39 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 265F920040; Wed, 10 Apr 2024 17:44:39 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 10 Apr 2024 17:44:39 +0000 (GMT) Date: Wed, 10 Apr 2024 19:21:28 +0200 From: Claudio Imbrenda To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Matthew Wilcox , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Janosch Frank , Gerald Schaefer , Thomas Huth Subject: Re: [PATCH v1 1/5] s390/uv: don't call wait_on_page_writeback() without a reference Message-ID: <20240410192128.2ad60f9b@p-imbrenda> In-Reply-To: <20240404163642.1125529-2-david@redhat.com> References: <20240404163642.1125529-1-david@redhat.com> <20240404163642.1125529-2-david@redhat.com> Organization: IBM X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: quQYV4TfkaiiQczU3ccpk_wYZvvsE-_7 X-Proofpoint-GUID: epvxi2EtwwiBH1sO2ThDb1y5i3tsUcrR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_04,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404100130 X-Rspamd-Queue-Id: 34824180016 X-Rspam-User: X-Stat-Signature: yubpezat59umno8c9wou34reru7hqgt4 X-Rspamd-Server: rspam01 X-HE-Tag: 1712771090-53083 X-HE-Meta: U2FsdGVkX1/yz+gLQcPyHLhkTABc8zIA/5UyF+/UEl6uOw2zz/rTU4xoxCzkj8vfk0i5F4pYrDKpbkbRJDbE94BLfarpRNDYXwbdW29yRZnrfOwKWmbMwA405vFd6594V2hWNyX9OLEdS5+y4AmheZ7wYQ7wJwABV6UlY6jwoo1UTBwk1Fo2a7qWkCj62exBHDsL3++gCui/4UlCjHlSLtfSzTXaiwEUcVHE0DxWjPaoNShX7O55pHKhyAqdh+eCQSTN1KQk+smF6DG6O9wDCx+JGS1PzUF9am4BzTEUcCmKFxmKLJK3IP/qwgUwh3mOTA9RmFLDStjtU8FQcqErlMBUvUUhVoRp8/1dzaPqiWQd2PrzmIdjLNfVlN78O6SNyspJUgDPSdnzJgCBVSPEMDnGLfC2xE6bsAXtwkTmkPNzjj4w5Ffp450Z6JnErB91re31eVXlaaH0w1Agcxg8338U4NNdhlNzMTUK6YqOD1+FtSBi1IDFlEUsD5kYlEmDfqWqD1hshbT43ncUks1G6vMhk/8R8c7AmCRnkfgrg4cqhi/A+DL7JVHL80MyToRgc4Uhfx3jZnrcm+4JxRvNs0bp1QuAPpRbnKNAqU+/COTM5SRhF9dh9qp4toxyFARgf9OwHVVC9YanksRZKfHRUp+nXOpXn2+Ru072b56V3eIBqnLiHMvyHWOQdIhTiVwDX6EpXNVeOvx1wFtiOXzozvFs4J1THRbPTi6qOuA4GNLBy7S6QjT1LMfM+q3LmIHNjy1GxKpO2bbc5zXQPLdvvLivh5na9qVpU49NeklE6rs0uFSNPczBLODSCMWuWf/yobk4WGCEcZXQdwnyGLefv45UqOFvdXVQ7HvP5K8L6Qp8yiyf+JEBiaSZ5dmVXAC4tMa+AqotAh74jIcWng9qr3wWivbMyIKwK2gtSgrSGBaotztEk1Swy1TSZGI5gqqrMQOlh7NeD2Soq0HK9Qh Jx/SYkfH UOnVL+kn9D29HcmgZ1VtwY10zskteER3VKl/pQMiWJp9Ida3pQxbBKEZj8Jsjnqobx25aZ+OtRIIjA1Dk+/h/ld9NsKUJk8Uf4sNhpDcrGP/OJyy8UR8TBxZ/GtuxbjRhYz2FdoMd6MEHu1vLTnvBpupYUyH7bq0wCtCY45slZjE09xXcR3ripGMNexERGh4L22PV6RZl4oLj6WSBb9o6RmAF46mcwsczOmscH+hhEYhdskEjTRXa77fFzj0jAY1tGgOt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 18:36:38 +0200 David Hildenbrand wrote: > wait_on_page_writeback() requires that no spinlocks are held and that > a page reference is held, as documented for folio_wait_writeback(). After oops > we dropped the PTL, the page could get freed concurrently. So grab a > temporary reference. > > Fixes: 214d9bbcd3a6 ("s390/mm: provide memory management functions for protected KVM guests") > Signed-off-by: David Hildenbrand Reviewed-by: Claudio Imbrenda > --- > arch/s390/kernel/uv.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c > index fc07bc39e698..7401838b960b 100644 > --- a/arch/s390/kernel/uv.c > +++ b/arch/s390/kernel/uv.c > @@ -314,6 +314,13 @@ int gmap_make_secure(struct gmap *gmap, unsigned long gaddr, void *uvcb) > rc = make_page_secure(page, uvcb); > unlock_page(page); > } > + > + /* > + * Once we drop the PTL, the page may get unmapped and > + * freed immediately. We need a temporary reference. > + */ > + if (rc == -EAGAIN) > + get_page(page); > } > pte_unmap_unlock(ptep, ptelock); > out: > @@ -325,6 +332,7 @@ int gmap_make_secure(struct gmap *gmap, unsigned long gaddr, void *uvcb) > * completion, this is just a useless check, but it is safe. > */ > wait_on_page_writeback(page); > + put_page(page); > } else if (rc == -EBUSY) { > /* > * If we have tried a local drain and the page refcount