From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83327CD1297 for ; Wed, 10 Apr 2024 17:44:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A0936B0089; Wed, 10 Apr 2024 13:44:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9030C6B008A; Wed, 10 Apr 2024 13:44:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B7C6B008C; Wed, 10 Apr 2024 13:44:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5A0116B0089 for ; Wed, 10 Apr 2024 13:44:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA034C08B6 for ; Wed, 10 Apr 2024 17:44:56 +0000 (UTC) X-FDA: 81994347792.21.FFD046F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf08.hostedemail.com (Postfix) with ESMTP id 8633B16000D for ; Wed, 10 Apr 2024 17:44:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=AvdRggsv; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf08.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712771094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lnjnE8ATros47CvItPMr0cyRhNnNvF8qFBKBUXO4nZg=; b=rWKNF3XmXj9f4JjOkDxMxn6Ygovhg9eHo7HHpW4eADnP2nffSOZxoFsOlvPn9kSlQOxYMD /TYAxZiWWgT1ojTIO0PH4mCO6VDegEBxcMbjYEVoF9dqkPNz0AlB2ZiabV41ImDnpWZXTG bzpcO8zGhk2ibwm9MgSZvULphXTey1o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=AvdRggsv; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf08.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712771094; a=rsa-sha256; cv=none; b=31F3qmbOmrd97eidM5VMMpoXUHWPskd3nnUVk3zX42mTAdHCoilvFOuBAJeafL6NRFt7Ge e/sVQTuzv9zNOjWORPp9DxkKya3mZAmHL3xQ8xzJpAFoZraclwVUQiq/oO2KuQZYCshxGg R5ZA0Jp9lzKV2AB2omNFBnWRZBdHSww= Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43AHWfCE027558; Wed, 10 Apr 2024 17:44:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=lnjnE8ATros47CvItPMr0cyRhNnNvF8qFBKBUXO4nZg=; b=AvdRggsvVtfgVMcGf1LWwC2cpuVNYpVhS/VYxYE9Sa3p4sFXBVjl7jzeNO6F073J9Nvo U/omTieaaEzZ9iD3ZCm0neCWSCfXvA0GzxtoIiqcdGK3gHAZLspWVEuHytY3J84MjoQx ayRhg5ymc0FZxffaz06ZSdk85D+tGzbMpnhl3pXD5WzkMUuS61HR3k5zobEiiTXr4mfE aPExz9a/LEYnpzV0AquFSh0M+E6qN0Qzcuh8zIdM9fBKiFEglM8nF8UGdhj9tkRd9+95 UdHJ6D3BsaA9Mo+udUJFIPIVi7kU1CZa9KrIfl8ncgejC8UTn5EWJywBiOQoXslw55Zk ng== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xdy8j00rf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 17:44:42 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43AHige7011949; Wed, 10 Apr 2024 17:44:42 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xdy8j00ra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 17:44:41 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43AH29f6029904; Wed, 10 Apr 2024 17:44:40 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbj7me5h5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 17:44:40 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43AHiZpp50856364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2024 17:44:37 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC8DD20043; Wed, 10 Apr 2024 17:44:34 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B400C20040; Wed, 10 Apr 2024 17:44:34 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 10 Apr 2024 17:44:34 +0000 (GMT) Date: Wed, 10 Apr 2024 19:19:44 +0200 From: Claudio Imbrenda To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Matthew Wilcox , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Janosch Frank , Gerald Schaefer , Thomas Huth Subject: Re: [PATCH v1 4/5] s390/uv: update PG_arch_1 comment Message-ID: <20240410191944.72c84b2e@p-imbrenda> In-Reply-To: <20240404163642.1125529-5-david@redhat.com> References: <20240404163642.1125529-1-david@redhat.com> <20240404163642.1125529-5-david@redhat.com> Organization: IBM X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 8zhlPPNcuaeSlcywV_RLHDG0nrUNh0XR X-Proofpoint-GUID: 53w3kbTBb5T7QS82YxhvL0E5DyEKQP8o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_04,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 mlxscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=907 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404100130 X-Rspam-User: X-Stat-Signature: y6gqhsx6enewofscsjtysjx7xjp4p55o X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8633B16000D X-HE-Tag: 1712771094-148431 X-HE-Meta: U2FsdGVkX1814dF0LaX941YRNLbl90oYdGYyrdj0eaUKPznYhF6mOCAWzUkFD7D7Uxgqxipio7Aow5V9J1DDAobuTyu7RaiN+xQokdpJ4Z9k9/wnFymHdjnZIb9MdUwSni4JbRX6TS98NeXi9g1zLlihmmCRjABiiypmhtp0U3H50gALMhX49ZnRHfMRXz7x9vFfFIGkfCYksJkLWL7dObgHSAOhapU6b2xZ6IjJgOJAYaw60eNpxw3FGnlnRpfJsv+/hJrJ5773+XvfwP6ryQjrKLVYM/o3uNQGQbmc9OobT1HOHQrtZJjQIwRpDXAEwc3zv2x8+8sAV2nrLgx3FNvyM/UJW/i8wNXgQ2IFsW9g2px4OdaJym4cS+7/N9374rq65tDEKu+zYj6Zp0c1/0pQ9pqZz/fSppWnnGqNV458hhjCOQOB0kAXAStgrCUhV/3w9JkL2GpTkH4plTXDC7+aIh1vQlCHi0+3exNIvQeG+o7lbCRQbzyWVZosLrWet0Vp/DyIIrkVRxpXApWaP/d86nljcxjuKyZpJ4DHzZyi4pAvWmsWD1J5iF9ODLfi2pxdoBoO1gl5lwYgOU+tO2YBX8CMulTamUR3wiiZLK5XA0L/LsAmgP38UUTNSHjWGbnxpOErixwZ7/5zVOL3xMQfHHUp616piaFZBv3jXBwuwvIYkPY6qE94seSQd6onrPzIpB1IuUPaBj3ObZYaTZmk11lybuZCY600QdqEgSpD5eSvdRD1mrF/zUC3QP9xAfx3ZWJYypkewmWQ1QxxYT7txiDpRz79PK3+VQcy7MYAzMj2QerJHsRBbMRpcbCLw7YLJ4sFh6JZcdyQl8qAxQVHaoeQhZffDhFMYa0dLaNE/Ddd9k/kooDyy4lR2Gls5tN7zO5tvWjW4zhIzMc4xgI7z64g8qIyFbzUL064jBqKeyYt90UYtHZMyN036T66+hLnrnJdqAbDvOdTAKR DfTpTLf+ slR4cVlX20MOvuYgnuaKoZ0HBBABKAgypQbM+c1y0kSdqmeXVBXlygDxdIXO3yg9uCluqn+kG571h0QoLgHRhaUnM2cftTh7d5UOaW4uDpUuP/23LQAGtX7At+jtwOliRSm/BgEhlNIiXk5c/smJh2jpRazi02be4FBcI+5cDmTv/3UgfbvCiLmcm04fgbGdzra3XxDwk7660v4D3bo+fxWBiNqLbZHW9ZSejxAVF6BjaV24sJArR1e3o/Gw3OKBydQ+y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 18:36:41 +0200 David Hildenbrand wrote: > We removed the usage of PG_arch_1 for page tables in commit > a51324c430db ("s390/cmma: rework no-dat handling"). > > Let's update the comment in UV to reflect that. > > Signed-off-by: David Hildenbrand Reviewed-by: Claudio Imbrenda > --- > arch/s390/kernel/uv.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c > index 9c0113b26735..76fc61333fae 100644 > --- a/arch/s390/kernel/uv.c > +++ b/arch/s390/kernel/uv.c > @@ -471,13 +471,12 @@ int arch_make_page_accessible(struct page *page) > return 0; > > /* > - * PG_arch_1 is used in 3 places: > - * 1. for kernel page tables during early boot > - * 2. for storage keys of huge pages and KVM > - * 3. As an indication that this small folio might be secure. This can > + * PG_arch_1 is used in 2 places: > + * 1. for storage keys of hugetlb folios and KVM > + * 2. As an indication that this small folio might be secure. This can > * overindicate, e.g. we set the bit before calling > * convert_to_secure. > - * As secure pages are never huge, all 3 variants can co-exists. > + * As secure pages are never large folios, both variants can co-exists. > */ > if (!test_bit(PG_arch_1, &folio->flags)) > return 0;