From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35230C67861 for ; Tue, 9 Apr 2024 23:11:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC5E26B009C; Tue, 9 Apr 2024 19:11:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4E9B6B009D; Tue, 9 Apr 2024 19:11:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CA646B009E; Tue, 9 Apr 2024 19:11:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6AD166B009C for ; Tue, 9 Apr 2024 19:11:46 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3A5A140599 for ; Tue, 9 Apr 2024 23:11:46 +0000 (UTC) X-FDA: 81991542612.30.F64B72B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 973491C0005 for ; Tue, 9 Apr 2024 23:11:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of "SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712704304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=scPXn7OPZcBAQ5tsfarcdTYG1jfj6rduFM26kAQ55+s=; b=waUHZR1QIjRp/hMD+A4GZAqUqRX1u+7emrZz6NZhV10fjOWEFhlVR4bZM9ue6c1A1Uzl1J TEW1+uojuapF9xW4TEIrNYDgYVf1wmGzEJX+HnXQfsf+0RPiEVmUa0xEbvFGLWP5eBK7kx sj1N+Cb+Q7Fsj7pjkbugRrcTs9CKZHc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712704304; a=rsa-sha256; cv=none; b=qjNWp8+0FQtPT+g26ot7ywNZGQk2k6qIk5CVv0tFxF/IFOy2WDNPTKeZKQrrUCo2MOpps0 kM83Qt6FP46ETQtmGx51wG1DuouSS/h92N+3AzEhn2i8L3ESvey0YZnroESnCZ3Mg3flAL z6abkrQZaZTpMjniRGln1n2HJ5cZG3U= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of "SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 72C7A61A2B; Tue, 9 Apr 2024 23:11:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F495C433C7; Tue, 9 Apr 2024 23:11:40 +0000 (UTC) Date: Tue, 9 Apr 2024 19:14:15 -0400 From: Steven Rostedt To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon Subject: Re: [POC][RFC][PATCH 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Message-ID: <20240409191415.5a7b445f@gandalf.local.home> In-Reply-To: <202404091514.B97720B8@keescook> References: <20240409210254.660888920@goodmis.org> <20240409211351.234897475@goodmis.org> <202404091514.B97720B8@keescook> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 973491C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zpndmuo7ap8bmerszhnp9j8fzt1dgp1z X-HE-Tag: 1712704304-363105 X-HE-Meta: U2FsdGVkX1/Wzwl0XaNxcl/OaOKd/XNj9N8VV0kogcTD2O8nIGdd8B7oV47LsN7A3aaMrj181MYjuXPBXrsuQqmbllGubkk4b49/RvP5KdpxbCo1Ph00E5CidHwmRfRTaazSP937LtZG6i7rOs2xLIcge0CDi4Lvj4hxUAvqrAXMG3egBNBILEidGm/eo1MW4nvZ8knrNtgoq4KcoTRcmACnHS7q8A6yHs9/9I/Gz8clyc1fi7RVjLYUK2BQ9+hSW1pjDAIKs331Yzwb/U/utva3fgNqKCKJUoPyl2YaULZbCGYtK37XU8PHyyd/JigfLuf1wVw/HFKMY1mCaqy/BoPj6dH3CWQf6t6lKTfsxicWCd1IQ9DKuMKFQcB+joTlLijYf5IMLybbNGM6zzOfNBfX7jnNZSNmXrrVxbxQPh3pusmCJKjJyp2unaDAbfMymGMArYzDnuLMP6svfU/VBQZfsUCcnE3XxMkTddMbXkqGYe2eHZfUxYLtSSjoUCbvGRVwQDt9xvVFjDpYVFDtJri6pAO5l0rU0EO/G1+59beRQvMNAf2R7i0T7o1ZO76I/jmE5MGI0J8oM3F5xVW9DwKFQwySfZCKWraRWUwEW+RHyMqA/Wwl0jq5bTmcSNvv58BlZn+YojaS9yUl7BxdXtfrwsnUfcI2ksxwa6IbwNckdO5f1a6XohmJnwJnhON6SSc1jDzE2HtLFBwnHgx/oh6m32iHGhHtlP36G6AGVw9dJrFgIOzP2o8PVAwTxBgwwrQbDAg5FGIXsnJO1aCWuSwKnb64xcQxbGWcl6srjC8DgS4/h7vqQ/FV23dwQW09QWNA5CODvSO6LNTGBoZtjbzsldkqYXcQUCI0UpasQK/oAbwvDGalwfJ4EBuVkU2YioN3n1WOqdRC9LfCsOQR5F7nLwl3DT2iJaBuaamgBaNnvcGwRZrUdagG1oXIo/UtoEhEPmY3t42fMlx5Xuc 3xqiJ49f uA47u18gnzT89Z3YSMCBbsXWvonr/kSywfpyLtgEzZFh6rFh4TbLr8P4UWOVFi7B5rOgK45eME5s8ghZAf2bMhKFBWNISxZi+QfNHyjb3arPqARcCPYihpgN9VQTbbgk8LzAtNbfACrln+vnfVhxt8lYIleBC5Hk7jeKkaM5wxjcpqrdiMIFlXW5KzetHHqBgTpbx/z05wWSKsUW6qIHBciIigY5yz7nII6gAsppKEh43/Tv8yk9nYvi/PXYVxrtVmL4tX26LWhhy5ssRO5MtW1opnnjgwS8HzZJWbvwJWIs8HLzoXbfc20LXvYJTpLbpwlGz2XOMEU6ZGFiHsWDF0g99/K3GrRMgAXNr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 9 Apr 2024 15:18:45 -0700 Kees Cook wrote: > > @@ -914,6 +919,19 @@ static void __init ramoops_register_dummy(void) > > { > > struct ramoops_platform_data pdata; > > > > +#ifndef MODULE > > + /* Only allowed when builtin */ > > Why only when builtin? Well, because the memory table that maps the found physical memory to a lable is marked as __initdata, and will not be available after boot. If you wanted it for a module, you would need some builtin code to find it. > > > + if (mem_name) { > > + u64 start; > > + u64 size; > > + > > + if (memmap_named(mem_name, &start, &size)) { > > + mem_address = start; > > + mem_size = size; > > + } > > + } > > +#endif > > Otherwise this looks good, though I'd prefer some comments about what's > happening here. > > (And in retrospect, separately, I probably need to rename "dummy" to > "commandline" or something, since it's gathering valid settings here...) Yeah, that was a bit confusing. I kept thinking "is this function stable?". -- Steve