From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235C7CD128A for ; Tue, 9 Apr 2024 16:18:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACC406B0088; Tue, 9 Apr 2024 12:18:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C8F6B0089; Tue, 9 Apr 2024 12:18:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 944746B008A; Tue, 9 Apr 2024 12:18:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 744B36B0088 for ; Tue, 9 Apr 2024 12:18:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3903D40236 for ; Tue, 9 Apr 2024 16:18:55 +0000 (UTC) X-FDA: 81990502230.14.5E6FC2A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id B575840014 for ; Tue, 9 Apr 2024 16:18:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CbH0ZbOo; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712679532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uz1diiFdR1ve/osuapUYujgu7de1g+FBLXxSOxT/cDw=; b=pVyKotY+jRsvLnN4gnZ9NN3jxGy+cKwb0XJRfHduXRIJg7FlJqnCAAErY+ZH640NLDxrLD nntCKP/GiDaSHrMYeKUW7PUsAqJI+0Ly4a9kMmkjUcxCmjNEGSJF25hmtpW+nycCRuZwIP ifdow8mdoOPdaESzxcrIx6gpAxcZ8R8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CbH0ZbOo; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712679532; a=rsa-sha256; cv=none; b=K/cRtAeOy+2DFK+q3oPwZThH+9PYqDtshCw44fanP9c0chiubDRdq7cQcPjmHQHIr6kruu hrwzBD0WRn/IhDsC8EK3KzZyCphDoczzuMrPGDw8g9pJhW8JFQrkUbrKMrTelPtZ4evVkG 0PFaiTJWlSkI/28HwIqgNMOaj84JRyQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9A2E461902; Tue, 9 Apr 2024 16:18:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C6D6C433F1; Tue, 9 Apr 2024 16:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712679531; bh=a7Fm72paZyRNRsqpCjczySMYH6WBySfKD6PeLYfDdc8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CbH0ZbOoWsMrhL0l3zU/ykCadFbwmA849ytybkTc3goAXFXVXT1+T3MHAVioTeAMa HLIOD408RCHYNsYlbVsRzhoQlWayG0IRriXNowb2NudweVWcZQRFS3Qw8o4znU5iSR cl6cjLy5/9VgJEEGo8mmrg4WSMBsaBMS2xHnXICnvD7wZZfjJNsDYhH9un7v5/EUPH qRbOp61cjpMyA5+8D3+iJzXgbfzS5uk98bDmjxA6YjW5HEdb4v2/Qu57TuluRK+oSz qxqSgs/m+yQ1txjhzKkr/SvOQ597RyxCoqGzG8+DYbUiF/ylbrvKq9Ini5ochsFJJg 6ajcY56aBrZhA== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: Re: [RFC PATCH v3 5/7] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion Date: Tue, 9 Apr 2024 09:18:47 -0700 Message-Id: <20240409161847.65803-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240409095418.3051-1-honggyu.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B575840014 X-Rspam-User: X-Stat-Signature: jkd3f4wu5npxtatf15c5fixjkzgp1fon X-Rspamd-Server: rspam01 X-HE-Tag: 1712679532-372212 X-HE-Meta: U2FsdGVkX1/zaGtoyMW6kXqjZNR60pxSaAntRguNIDaWxkvSPKyBYww4YJrfJrsHJY0C7LGrQM1dKYnXGkMvvI0S0sTm/BIGmoPBH/O1SkT/FFgi0AvyrNVQmI49lCATuVQ4Cjy8eZ2sI5gqr8a4FnYTZ5yAQ1fJuR3FnE+xdQpEqv6SwrhMg5fZGfASbaC8WDbpbuRIbELyN/XnmT8n2Zk8xKARWqn+0WULcpeg+OSFeNAGW4Hu6Z/0o7nUTWrzRYqK4f52XU4l5C1ucfxYWRL2kqwXQgKub3WpXLFqV7vxLjSpy2y8QeMzC0DSxMdtFAOJA0Ik9ir/b+0nTV24PtR7UWa47IfPoQBFh2NJTodN/vfA5R7WvF0RU20l30y/vrpe6aoi4dQBFuvr5dPOqnZoYr6TggAvu1RDAdBAUQ+3CCIqSbtY89basOUxnszsO3nb99d67IXH6zwCZ+Rh7z7/KGxdZn+/kVzedzGk59j8Gc1chlfSiZ4d4ukJjmA6UJZxIOW5byQZVAhTheEjWg/1I0jUTVePeoHYZN+ADLj5EVB56WqMvfDGx7KUVXUzCzE5k6lwoe7j7uUhmGN6o2Kt5CEKYorIH/aK8U94BrBicFKK41YmvmCr1fW2bsXGuw7US+tp0f87+o+sljgJw0XYXoyn7r6nVT7HyEyesnAzdhAl+1taIB7nGvBzAYsKRAUPmeUaODkRwOrpTxy8Z1PZQumKnlxkweO28VHDnzdOGA+CIJa42msO60Bw6JnFdST64gFPsZ0khVfaly5pm/xnTQDv7iaDHWCQoHSBpo5Albo6csXLJjnDlU5Lxb+7a+6MSu1IxPy2s6XsMRSWZ8rQBJbE72zgoYJP5sa5tzE7wUEE2DetZAwWdUPx8CMYlGqagPcC90v2nqPCx6UmPQLOeSxl1oYeB1wLzsp9n+UKs/cyuh1J0EHgOeWmiGI0q27krbrkdD7jkVTl/6h tjuU3WNu DCj9bg9NxwzwkMw1rJ5PeBjtCGo/woT49mENj/AeNkph170lKYTs70dZSr6RDDqBhaRJYV70bAz11Dds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Honggyu, On Tue, 9 Apr 2024 18:54:14 +0900 Honggyu Kim wrote: > On Mon, 8 Apr 2024 10:52:28 -0700 SeongJae Park wrote: > > On Mon, 8 Apr 2024 21:06:44 +0900 Honggyu Kim wrote: > > > On Fri, 5 Apr 2024 12:24:30 -0700 SeongJae Park wrote: > > > > On Fri, 5 Apr 2024 15:08:54 +0900 Honggyu Kim wrote: [...] > > > I can remove it, but I would like to have more discussion about this > > > issue. The current implementation allows only a single migration > > > target with "target_nid", but users might want to provide fall back > > > migration target nids. > > > > > > For example, if more than two CXL nodes exist in the system, users might > > > want to migrate cold pages to any CXL nodes. In such cases, we might > > > have to make "target_nid" accept comma separated node IDs. nodemask can > > > be better but we should provide a way to change the scanning order. > > > > > > I would like to hear how you think about this. > > > > Good point. I think we could later extend the sysfs file to receive the > > comma-separated numbers, or even mask. For simplicity, adding sysfs files > > dedicated for the different format of inputs could also be an option (e.g., > > target_nids_list, target_nids_mask). But starting from this single node as is > > now looks ok to me. > > If you think we can start from a single node, then I will keep it as is. > But are you okay if I change the same 'target_nid' to accept > comma-separated numbers later? Or do you want to introduce another knob > such as 'target_nids_list'? What about rename 'target_nid' to > 'target_nids' at the first place? I have no strong concern or opinion about this at the moment. Please feel free to renaming it to 'taget_nids' if you think that's better. [...] > Please note that I will be out of office this week so won't be able to > answer quickly. No problem, I hope you to take and enjoy your time :) Thanks, SJ [...]