[linux-next:master 4283/4584] mm/internal.h:206:70: warning: suggest parentheses around '+' in operand of '&'

[linux-next:master 4283/4584] mm/internal.h:206:70: warning: suggest parentheses around '+' in operand of '&'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   a053fd3ca5d1b927a8655f239c84b0d790218fda
commit: 3317f7faabc24b500c26d02615ac75ca2786e272 [4283/4584] mm: swap: free_swap_and_cache_nr() as batched free_swap_and_cache()
config: parisc-allnoconfig (https://download.01.org/0day-ci/archive/20240409/202404091516.9h8IdaMM-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240409/202404091516.9h8IdaMM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404091516.9h8IdaMM-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from arch/parisc/include/asm/uaccess.h:16,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:13,
                    from include/linux/sched/signal.h:9,
                    from include/linux/rcuwait.h:6,
                    from include/linux/percpu-rwsem.h:7,
                    from include/linux/fs.h:33,
                    from include/linux/dax.h:5,
                    from mm/filemap.c:15:
   mm/internal.h: In function 'pte_next_swp_offset':
>> mm/internal.h:206:70: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses]
     206 |                                                    swp_offset(entry) + 1));
         |                                                    ~~~~~~~~~~~~~~~~~~^~~
   arch/parisc/include/asm/pgtable.h:432:53: note: in definition of macro '__swp_entry_to_pte'
     432 | #define __swp_entry_to_pte(x)           ((pte_t) { (x).val })
         |                                                     ^
   mm/internal.h:205:40: note: in expansion of macro '__swp_entry'
     205 |         pte_t new = __swp_entry_to_pte(__swp_entry(swp_type(entry),
         |                                        ^~~~~~~~~~~
>> mm/internal.h:206:70: warning: suggest parentheses around '+' inside '>>' [-Wparentheses]
     206 |                                                    swp_offset(entry) + 1));
         |                                                    ~~~~~~~~~~~~~~~~~~^~~
   arch/parisc/include/asm/pgtable.h:432:53: note: in definition of macro '__swp_entry_to_pte'
     432 | #define __swp_entry_to_pte(x)           ((pte_t) { (x).val })
         |                                                     ^
   mm/internal.h:205:40: note: in expansion of macro '__swp_entry'
     205 |         pte_t new = __swp_entry_to_pte(__swp_entry(swp_type(entry),
         |                                        ^~~~~~~~~~~
--
   In file included from include/linux/pgtable.h:6,
                    from include/linux/mm.h:30,
                    from mm/slub.c:13:
   mm/internal.h: In function 'pte_next_swp_offset':
>> mm/internal.h:206:70: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses]
     206 |                                                    swp_offset(entry) + 1));
         |                                                    ~~~~~~~~~~~~~~~~~~^~~
   arch/parisc/include/asm/pgtable.h:432:53: note: in definition of macro '__swp_entry_to_pte'
     432 | #define __swp_entry_to_pte(x)           ((pte_t) { (x).val })
         |                                                     ^
   mm/internal.h:205:40: note: in expansion of macro '__swp_entry'
     205 |         pte_t new = __swp_entry_to_pte(__swp_entry(swp_type(entry),
         |                                        ^~~~~~~~~~~
>> mm/internal.h:206:70: warning: suggest parentheses around '+' inside '>>' [-Wparentheses]
     206 |                                                    swp_offset(entry) + 1));
         |                                                    ~~~~~~~~~~~~~~~~~~^~~
   arch/parisc/include/asm/pgtable.h:432:53: note: in definition of macro '__swp_entry_to_pte'
     432 | #define __swp_entry_to_pte(x)           ((pte_t) { (x).val })
         |                                                     ^
   mm/internal.h:205:40: note: in expansion of macro '__swp_entry'
     205 |         pte_t new = __swp_entry_to_pte(__swp_entry(swp_type(entry),
         |                                        ^~~~~~~~~~~
   mm/slub.c: In function 'slab_post_alloc_hook':
   mm/slub.c:3831:29: warning: variable 'obj_exts' set but not used [-Wunused-but-set-variable]
    3831 |         struct slabobj_ext *obj_exts;
         |                             ^~~~~~~~


vim +206 mm/internal.h

   194	
   195	/**
   196	 * pte_next_swp_offset - Increment the swap entry offset field of a swap pte.
   197	 * @pte: The initial pte state; is_swap_pte(pte) must be true.
   198	 *
   199	 * Increments the swap offset, while maintaining all other fields, including
   200	 * swap type, and any swp pte bits. The resulting pte is returned.
   201	 */
   202	static inline pte_t pte_next_swp_offset(pte_t pte)
   203	{
   204		swp_entry_t entry = pte_to_swp_entry(pte);
   205		pte_t new = __swp_entry_to_pte(__swp_entry(swp_type(entry),
 > 206							   swp_offset(entry) + 1));
   207	
   208		if (pte_swp_soft_dirty(pte))
   209			new = pte_swp_mksoft_dirty(new);
   210		if (pte_swp_exclusive(pte))
   211			new = pte_swp_mkexclusive(new);
   212		if (pte_swp_uffd_wp(pte))
   213			new = pte_swp_mkuffd_wp(new);
   214	
   215		return new;
   216	}
   217	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki