From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D48FCD1284 for ; Tue, 9 Apr 2024 09:25:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEFBC6B0089; Tue, 9 Apr 2024 05:25:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAA7A6B008C; Tue, 9 Apr 2024 05:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3F9A6B008A; Tue, 9 Apr 2024 05:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 92A3F6B0088 for ; Tue, 9 Apr 2024 05:25:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5300D1202F8 for ; Tue, 9 Apr 2024 09:25:01 +0000 (UTC) X-FDA: 81989459202.09.039DA5F Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id A512E100002 for ; Tue, 9 Apr 2024 09:24:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712654699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i1d2CltuRBrTgKx5oOs4dN2BWVyPnqZ3dr3NWgFB2nE=; b=r2Dj6/Fr+/NdRjZKW+tw+XcuK/uZi7nEXu3q9DexRPwPsU5so8tPkKEykhrjuX/YeyU6TR 5si8WgRXEnCHwt0I//GfyuF25G/AWbvugZsftSFGROqfXQgEVElJJ2QOpUuiWL8tLSI2Uu 1H4gKQ2k6QOP3oX7Sxg2YAzRR1GGgsE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712654699; a=rsa-sha256; cv=none; b=Bn7s9bvwORT73pBF45HkKet3QTZHFKikfdllsigi+1Lq8tAAu2we+ZLxBeqTuuSqDcTeFK HnEmWcWs3uEzEw5bex66ZNnnupUjBVoNKWCg4YJeOWFQ35E5o2o6YTOh3+aBpkhkhHHY35 rvad83kNrlWGhLG1LUVSbrrf20gczQI= X-AuditID: a67dfc5b-d85ff70000001748-7f-661509649d67 From: Honggyu Kim To: SeongJae Park Cc: honggyu.kim@sk.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 0/4] mm/damon: add a DAMOS filter type for page granularity access recheck Date: Tue, 9 Apr 2024 18:24:31 +0900 Message-ID: <20240409092434.3031-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240311204545.47097-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDLMWRmVeSWpSXmKPExsXC9ZZnoW4Kp2iaweJDZhZP/v9mtbi8aw6b xb01/1ktDn99w+TA4rFpVSebx6ZPk9g9XmyeyejxeZNcAEsUl01Kak5mWWqRvl0CV8aliX+Z ClYIVTRcPs7WwPiZr4uRk0NCwESi581Xti5GDjB78v4gkDCbgJrElZeTmEBsEQFFiXOPL7J2 MXJxMAtMZ5TYeGIzK0hCWCBV4sbcPrAiFgFVid8v37CD2LwCZhLrp11lh5ivKfF4+08wm1PA WOL465NgvUICPBKvNuxnhKgXlDg58wkLiM0sIC/RvHU2M8gyCYEZbBKd698yQQySlDi44gbL BEb+WUh6ZiHpWcDItIpRKDOvLDcxM8dEL6MyL7NCLzk/dxMjMAyX1f6J3sH46ULwIUYBDkYl Hl6Lq8JpQqyJZcWVuYcYJTiYlUR4g00F04R4UxIrq1KL8uOLSnNSiw8xSnOwKInzGn0rTxES SE8sSc1OTS1ILYLJMnFwSjUwTov7HcNzQTlqjxmne+ApsVcGnCEvhHxeB0UxOe+tsuDtnq3M pNRcPitlmrud5oGItJsvn6cFvMw7L/yWVXyOpIOI7hOTDXKOm57dvycRYHLkHbdQkIzi94tv rxjzfNFp23/yxJ4a3V0cOUdL4g2D7sydnCKp83ASG/ejwp4b65rCys38fwcqsRRnJBpqMRcV JwIAHN1XZT8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrILMWRmVeSWpSXmKPExsXCNUNLTzeFUzTN4O42I4sn/3+zWnx+9prZ ovPJd0aLw3NPslpc3jWHzeLemv+sFoe/vmFyYPfYtKqTzWPTp0nsHi82z2T0+Hbbw2Pxiw9M Hp83yQWwRXHZpKTmZJalFunbJXBlXJr4l6lghVBFw+XjbA2Mn/m6GDk4JARMJCbvD+pi5ORg E1CTuPJyEhOILSKgKHHu8UXWLkYuDmaB6YwSG09sZgVJCAukStyY2wdWxCKgKvH75Rt2EJtX wExi/bSrYLaEgKbE4+0/wWxOAWOJ469PgvUKCfBIvNqwnxGiXlDi5MwnLCA2s4C8RPPW2cwT GHlmIUnNQpJawMi0ilEkM68sNzEzx1SvODujMi+zQi85P3cTIzDgltX+mbiD8ctl90OMAhyM Sjy8DneE04RYE8uKK3MPMUpwMCuJ8AabCqYJ8aYkVlalFuXHF5XmpBYfYpTmYFES5/UKT00Q EkhPLEnNTk0tSC2CyTJxcEo1MOYLVq/J+B4XG6S5R8f8SNmatP3GMp0zlpmJNt+XtOZaIrz7 aT97xs7C97fqA8xZD79miZ6UspaldXmFesKE69PvTrfa+HDnrQiOJNMrt0QmphmaHfKZ6WRR PXdfheOOUzGKJhKuxZ1b+D4ufnA5xHTbVu1pN/v+Tby3bYnXr+PH1srffW6bwabEUpyRaKjF XFScCAAwE2uBNAIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A512E100002 X-Stat-Signature: pzaxous1dgadx9ixzczrcdskbc31rdfn X-Rspam-User: X-HE-Tag: 1712654696-595955 X-HE-Meta: U2FsdGVkX1/HqreJ8zVNGbc9doZ6q4Oy76Kgocs6sl0qd32T+NmZ/mR4hjLznikGJcgQvBlMGVn5kApRCK2CkU2sUv2mvbwjRVNmIWtGMDw3IgfWeSURh9k+4CEzTz6Hyfh+tanst/rc/osbDZplZV4+86GO1Q4OA5AcmQgkinUCLT9mNTZgRB1kSvJHDvrzaTIxVeKwF5D9phkhaagN5kexQrNB/yvQ4Ef/FjT1IzDmrLU/zDuukr55iGcTIIJ1fZrI4ciz8d1JIc2++dIvfeq4WD9jmnHSPEJSTl5pjGW+Lw3it8NIh+y0NVNGhaJX6op7NB1Z/O+FR1p2YwvbVw4BumImBSekWPEaXnHPV+wohcCCLaLtwsnvYZNXk8ck1gMESF/uua9MYlM+DK7t44mEsn0XoKt5IflWo8SyweWK7ocpvvX4GDAE+dBejoaDnAYfzbh1Ig8Im7A3RPVojYhysZBWz5fxww8VfS649dOEYwNXi+cy8Payl4blbHTIeKo7XoDQLkYZo+EkY08Q4Q8n0btzrXuCZJ2tci0YivJgbPckbLcyAg0YGm24EVFifu+6iBOg2MkYy62oMTUdfySr07oxOz48LLZh0L1yqunNli6M3Y/tR3qtT+n77/xNegkiq3Hnz6VR+kJHLEARv3jl/XKB8hN60Tz31a4dBOf8ipIc/iN9nfumd8/Dt9kYUO3IcjcjN1aM/cA4okS0+hMv96uoe12a4ghuSN1gFukXYYePbkjRF4D5rRQuRK2gZTi+DMPrbqZYPeQ8o9CwgkkBE8CuiZrkcah9vudnithTZS4ZvkKh7sa8GEKwKD/Fa7CJvIaN+dljXbbl1SkOIW6icJ1AVBP68xRdcIq9Mw5heaxn6+09BRk+7A/oMhcW8YCkiobXM2G6ExpFRxHMCRUGWmDHpjiGHjAo1CCM1+tIJ0gKBWshknUppsf7UkSvTmANtsB2BXBkYSbQL6J 2SVc9abV PCdSi43zHLOyeDSGmrX3f/EELcsbH5IMYjMM36D3WgsuwtAL8PkZpuTodYhOlXFL9ykPo+lGImt/N7kx3tY8lv2DHMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi SeongJae, On Mon, 11 Mar 2024 13:45:41 -0700 SeongJae Park wrote: > Changes from RFC v1 > (https://lore.kernel.org/r/20240307030013.47041-1-sj@kernel.org) > - Rename __damon_pa_young() to damon_folio_young_one() > - Mark the folio as old from the filter for the next check > > DAMON allows users to specify desired ranges of overhead and accuracy of > the monitoring, and do its best effort to make most lightweight and > accurate results. A recent discussion for tiered memory management > support from DAMON[1] revealed that the best effort accuracy may not > suffice in some use cases, while increasing the minimum accuracy can > incur too high overhead. The discussion further concluded finding > memory regions of specific access pattern via DAMON first, and then > double checking the access of the region again in finer granularity > could help increasing the accuracy while keeping the low overhead. > > Add a new type of DAMOS filter, namely YOUNG for such a case. Like anon > and memcg, the type of filter is applied to each page of the memory > region of DAMOS target memory region, and check if the page is accessed > since the last check. Because this is a filter type that applied in > page granularity, the support depends on DAMON operations set. Because > there are expected usages of this filter for physical address space > based DAMOS usage[1], implement the support for only DAMON operations > set for the physical address space, paddr. > > [1] https://lore.kernel.org/r/20240227235121.153277-1-sj@kernel.org > > > SeongJae Park (4): > mm/damon/paddr: implement damon_folio_young() > mm/damon/paddr: implement damon_folio_mkold() > mm/damon: add DAMOS filter type YOUNG > mm/damon/paddr: support DAMOS filter type YOUNG I have tested your patches for evaluation of [1] and it all works fine. Thanks very much for doing this work! Tested-by: Honggyu Kim [1] https://lore.kernel.org/damon/20240405060858.2818-1-honggyu.kim@sk.com > include/linux/damon.h | 2 ++ > mm/damon/paddr.c | 64 +++++++++++++++++++++++++--------------- > mm/damon/sysfs-schemes.c | 1 + > 3 files changed, 43 insertions(+), 24 deletions(-) > > > base-commit: 13043cde46a19e72d37965b67b74e564623f65e7 > -- > 2.39.2 >