From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1506CD1284 for ; Tue, 9 Apr 2024 09:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D0646B0082; Tue, 9 Apr 2024 05:19:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 682296B0083; Tue, 9 Apr 2024 05:19:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 549F96B0087; Tue, 9 Apr 2024 05:19:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3B0466B0083 for ; Tue, 9 Apr 2024 05:19:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B26C91C04AE for ; Tue, 9 Apr 2024 09:19:48 +0000 (UTC) X-FDA: 81989446056.02.137DF88 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf21.hostedemail.com (Postfix) with ESMTP id AE1831C000C for ; Tue, 9 Apr 2024 09:19:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712654387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=x2zQRnijqWIlvHrbD91x35hLc4r+aZn3XU4n4wfFFaQ=; b=Ej6HlnvNPo2jplNcY3FHfBs830Z3DnPIZdmeGeqhGiCuS3UlIZwMCByI10noToo7j+lC3M uCHrWTLQrJFie2IaDJtzo7zDbXN+yGAi234S+IkucQehf3P8ZzI0ISKNmyYHg8GpbK/b3/ SFUHRl4k++zki9I+fn5rcq8C6D08mX0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712654387; a=rsa-sha256; cv=none; b=0IHw0mbjjJrjSvbNrgsqgQ+jwAz5mndd3hNNIR6qu+5tp9lUUW0KipaNEBG35PoWw8IXu/ 4x/bkmQt0r+9KS6LEFcn1hxXC80ZZEDnBDKT88fYhA/2YbvWJriOccaEgRjAcAcMcv9X2y aW5xrqRh3BStre8tNGfynKDyUb54RLU= X-AuditID: a67dfc5b-d6dff70000001748-25-6615082a1610 From: Honggyu Kim To: SeongJae Park Cc: honggyu.kim@sk.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Date: Tue, 9 Apr 2024 18:18:09 +0900 Message-ID: <20240409091812.3003-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMLMWRmVeSWpSXmKPExsXC9ZZnoa4Wh2iawdlflhZP/v9mtbi8aw6b xb01/1ktDn99w+TA4rFpVSebx6ZPk9g9XmyeyejxeZNcAEsUl01Kak5mWWqRvl0CV8biqV8Y C44JV6w/WNzA+Iu/i5GDQ0LARGLpjtwuRk4w8/Llr2wgNpuAmsSVl5OYQGwRAUWJc48vsnYx cnEwC0xnlNh4YjMrSEJYgFNiU/d5dhCbRUBVYsHjjWA2r4CZxNv2g+wQQzUlHm//CRUXlDg5 8wkLiM0sIC/RvHU2M8hQCYGvrBJLl06HapCUOLjiBssERt5ZSHpmIelZwMi0ilEoM68sNzEz x0QvozIvs0IvOT93EyMwqJbV/onewfjpQvAhRgEORiUeXourwmlCrIllxZW5hxglOJiVRHiD TQXThHhTEiurUovy44tKc1KLDzFKc7AoifMafStPERJITyxJzU5NLUgtgskycXBKNTDqWnD5 /FVb/SBf/ND211Nkr7+ZXuLv7303r449s82OtcDp7keGCsX85cnb79zZeP624oXr7f++705a 1i1uEShluzLvyALGJBF+g65fX+MC1EU35Rzh6ghOeMW079rJNZJsVQukYt0i9qTyn4xNizvg 4L/jw60nK0K2Hrx3bc5+2Xu9pXsPSNsosRRnJBpqMRcVJwIA7V/FaiYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42LhmqGlp6vFIZpm8Ou/nsWT/79ZLT4/e81s 0fnkO6PF4bknWS0u75rDZnFvzX9Wi8Nf3zA5sHtsWtXJ5rHp0yR2jxebZzJ6fLvt4bH4xQcm j8+b5ALYorhsUlJzMstSi/TtErgyFk/9wlhwTLhi/cHiBsZf/F2MnBwSAiYSly9/ZQOx2QTU JK68nMQEYosIKEqce3yRtYuRi4NZYDqjxMYTm1lBEsICnBKbus+zg9gsAqoSCx5vBLN5Bcwk 3rYfZIcYqinxePtPqLigxMmZT1hAbGYBeYnmrbOZJzByzUKSmoUktYCRaRWjSGZeWW5iZo6p XnF2RmVeZoVecn7uJkZgAC2r/TNxB+OXy+6HGAU4GJV4eB3uCKcJsSaWFVfmHmKU4GBWEuEN NhVME+JNSaysSi3Kjy8qzUktPsQozcGiJM7rFZ6aICSQnliSmp2aWpBaBJNl4uCUamDcX7Op iD30Q93GCaJXp7I0pTNXN3D4Ru0SN/V9/bTdZZ/sn68+evdj/3/W/t8qpPv73UP+A8rtjxYv 8J6TfkS+b7nu9cmSD32tg89bZ29kSZ3Ycrbeiv3e+WnXDk47FZO/ssg4ZyV3vEWEmGw3t+m8 9x8jGKa8Oaw/Z/fTiKwXkQbcZ4/POzdLiaU4I9FQi7moOBEAhApk3RwCAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AE1831C000C X-Stat-Signature: 76yff5z5kg8jxkz7oo7k4s46uk8haaxb X-HE-Tag: 1712654384-938617 X-HE-Meta: U2FsdGVkX1+NyaSwM8xRlXDdp02MiPmYtXxcl0ZmgFl2dUxmqGu2apuHpTe5WsHtt9btkNg4dkZyyaQe3XpstdqqyHfxjDA7fW4JCKZxTt94uGvrbuB7jI2VEs+xX10njUGTF5DXwqtjso9qHnzsUY7RimnzdqohPeQaEozOJjCicnTVSpBZEfTsvgZOa36wa9KU8JpbOdi4MGJ/5yzCX0J30pStxSeWJvT/EpsUYWe3Dgc+CoGGWluDdRl9b0vzjn1kBSSDe4fhod7UATPmXHdbw8QQchQ1ui1VIZ7mNixm9fybvnhpqwa7uExb9D5M0mthM4gwwsP3yjmho1WF3Of2Jqibl3YjZtG5KModkpwGrhZ34jQlHmbcon9AiiDzpltNMTAU4KOnYj4slUWq7dlBv4nBfcL6Hwtfz1FpijBiZ/ufIq0iSqPRNC1vanRjpY3bzaBWlCV7hcWGl/u+e69N+1cikumWNxr8R3Qc1gbWkdi7kSE9Zxv5pFVxH81r4GXnUHPj63Bk+GimoxaDp1FOPE/XVIspAmlUfyueW02sVUbtxlfapyt77XVr8mXOWe2AmjOENyqVyyE/vIrkzTDwdOE3X4pvlsnDDHUfH565Ez+vOs1QX8509QLimTWMtTBTVOI/XLYfK08kqZIVztGuBE8rUYeCKvoE+Rsv6fhFZsHfgls8myg/qUsijy7XmPqVMcwsJ8CyWMo9XOaU4073Vl1BaX/fmJ87e00VMPVRwFGNsr8hdN3hOk0clmLCmMyrrCoQCFV86h/vhdsBa9xSBSQQc6kuJU2k3rRguQ/3wYbutOLNLyV4dNvu9iGbbrjpTXEMJDvFYUVvWFfyhV2rosDDNCrfcnLzOwCdT4+5//DtfWkgKVp/CWhD10DCu4VsqkUvcjfwPnx+urrMDPPGPrUVm3omxXGDzWpyTx8UKEzwuXVcr3gwH/JUMXTHj5WxELPcVY9gQD62Ma0 OA65gmlX Cwcg3vm7axvZS6skrmo4nD3uUyn24pFB/gUNLk6FdqUDRslH3mwKA2BLCDwppQLcbreumLOv0PKv6RddzMRqiEXAKFZb4V3sdv9ef3/MVRry2tZuoxg1WE8hV0YGyoAFmOo7gmMezdVLzBwKIEcWc6Q4nEtzzEiOFVHJj9/1Ihb5CcNgTZgtXr70/Wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Subject: Re: [RFC PATCH v2 0/4] mm/damon: add a DAMOS filter type for page granularity access recheck In-Reply-To: <20240311204545.47097-1-sj@kernel.org> Hi SeongJae, On Mon, 11 Mar 2024 13:45:41 -0700 SeongJae Park wrote: > Changes from RFC v1 > (https://lore.kernel.org/r/20240307030013.47041-1-sj@kernel.org) > - Rename __damon_pa_young() to damon_folio_young_one() > - Mark the folio as old from the filter for the next check > > DAMON allows users to specify desired ranges of overhead and accuracy of > the monitoring, and do its best effort to make most lightweight and > accurate results. A recent discussion for tiered memory management > support from DAMON[1] revealed that the best effort accuracy may not > suffice in some use cases, while increasing the minimum accuracy can > incur too high overhead. The discussion further concluded finding > memory regions of specific access pattern via DAMON first, and then > double checking the access of the region again in finer granularity > could help increasing the accuracy while keeping the low overhead. > > Add a new type of DAMOS filter, namely YOUNG for such a case. Like anon > and memcg, the type of filter is applied to each page of the memory > region of DAMOS target memory region, and check if the page is accessed > since the last check. Because this is a filter type that applied in > page granularity, the support depends on DAMON operations set. Because > there are expected usages of this filter for physical address space > based DAMOS usage[1], implement the support for only DAMON operations > set for the physical address space, paddr. > > [1] https://lore.kernel.org/r/20240227235121.153277-1-sj@kernel.org > > > SeongJae Park (4): > mm/damon/paddr: implement damon_folio_young() > mm/damon/paddr: implement damon_folio_mkold() > mm/damon: add DAMOS filter type YOUNG > mm/damon/paddr: support DAMOS filter type YOUNG I have tested your patches for evaluation of [1] and it all works fine. Thanks very much for doing this work! Tested-by: Honggyu Kim [1] https://lore.kernel.org/damon/20240405060858.2818-1-honggyu.kim@sk.com > include/linux/damon.h | 2 ++ > mm/damon/paddr.c | 64 +++++++++++++++++++++++++--------------- > mm/damon/sysfs-schemes.c | 1 + > 3 files changed, 43 insertions(+), 24 deletions(-) > > > base-commit: 13043cde46a19e72d37965b67b74e564623f65e7 > -- > 2.39.2 >