From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 844E1C67861 for ; Mon, 8 Apr 2024 19:30:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9B5F6B007B; Mon, 8 Apr 2024 15:30:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4B9B6B0082; Mon, 8 Apr 2024 15:30:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3A796B0083; Mon, 8 Apr 2024 15:30:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B5E936B007B for ; Mon, 8 Apr 2024 15:30:03 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 188A040151 for ; Mon, 8 Apr 2024 19:30:03 +0000 (UTC) X-FDA: 81987355086.04.F7B0347 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id E8C1320016 for ; Mon, 8 Apr 2024 19:29:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bdozUmcc; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712604600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=69ok7juk8HY9S39Wub66Ms9+5DelV8WKuCWrWTFNHa0=; b=AaFGg3lX3e7+dw+NBxj9yvJtuGa4WLCKsbGCuH7Spbhe28L+q3H0074M7MW2S0GQcF+PdI /U7D9WBkNlwzREH7LFtfZFZB7tlzaK2eF64rYc6Ky7kM4wR412GWQw1LzDviXFYn75JZcM RJ5XOJoa6DX/Wm7SfCVSx96inTnZACM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bdozUmcc; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712604600; a=rsa-sha256; cv=none; b=NkfUbQQoZpCvmALKMNyviELWQe8V73dUAR+Qzk7QO8WfuOOkUDds1znhdX1/KYghL2Cfkq 3qlnpnC8liLxic2gbpM8RgDSKfIrSL4h3fIq/gG0S8NuhHoAgawUY14pdVzqaQXksGLLnm C9Mvnciz+WDq2vlzz0KPj6FMsBebcUA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7DE95CE1253; Mon, 8 Apr 2024 19:29:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 929C5C43390; Mon, 8 Apr 2024 19:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712604595; bh=kQkMMTWJKJG0SE0NuG2h3ck1w6oNzr+kJSFaydlkQZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bdozUmccnNh6Z4oM2QWc49IVIOjNECLXM5mZF+uyV6IDh0yhJpFUXbuTWdABlj9QX eFHsCWhTLCcJ1hpW9zOhnVsONVQ+7tclbZVHuPEHYnVlMSUUc7Alwq5eN+ZRor9no4 G01SiGu9MzsObRAG+M2FiyZsnTWniz4M1+cdvuDQ= Date: Mon, 8 Apr 2024 12:29:55 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , Subject: Re: [PATCH] mm/memory-failure: fix deadlock when hugetlb_optimize_vmemmap is enabled Message-Id: <20240408122955.82183316d06cfe32fbacad0e@linux-foundation.org> In-Reply-To: <20240407085456.2798193-1-linmiaohe@huawei.com> References: <20240407085456.2798193-1-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E8C1320016 X-Stat-Signature: oqbs7sowa57ym4hrc14q71qs4oqcxicj X-Rspam-User: X-HE-Tag: 1712604599-236774 X-HE-Meta: U2FsdGVkX18Vg1nDsV6nBx2PUqUtTrKGFfCJ+ZqC7u8O/+a9ygGliT1NPO7mhT944CdYmIAHaI+KXL4mRL87Fi+WHL50YDhmd4SfhNM3/0So3rTBLk+xfEZj1mM+k2VpYVEFmNIqlvW5szV4i/qIVwNM2iD/26hBNgVAC2CHSzKCOAMocarWTJf6ISuFYBwUFI35lNHyhuEbyusnyBR/6k/fdsO5L7Pu7Wc1bzvnZyl1hHx0dCDZjfWCtx4qBt6Aq7u4fgq7URsnNSXXMdrYa3kjjqAHuVvrkhXnh9Sr8nxtuK0ZhVCICVmE1HxKyfhmlBgrTvoJLQhVq5l3bcgD2poKm1Bwi9Xl9/KdJ+51VfB9zFMerQLMuf+vNeXehYMv3KLBuL0I6vOBR75ImqMhXoaM58ih0kLJzRE3Y4AIc/yiFyjVDMa4BVuF61wwAngfBB54NxhKlLt1zdh0fJ+LDmL3LwxwLaR/r26Ubnezb0FJ/Nm3hUT7PnZP1xJllc6qKcZUTcZLaqUA9Td0bZCS+LXpLdVvjgyoEdv0ertzMmuyhgK09kr5W3koOtWMImTKc22pIdWDZ4omuNPVpy7HOKlfkAfpVcYActcMi7qozJNBm528mTZiJl2G6WAinISDZZtIjYQizkoAAVl3t7E42FBNiEki0Xhl2DMIWTQ8R9FdQQRCcPqgl7gCZ51vjYFamXHiuf0Jpg24bsd2iqGQC9Tl9HCqvunF0T4HYhaFmObnXdmwvH7tIaJwCEiYQZxfxqqY3VqIiSRqSYfc3zEZLc+eJCvFy583rLFBmZ6hzDwg7PR4elYkHECn4F4mjFXfdgEVcWybAhVwS9hDlB6zpr0eV6XiBX5QqGm0+MHGug9TyOA0y4IrieDKlBSLp+b2osQkGg82R8fIQjBwbJhMt1XirOSF8iAvzgkL4mNa3iifdMBckMJqJsTZAZ7qC1I3GKP24TXnbgJZO5ycaHN +Zzuicio ZSSV/rALa7EMkIcfx2SxH2HtXob7pzz6Bunpm/wPaUltmJCmR2J94dfH/1WuuxYHSFAhMsXJT4HIKTXCikCfSk93j8RYnFuieE7V4Ar4Da+VefZWb9gJobkmhI4s4MfwJuThqdsioEJ7l4nkj47V2n5bVftZC9n/dzaRXpJdhlYmvjvJ36JEYj9BbzXcTDG7lvx9HAC7+Iwy2QJ66DpARiCVsjDpG4OTzon+Iosn5MENKb4aJIjEWOeKz/6qW10VxMhK+4MNVfgKXJxaNhRcOo8SoR/qshTVweqCvHm6vZJR4bbr8tFj3ENrRQtfJfUCiLlRUDMyNYIQLjQ/YMeJhVZ/e7Z4D/xrcWDL4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 7 Apr 2024 16:54:56 +0800 Miaohe Lin wrote: > When I did hard offline test with hugetlb pages, below deadlock occurs: > > ... > > Fix this by calling drain_all_pages() instead. Thanks. I propose Fixes: 510d25c92ec4a ("mm/hwpoison: disable pcp for page_handle_poison()") Cc: