From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A83CD128A for ; Mon, 8 Apr 2024 10:57:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1D536B0082; Mon, 8 Apr 2024 06:57:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACD586B0083; Mon, 8 Apr 2024 06:57:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 995B66B0085; Mon, 8 Apr 2024 06:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B31C6B0082 for ; Mon, 8 Apr 2024 06:57:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 02A161A0983 for ; Mon, 8 Apr 2024 10:57:02 +0000 (UTC) X-FDA: 81986062326.11.FAF80E9 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf12.hostedemail.com (Postfix) with ESMTP id F17DB4000F for ; Mon, 8 Apr 2024 10:56:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712573821; a=rsa-sha256; cv=none; b=cYrUucR3ene5HAvbVXZM85kFAHiqVAgsM1VfQmoBSz1buEPPSceOJinmoomhFaNC6HnsLI oBU5KzyXlAqpmdS8y27CDHTJeluL8RhclRg8ObKUTK/zPkTdT4boiVrmrXGAFA/+c+DhYh zebEu5AsaqhQT3I8XF/ZaTjFoeNRBm4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712573821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nUgr88wuQIZhpg6kPQWxD8N/qj+vyMMrQij1DGc1nc=; b=G6cCVPoT/layVAQB5ynY3ImY2hawd8HcF71J4KgfnMqYRQJbnmIYS4MwiJd+pghbF16GjF Ii+odOUQo2ZlI6oOj8IeUfCm/UvQ/zu8GX65PvKj9dRROiOJCorf7WWv3oJv8d6jscXLXD YeJwjyx177N8y26t2gnue89DskdQJWw= X-AuditID: a67dfc5b-d85ff70000001748-0c-6613cd78f8c3 From: Honggyu Kim To: SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: Re: [RFC PATCH v3 0/7] DAMON based tiered memory management for CXL memory Date: Mon, 8 Apr 2024 19:56:30 +0900 Message-ID: <20240408105635.2927-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240405192800.67163-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsXC9ZZnkW7FWeE0g2VT+C0m9hhYzFm/hs1i 140Qi/sPXrNb/N97jNHiyf/frBYnbjayWXR+X8picXnXHDaLe2v+s1ocWX+WxWLz2TPMFouX q1ns63jAZHH46xsmi8mXFrBZvJhyhtHi5KzJLBazj95jdxD2WHr6DZvHhiYgsXPWXXaPln23 2D0WbCr1aDnyltVj8Z6XTB6bVnWyeWz6NInd48SM3yweOx9aerzYPJPRo7f5HZvH501yAXxR XDYpqTmZZalF+nYJXBmbpj1kLFjFX3H+dxtTA+N37i5GTg4JAROJQ2c3ssDYR04tYAax2QTU JK68nMQEYosIKEqce3yRtYuRi4NZYAaLxOGFXYwgCWGBYInFf2ezg9gsAqoSOyf9B2vmFTCT OL7qFxvEUE2Jx9t/gtVwChhLvH70DKxXSIBH4tWG/YwQ9YISJ2c+ATuCWUBeonnrbGaQZRIC h9gldnzuYoIYJClxcMUNlgmM/LOQ9MxC0rOAkWkVo1BmXlluYmaOiV5GZV5mhV5yfu4mRmDk Lav9E72D8dOF4EOMAhyMSjy8JyYKpQmxJpYVV+YeYpTgYFYS4Q02FUwT4k1JrKxKLcqPLyrN SS0+xCjNwaIkzmv0rTxFSCA9sSQ1OzW1ILUIJsvEwSnVwGgZ9SLjuEaultkknrsOmSE+Vp6t m4rYo6tNJjsGvZJb/cbgzJUfeQKL3d49PVs+Q3NaoX/06pZ4vWvzw593rPQ5uWFa5senGyPW 5nxQd5S9KFo2+Y/+cc6K9BXrud/fE5z93fPl0ZL4RMYD6TsDVOYv2XX1dntk+qcoBUfz9U+1 ZdYlZfzSnajEUpyRaKjFXFScCACIMt/NuAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsXCNUNLT7f8rHCawZMGS4uJPQYWc9avYbPY dSPE4v6D1+wW//ceY7R48v83q8WJm41sFp1PvjNaHJ57ktWi8/tSFovLu+awWdxb85/V4sj6 sywWm8+eYbZYvFzN4tC156wW+zoeMFkc/vqGyWLypQVsFi+mnGG0ODlrMovF7KP32B3EPJae fsPmsaEJSOycdZfdo2XfLXaPBZtKPVqOvGX1WLznJZPHplWdbB6bPk1i9zgx4zeLx86Hlh4v Ns9k9Ohtfsfm8e22h8fiFx+YPD5vkgsQiOKySUnNySxLLdK3S+DK2DTtIWPBKv6K87/bmBoY v3N3MXJySAiYSBw5tYAZxGYTUJO48nISE4gtIqAoce7xRdYuRi4OZoEZLBKHF3YxgiSEBYIl Fv+dzQ5iswioSuyc9B+smVfATOL4ql9sEEM1JR5v/wlWwylgLPH60TOwXiEBHolXG/YzQtQL Spyc+YQFxGYWkJdo3jqbeQIjzywkqVlIUgsYmVYximTmleUmZuaY6hVnZ1TmZVboJefnbmIE xtiy2j8TdzB+uex+iFGAg1GJh9eDSThNiDWxrLgy9xCjBAezkghvsKlgmhBvSmJlVWpRfnxR aU5q8SFGaQ4WJXFer/DUBCGB9MSS1OzU1ILUIpgsEwenVAOjXLWr9sYjr+SX3vyh7eooebUv Q/xfgfV9rWwWxoNMr9iiznROvBC9e8p6WU65V9fOb24W22NieI/x4ewny5007JbumzxDSmuq pmn2HLPKKQpX95yLM/OYeXIqm8TviYEKYTNnpf3rlH18zNupUU5kf5Ly1rsiy9yUY5tTwm/5 3ZRnT82SWPVAiaU4I9FQi7moOBEAzndwPa0CAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F17DB4000F X-Stat-Signature: 5ffpumuzuk8zcefiofqfgqxxxokdt7h6 X-Rspam-User: X-HE-Tag: 1712573818-438431 X-HE-Meta: U2FsdGVkX1/hNQ/DJqtwIHx4d25ZupTf/wTYqeXYOBmdxQRcer8Opwabew5u0bGG34L2jo+ar5//zsnfGYEa3zwp01D9eW5C4s/hYCLRFkhAUuT1t/sV8jgSrRmQiw3gCvwQ0Rt6vO5t2dkr0C9hHVe7Q6kviNf/aJcbJHodrR/lVERblew2vJRpWizqoifz/6GNy87SKpWWykj1EIY9cSEEtD+3uXK5Mw6E0D+52HFl9ECUy7SdydGqLL+mG3ng5CJAXp8p+fGe89cDEEcQiwxa3q+GPmiopMlbRgIzlhwGFz6j2WdRazkR+2+Kw80BeqGb2uHAlBmcVRdJsdVHi4J6I8Bhq1YNhaSI9JclI261UEG752USku/FaWmi/XSaj5Q70ZnzGv/pnEoQ80WrWxzmrFA/C6ppd/4dNjW2DTHgElilDEVpprjrczqZnxH7IHWoYWh6nXU4VFqP2AE9pisByHltKaNZPUsJS16k0lgtKudD6rC1PIpEsxi1Ijw2FxS4NrUJbFzqlNxn7fSjYLwOVzCCysamjvMzHvYLL2WPY2eS2vMlwvSwHBtAjj1gYHlzApic+8DYJZ3H+EnPqX5N+zy7eGFw26B911LILHqk+0xNha2oQzBwl+jjJcC50hSHNq3L5+bmOBIHjuK0NSLM7b5FXJTqmaoJYNoAVj7mS/ro9Ty/GCnSnrLkeUoK3OkAHj4/OSTzXpUdTSl67LdkHQFpVOfnerWDCPptP2ybIgJBqzPz6mKYqE8ctrCYlkFPlZTJxngcuzKrZBwu5XTZTtr162S3ayWFJOGvzOEToj0b11ACqk+cSTpA8ehO X-Bogosity: Ham, tests=bogofilter, spamicity=0.005454, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi SeongJae, On Fri, 5 Apr 2024 12:28:00 -0700 SeongJae Park wrote: > Hello Honggyu, > > On Fri, 5 Apr 2024 15:08:49 +0900 Honggyu Kim wrote: > > > There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously > > posted at [1]. > > > > It says there is no implementation of the demote/promote DAMOS action > > are made. This RFC is about its implementation for physical address > > space. > > > > > > Changes from RFC v2: > > 1. Rename DAMOS_{PROMOTE,DEMOTE} actions to DAMOS_MIGRATE_{HOT,COLD}. > > 2. Create 'target_nid' to set the migration target node instead of > > depending on node distance based information. > > 3. Instead of having page level access check in this patch series, > > delegate the job to a new DAMOS filter type YOUNG[2]. > > 4. Introduce vmstat counters "damon_migrate_{hot,cold}". > > 5. Rebase from v6.7 to v6.8. > > Thank you for patiently keeping discussion and making this great version! I > left comments on each patch, but found no special concerns. Per-page access > recheck for MIGRATE_HOT and vmstat change are taking my eyes, though. I doubt > if those really needed. It would be nice if you could answer to the comments. I will answer them where you made the comments. > Once my comments on this version are addressed, I would have no reason to > object at dropping the RFC tag from this patchset. Thanks. I will drop the RFC after addressing your comments. > Nonetheless, I show some warnings and errors from checkpatch.pl. I don't > really care about those for RFC patches, so no problem at all. But if you > agree to my opinion about RFC tag dropping, and therefore if you will send next > version without RFC tag, please make sure you also run checkpatch.pl before > posting. Sure. I will run checkpatch.pl from the next revision. Thanks, Honggyu > > Thanks, > SJ > > [...]