From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F27CD128A for ; Sun, 7 Apr 2024 17:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB7526B0095; Sun, 7 Apr 2024 13:20:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C68156B0096; Sun, 7 Apr 2024 13:20:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2F346B0098; Sun, 7 Apr 2024 13:20:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 94BCB6B0095 for ; Sun, 7 Apr 2024 13:20:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 67009A0207 for ; Sun, 7 Apr 2024 17:20:39 +0000 (UTC) X-FDA: 81983400198.05.EBDF405 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf18.hostedemail.com (Postfix) with ESMTP id 9BAE71C0026 for ; Sun, 7 Apr 2024 17:20:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="f/hYVYj9"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712510435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCwzYTi3qQQ8obIcA94XO3Gk5IF757LbEu8pKM5p6e4=; b=mTtuKjeOeRD5T5CiNA3Dy56EMnhPHuZJOyNrRY8Fyliu8WQDGJtWszeg23S0Qqqn35Dc1m b1uPTC5X4HGgocqZpyJOD/9Fdc58ZKBPqo/r2XNGNGG4vrY49M5UDEg0rh0R4Ia6V6i9ML XMN7Z61FXizeOT0+dNxvw8DFxH3xr6k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="f/hYVYj9"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712510435; a=rsa-sha256; cv=none; b=18JmoiT4yabeeok73pZr0oXq1+k93WZ6JIkDaTPgMfbGVDdwWPnkXbkrdOv6J1AFzEZjDS ZqdwyL7PsWogwatVM7pbv+V6ihfYbb2ovGlkCakkyPklp9bvjMGoT3Jp9Rk92Oamz1sNed p/uOUYFaAkhjTUKmAVZB7Nhm5aCZnQk= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 437GVQib018929; Sun, 7 Apr 2024 17:20:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=wCwzYTi3qQQ8obIcA94XO3Gk5IF757LbEu8pKM5p6e4=; b=f/hYVYj9UrKn0dcL64I4sd0BDUJso/AktFobSHs1ka36ocblThYThcWkXssWk74gC2Do 3hRBuEXta1RHUsIVgiUA4YIFicbSg5I8NDy3+wpKT17i37a3OponLVPxJ4WVyruIqhLM sML/0e3KzSbTL+fQhRQ0hhmPcTOTt+sPHKkFG2FnZ4D11HOIC5KNNfZzEP6OU0138NXf 8Xd304Wd4XSMg1cldcBQNs/+etwR0E6GzewWNqyALEV7TLH8fs0N5hoVZ+E65YiBSyWY rIpuvSjW6w2NVUPGW3Nt/p7IySj+g2jPahWlPdayV+Hbn26bsw/8/AjS3knZI6fb2Rk3 kw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xbsac0jkw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Apr 2024 17:20:02 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 437HK2eI024934; Sun, 7 Apr 2024 17:20:02 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xbsac0jkr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Apr 2024 17:20:02 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 437G0Upn013760; Sun, 7 Apr 2024 17:20:01 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xbgqt3t8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Apr 2024 17:20:00 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 437HJtn712058960 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 7 Apr 2024 17:19:57 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C59F20043; Sun, 7 Apr 2024 17:19:55 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2F65020040; Sun, 7 Apr 2024 17:19:54 +0000 (GMT) Received: from osiris (unknown [9.179.2.159]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sun, 7 Apr 2024 17:19:54 +0000 (GMT) Date: Sun, 7 Apr 2024 19:19:52 +0200 From: Heiko Carstens To: Kefeng Wang Cc: akpm@linux-foundation.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 6/7] s390: mm: accelerate pagefault when badaccess Message-ID: <20240407171952.5958-B-hca@linux.ibm.com> References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-7-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403083805.1818160-7-wangkefeng.wang@huawei.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: b-EEOAEEwlQYwv7cl_y3sNF2TyvQW26w X-Proofpoint-GUID: a_Cqxs0DB0iEGztJhKKGFrHC8k3JLA6H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-07_10,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxlogscore=794 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404070138 X-Rspam-User: X-Stat-Signature: 4bpay9ps193upiiwx4gyq8jw663he8bz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9BAE71C0026 X-HE-Tag: 1712510435-46273 X-HE-Meta: U2FsdGVkX19jNwE0ae4wZ7r0ZO9EV3IMK9KqRixYJlj61NfLfRWLX4g3fzxQaijMLbTybuaSyS/ZjsElIFEdipNA31alXJ9aFqlKU5syy6mKCQ5AHpv9hlSHVmqFw3frmbJwqs5NpenJs4JEPVNpipdCvFhqdz6mNPKsBUAheEiePZXp1gIUC6RVfqiosSt49/rzXQ5J6TdFAUbYAOOTpEbKjd525gVX2d55GyCCKrM4gxgyZADG64yDbjmgbVxlnt6N7AW0yutfb/AGwIdmbfTCIWjbJ93UgmTQn5WlKlIgD32AmfZyh4/EnnOuvVS89FGsIoTBMrkq3JzL4D5tlyOQbNSRw2ot4ZVlNFH+7WqUD3MJHM0iyfs+P/ZtuL6bYDGGDPamIpk3xuA6RbFq5ZMfWHJtn70G1OjOxgnoPwO/EykWaWPVV9gSrWOUMo6rCFxqEGlwsndxfDHy18EL6hnUwvADq0Idr8oXiMdy0HRSD4Ygxq0oRYzh4QqVrPvdlrgR6c/H+BHnW7MqU5wkK0dLd+/lG2pWb5W7t3YyGC/TjwfGNkJmk744wBLzVIiA5E/4Ez/An3bRnaTIjnQ3XWLiT2vuLlc+pLycLmjrSDJ9ZUn151XOt978RbusxzSzgOA6BbaVqEPfH9+A4Gq6A0mwbNYRW5O96+0KoZqKeW3JfY6X2QKgOJnEUHFOktLYT2MUl87NBUlr/9XaNSx2qgRTWgn4SDcDxbpEWgzPjxwwpmyOwAucpaX5cgEzmrise9X9KxGbGR6zyf0/yNE/m5sqxXi6xwFV8OZt623VGu22Xxw0nGwbf25HEjD8sXvFSz4jhJ8rnUVwdPFuWPVf48LhgeXa8vAZGhiC2O2kMouRK/YyhfJSY7EAchuULdZQq+xyOGMTUeLE5JzD97vqLdSGAuXjnyUExXpvrS6bbxJEWWsBJvg3t/rI1FGKP9Q/Che3o5WtbI523hWDIcU K3jdy1sD 0f3UkO3by8AaKGmCGTnb50op7Hea+pMON7vrQzu21mHT+ue3VUB0q9ETkLAwM2Rh9LA+uEREBAyb6p8xLRf7xPB47Rne1PIg4UznN4qBEGERiaORnMpP7Nm7uihkXIl2m5skUj8vJ4V1IVKA2dlEj/sjkItv6i04/YH/H1CO9D2Pw0onyti4/2t1xaDoQMvf1PogSQip+gyxfhXztVBZo+TULB0Pn4thETlPsBMGSmjTOUTB4iSLc3OzZA7alFV1hNGBsYreUoX1yjZw1CsEisEKkQdqVpLe52C8z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 04:38:04PM +0800, Kefeng Wang wrote: > The vm_flags of vma already checked under per-VMA lock, if it is a > bad access, directly handle error, no need to retry with mmap_lock > again. Since the page faut is handled under per-VMA lock, count it > as a vma lock event with VMA_LOCK_SUCCESS. > > Signed-off-by: Kefeng Wang > --- > arch/s390/mm/fault.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c > index c421dd44ffbe..162ca2576fd4 100644 > --- a/arch/s390/mm/fault.c > +++ b/arch/s390/mm/fault.c > @@ -325,7 +325,8 @@ static void do_exception(struct pt_regs *regs, int access) > goto lock_mmap; > if (!(vma->vm_flags & access)) { > vma_end_read(vma); > - goto lock_mmap; > + count_vm_vma_lock_event(VMA_LOCK_SUCCESS); > + return handle_fault_error_nolock(regs, SEGV_ACCERR); Reviewed-by: Heiko Carstens