From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33747CD128A for ; Sun, 7 Apr 2024 17:20:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1AF96B0092; Sun, 7 Apr 2024 13:20:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCA946B0093; Sun, 7 Apr 2024 13:20:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92CC6B0095; Sun, 7 Apr 2024 13:20:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8AE4E6B0092 for ; Sun, 7 Apr 2024 13:20:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 48512A0207 for ; Sun, 7 Apr 2024 17:20:06 +0000 (UTC) X-FDA: 81983398812.25.0595852 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf18.hostedemail.com (Postfix) with ESMTP id E6F2F1C0012 for ; Sun, 7 Apr 2024 17:20:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Vy+JfL7+; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712510403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F86vIyT96NLScE6Zk6mOrLIIbnCvATnEMB/X/BdWurM=; b=SuKfrpKOfI42aLmTF46oawW6hKsgu+cE2ZdvtfbSP6PaumdYXFOtuCT4qj8/nOU9ziKzlr /BxFCBvlbV0f5mOmDYMYmqmYVm5Uh9CESwZY2T6YsJvXFyk9QrP+CPgWABGnsrd5g7bRIL GxWxHH/w7KDTa8alfYP5ig4o/GUNQdI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Vy+JfL7+; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712510403; a=rsa-sha256; cv=none; b=wZUrnFGRtjt5mcKPoC5rGW5XWht5RG9x/ITAqtiI15WOIkHj7eZbxfA82YFcZkBan5Ct5v 29o2oEuj0JmW4frzV0aoo61Eom6RgTeN87/VdEThDihvhqCkmSIWaRAlTQsa+EKqVl1KXI iSCce2gR1CA6O2tyK6IiExP5vqoGNO4= Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 437GxAvB025509; Sun, 7 Apr 2024 17:19:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=F86vIyT96NLScE6Zk6mOrLIIbnCvATnEMB/X/BdWurM=; b=Vy+JfL7+GdlmHij4DY9+FF6bZBGKIzybu3H9TGxNhGMOiNojOX6vU1kcZiUile2ZWzzj xdBoUwoyOtYP6C2NH8E73yzr2geuDlQWgZsDTp5+Iatp3+IrlT56kZKLZgVECtOMYtPR LkTDs7Vdk/Yc3lJ1Mhn4FEZpQa9kh78F+6mul9elFYjbxv3mkUAXeNoCQwKRAvQioEsg vgXqRrAovajP2pMj78xg4rCIrdAvqZLlapXXlRbIUAU2z5zYjzt5z1bvp1jNwpY6p5vk Fclj73uOz2kJ1MmHrqV2Io+jRhoaAhECrFGmyWtX2RAlax5j2OLWRZiZvB7LbEkaYT1J Ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xbyf4r11k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Apr 2024 17:19:12 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 437HJBOd027129; Sun, 7 Apr 2024 17:19:11 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xbyf4r11d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Apr 2024 17:19:11 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 437EiDmP021485; Sun, 7 Apr 2024 17:19:10 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xbjxkb7y6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Apr 2024 17:19:10 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 437HJ5ah37552504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 7 Apr 2024 17:19:07 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F2FE620049; Sun, 7 Apr 2024 17:19:04 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C46CC20040; Sun, 7 Apr 2024 17:19:03 +0000 (GMT) Received: from osiris (unknown [9.179.2.159]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sun, 7 Apr 2024 17:19:03 +0000 (GMT) Date: Sun, 7 Apr 2024 19:19:02 +0200 From: Heiko Carstens To: Kefeng Wang Cc: Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Message-ID: <20240407171902.5958-A-hca@linux.ibm.com> References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403134539.fde3a6c594f2d88409be30ed@linux-foundation.org> <4d45fffc-877a-4ad1-ad02-a33341e467e7@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d45fffc-877a-4ad1-ad02-a33341e467e7@huawei.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Y3MmKFoPZYTA6URYFqSoHvL5OT_14Ypp X-Proofpoint-ORIG-GUID: Ts9vZ863gBFIi5c6rKKJKZ5ZbhTxcstc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-07_11,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=950 bulkscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 impostorscore=0 adultscore=0 clxscore=1011 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404070139 X-Rspamd-Queue-Id: E6F2F1C0012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qtrcfxsy5swgja8c8buyo3tn8hcpd8qf X-HE-Tag: 1712510402-503365 X-HE-Meta: U2FsdGVkX18z+TxFjQ1/7UzZIPvufrEkNKPnVrbtTG9mFGRNhI8g509m3saKxxEfO6pQ48EpC8mfOnKTKUGgU2/38Q/mD0qpfAo25V2e0wWrYg479x0b+JZb/fTlwKl7ZhA76PaxSOPc2CXLal3Lnw5CFKpqK3WyTwYwavXXn0lawM9O9mjy2pTy+AO3xWcJvtCCrEhKCB24K9NyEgYPv53Togh2NsRtRdfM8yxKstMMQfUUuErGp6DEHk2k5gfEdylH9iQ/IUBx2yaJXldFo2bm59B//f242XGmO/OsR+ed7VXHKSw9dcMI2dCcWS8zcM29eLkqIKTcOCXrL09t9G+1zH/dVn0HGb7SDvoTKqWTut9pHRbHO5yFhqQfjBBr78mwFj9YPgRYwRGJAEsoVjMh8H8BVEWz5oKNcL+g2e/IsTbUTARyP4uM/25jVU6g4mu9WUF6XcAfgTv2JkgSyUPr1oh3jdj7zqv2EARhPxAODIlsTlfcpyxBAn1b6t254QPcbCpG6/MxIPIB//dV2Itrv/FJ0PO9JLGnuVWLg/6Ar8ET6RbGdfOAx8fofzh/bmNKi1JSX4mgszdtO7zdxcmX3IeDdIdnOPyNFrn3V1Vah9RmKHzI9RUU8zc1A/FMM6RgjaOFBeyELLQwSK4dlSL47Ykb4gDdaTqPcu1xD7CbBh4bYGnIqUkjCCnvipt0z+NGs5Cp7HwQspc0mEykMyz6G4VdJrD8UPel3czja3BmRUO07e02SI4Us3qlG5kSQfozQwXesiWQvgiCBKzO3pdVhDKEYETOAjMmM9bJ0/YFbYFwSgR+jsm27/2gvWisZCKfcA+zb/d9G6WFttTtxuTlxgwRWRlWboSgZvv+EtKGJyw9sZLS5MwsNcae8wKEtCyedAjIdAmWnC9OTqCak1SCHSeyOiEKOkoAJRf7d2j5A67lyQN57pAecr5IiYAW8JKiT8H1K79VUJR7FjL e1VVLSE8 aCRdPSdRpjFzZVtNR+fHGKgBlQtuoPuwTkJsfBif5O7opXyVYEJP0LfBPTFBQsoQqVhe/81k1FxtMiyAX7owohB/uKPA/W1YNWITTXlvOQTKzzo2L5SKXBvkBxWDMqn06t2wAjevd7nOFdvm/QoCUIPv0lkS7pZbIKTtZVCi6wCD8oKCOjMotpDnxU6USHF/RTEqyqsFejz8Z0xRPiSz1bKPK1Gq2M+abn1w/a4L3/zcQXVTE0aMejGrQ/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 07, 2024 at 03:49:53PM +0800, Kefeng Wang wrote: > On 2024/4/4 4:45, Andrew Morton wrote: > > On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang wrote: > > > > > After VMA lock-based page fault handling enabled, if bad access met > > > under per-vma lock, it will fallback to mmap_lock-based handling, > > > so it leads to unnessary mmap lock and vma find again. A test from > > > lmbench shows 34% improve after this changes on arm64, > > > > > > lat_sig -P 1 prot lat_sig 0.29194 -> 0.19198 > > > > > > Only build test on other archs except arm64. > > > > Thanks. So we now want a bunch of architectures to runtime test this. Do > > we have a selftest in place which will adequately do this? > > I don't find such selftest, and badaccess would lead to coredump, the > performance should not affect most scene, so no selftest is acceptable. > lmbench is easy to use to measure the performance. The rationale for this series (performance improvement) is a bit odd, since I would expect that the changed code is usually never executed.