From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C736CD11C2 for ; Fri, 5 Apr 2024 19:26:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B609E6B008C; Fri, 5 Apr 2024 15:26:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B11F06B0092; Fri, 5 Apr 2024 15:26:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FECB6B0093; Fri, 5 Apr 2024 15:26:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 835826B008C for ; Fri, 5 Apr 2024 15:26:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4B344A1314 for ; Fri, 5 Apr 2024 19:26:56 +0000 (UTC) X-FDA: 81976460832.23.468CD96 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id C021440010 for ; Fri, 5 Apr 2024 19:26:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SboxYC3e; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712345214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o16nDQwku965H5/JYbHPoB6nEhKiyVvD6Mn3nVoMOTA=; b=N6j2E8pj8zKLi+uj2JZwmXULyfbuEp8IlQ1KzDg4eWXJ/CTnZ37QE+D7JF7ttrzVL2XN/d scJ9Q/DMIWvFIdozFi6g1I28O+dtGKSxgue0MOqu/O45URvWcsAepIBF8KhlvUmBc4bW+O BkogjJVPrKQoLreEvi2vi9ozXurwa1M= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SboxYC3e; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712345214; a=rsa-sha256; cv=none; b=znzW2tCEro80RD0+wK9O3KwFBmqF5vekZLUpSlpanlrk1JnRyC1Nf3NIR9aygMFC1aBQRV d56WCJERYQPs8yRMVgL5sHIeuPm9+4sZTQytBif+fVw9realmF1ipYMhAXH3imFQ4fHtuY 1v+IffKnp60KhhhwbEd6Wep8WTpkngY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ED6366168A; Fri, 5 Apr 2024 19:26:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 018CAC433F1; Fri, 5 Apr 2024 19:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712345213; bh=gEl5yFCekr+YA46DjuYH6j3x96vUoSzFx76l82eJ5Pw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SboxYC3epexJ5wrq/hit1fKAOzsA/xavNfFwChSypo+n1i1004Y7JYSYYqkZCm/N6 3Zpg0cJcu2hRy7pCr9dGIWJIxP5/QY8oHuXLxvsrd8UO8pGgXJFPkyGnmPlerV4fs4 d8ejZgqzUt51ZnCWzv8gsXATNxuGfl7CnHONNM1LgGZVLNl78AOOEXFKLDl9UQdjwD HpvlkDs+cldef+NQuLiBjjLMC383Rp8BKh4/WXL9AABVDVq5oXQ7FSPc6+cb7LNcT8 RWevLdWKZHdwLmRO2j8TOlsviJymqvw/gpCIAh4vYAvD2w4vn8hrUQsnZL0OuMdKnP blVhxW5tJdO1g== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: Re: [RFC PATCH v3 6/7] mm/damon/paddr: introduce DAMOS_MIGRATE_HOT action for promotion Date: Fri, 5 Apr 2024 12:26:50 -0700 Message-Id: <20240405192650.67096-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240405060858.2818-7-honggyu.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C021440010 X-Stat-Signature: p1w71fk4i8k1oz6mb13kezicp7eg8jsg X-Rspam-User: X-HE-Tag: 1712345214-221690 X-HE-Meta: U2FsdGVkX19JcmSq5zVwKmDsw0/80khDNfU4+uLh/6ROxltieyUxfi/k8XqxKfBGYgvILwyLvClb6uYTAD7G/gUCgjVsYszoP0L9Hjrq/EpKOYMjcG1xI9WZ52kTX5vMczOArkojvaDLftSAQ4ynRsAl5uZO/cTbc49bF7Vi4Kg+3OWyH3Hr+E10BYg24jPtfa/eoAegZf0JWDjCmT2r/PRxa+NHLB0rDlOjTzlVZ4BeeWFX3LbbbsTEkucsUP/BzFB7k+uASv4gRjVamDJ7KKUNUPJGv7mMYsdyc0h+zjASyiQc5x/9bVP+eGexl59Mgjvtt3ADigDNwJ144C5qOL2N4Jnp44iq0RCMElPmHq0KVOXYjwAvBwMTnOxw7tYk6PHLNMod132HHqPXjEDlcMmP0mAqSVTJfOg0dDSnRz6J/ikPlmsRsCTvIYLcw1qtCcr1csUJ3J4ZBxL2vqmX/JTVK9W6G7mW3xaEGcJOxpgqGzTEJ5Y9V1ah1dberpZEouf5aR6SLpirDEpaPufG4eWblLZ3BkOwEGiRKDXVryZ1IX9iJp8QRqfxbcmY4vJkpr8SVSqLW1a1Bi0SLAAngfe1O3wQABEV4KNKiAuTVmd52UesIj5wyNRU6KYa60ELDC4P08aBXV8RuH83mzz5inG8J37tZC1tRQdGP//YOWPbKSvSATe/9PVV15Ggjd56zKwIZmoFZEcv4cffsmmIQXck+QRopqN72YM10db73wEaqlazbbRg9UNf4hgrwpNX23I4pbUHYWU6Yh1/R8RG5xdrN4Rxk0eI3MnFxMjOfBmrocdlU95y8wTD+VbTOte8xtd56hQzdrNm3H4bLLp9z5OURssXbE1l4a2RTuPQGdgoYAN6k3COpkxz3sLxZn7RvhxsOyB+c292a12PjTERWHsPwqXP9XYFW480LNBmxiZwzhHCRHCQNlXqvL+wiFQXDHdZggF5taPKcfrMiQl 19nBlL0K 4CI6XMz+5jGRImc2NjpqVc+kXzVJaL9IhYF3J3KJp7WgamkSFFmdnvHmyFIVNWA0RwVBQa7i/cW9CR4E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 5 Apr 2024 15:08:55 +0900 Honggyu Kim wrote: > From: Hyeongtak Ji > > This patch introduces DAMOS_MIGRATE_HOT action, which is similar to > DAMOS_MIGRATE_COLD, but it is targeted to migrate hot pages. My understanding of our last discussion was that 'HOT/COLD' here is only for prioritization score function. If I'm not wrong, this is not for targeting, but just prioritize migrating hot pages first under the quota. > > It migrates pages inside the given region to the 'target_nid' NUMA node > in the sysfs. > > Here is one of the example usage of this 'migrate_hot' action. > > $ cd /sys/kernel/mm/damon/admin/kdamonds/ > $ cat contexts//schemes//action > migrate_hot > $ echo 0 > contexts//schemes//target_nid > $ echo commit > state > $ numactl -p 2 ./hot_cold 500M 600M & > $ numastat -c -p hot_cold > > Per-node process memory usage (in MBs) > PID Node 0 Node 1 Node 2 Total > -------------- ------ ------ ------ ----- > 701 (hot_cold) 501 0 601 1101 > > Signed-off-by: Hyeongtak Ji > Signed-off-by: Honggyu Kim > --- > include/linux/damon.h | 2 ++ > mm/damon/paddr.c | 12 ++++++++++-- > mm/damon/sysfs-schemes.c | 4 +++- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index df8671e69a70..934c95a7c042 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -105,6 +105,7 @@ struct damon_target { > * @DAMOS_NOHUGEPAGE: Call ``madvise()`` for the region with MADV_NOHUGEPAGE. > * @DAMOS_LRU_PRIO: Prioritize the region on its LRU lists. > * @DAMOS_LRU_DEPRIO: Deprioritize the region on its LRU lists. > + * @DAMOS_MIGRATE_HOT: Migrate for the given hot region. As commented on the previous patch, this could be bit re-phrased. Also, let's use tabs consistently. > * @DAMOS_MIGRATE_COLD: Migrate for the given cold region. > * @DAMOS_STAT: Do nothing but count the stat. > * @NR_DAMOS_ACTIONS: Total number of DAMOS actions > @@ -123,6 +124,7 @@ enum damos_action { > DAMOS_NOHUGEPAGE, > DAMOS_LRU_PRIO, > DAMOS_LRU_DEPRIO, > + DAMOS_MIGRATE_HOT, > DAMOS_MIGRATE_COLD, > DAMOS_STAT, /* Do nothing but only record the stat */ > NR_DAMOS_ACTIONS, > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index fe217a26f788..fd9d35b5cc83 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -229,6 +229,7 @@ static bool damos_pa_filter_out(struct damos *scheme, struct folio *folio) > > enum migration_mode { > MIG_PAGEOUT, > + MIG_MIGRATE_HOT, > MIG_MIGRATE_COLD, > }; It looks like we don't need MIG_MIGRATE_HOT and MIG_MIGRATE_COLD in real, but just one, say, MIG_MIGRATE, since the code can know if it should use what prioritization score function with DAMOS action? Also, as I commented on the previous one, I'd prefer having DAMOS_ prefix. > > @@ -375,8 +376,10 @@ static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s, > if (damos_pa_filter_out(s, folio)) > goto put_folio; > > - folio_clear_referenced(folio); > - folio_test_clear_young(folio); > + if (mm != MIG_MIGRATE_HOT) { > + folio_clear_referenced(folio); > + folio_test_clear_young(folio); > + } We agreed to this check via 'young' page type DAMOS filter, and let this doesn't care about it, right? If I'm not wrong, I think this should be removed? > if (!folio_isolate_lru(folio)) > goto put_folio; > /* > @@ -394,6 +397,7 @@ static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s, > case MIG_PAGEOUT: > applied = reclaim_pages(&folio_list); > break; > + case MIG_MIGRATE_HOT: > case MIG_MIGRATE_COLD: > applied = damon_pa_migrate_pages(&folio_list, mm, > s->target_nid); > @@ -454,6 +458,8 @@ static unsigned long damon_pa_apply_scheme(struct damon_ctx *ctx, > return damon_pa_mark_accessed(r, scheme); > case DAMOS_LRU_DEPRIO: > return damon_pa_deactivate_pages(r, scheme); > + case DAMOS_MIGRATE_HOT: > + return damon_pa_migrate(r, scheme, MIG_MIGRATE_HOT); > case DAMOS_MIGRATE_COLD: > return damon_pa_migrate(r, scheme, MIG_MIGRATE_COLD); > case DAMOS_STAT: > @@ -476,6 +482,8 @@ static int damon_pa_scheme_score(struct damon_ctx *context, > return damon_hot_score(context, r, scheme); > case DAMOS_LRU_DEPRIO: > return damon_cold_score(context, r, scheme); > + case DAMOS_MIGRATE_HOT: > + return damon_hot_score(context, r, scheme); > case DAMOS_MIGRATE_COLD: > return damon_cold_score(context, r, scheme); > default: > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index 18b7d054c748..1d2f62aa79ca 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c > @@ -1406,6 +1406,7 @@ static const char * const damon_sysfs_damos_action_strs[] = { > "nohugepage", > "lru_prio", > "lru_deprio", > + "migrate_hot", > "migrate_cold", > "stat", > }; > @@ -1660,7 +1661,8 @@ static ssize_t target_nid_store(struct kobject *kobj, > struct damon_sysfs_scheme, kobj); > int err = 0; > > - if (scheme->action != DAMOS_MIGRATE_COLD) > + if (scheme->action != DAMOS_MIGRATE_HOT && > + scheme->action != DAMOS_MIGRATE_COLD) > return -EINVAL; > > /* TODO: error handling for target_nid range. */ > -- > 2.34.1 > > Thanks, SJ