From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F506CD11C2 for ; Fri, 5 Apr 2024 19:20:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C5616B0087; Fri, 5 Apr 2024 15:20:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 875586B0088; Fri, 5 Apr 2024 15:20:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73D286B0089; Fri, 5 Apr 2024 15:20:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 58E1B6B0087 for ; Fri, 5 Apr 2024 15:20:16 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DEF3C1A04BC for ; Fri, 5 Apr 2024 19:20:15 +0000 (UTC) X-FDA: 81976443990.27.AAD1AC3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 39BC4120013 for ; Fri, 5 Apr 2024 19:20:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gU31alp4; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712344814; a=rsa-sha256; cv=none; b=CbqP/xoTc6/tBtqCr5n1cdOYGhxCEmMfOg39DS1ioIMjipviy3u/fM97mO8jJSYcpVRGpn 98N1Y8F43I8EOYvs4cTVxwihJnmFcMjIBz6svgdjqvDAHqIXgLwJGBQjtgizbEiag9n0l6 FmD/gCo4Siqd1EKNeQnQBGcafNkkZ3Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gU31alp4; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712344814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qAwWRxROooQWMzbUiQ/9XLk+9GU6dgVcxYgLM66A9ng=; b=XXQs8KkoxMV8s7GkfizMxLvYfaQmSnlWOg2yfyb3VMqpgEGlVc/X5sXzII78toP578DbPE BDXgKOKprVwEyN7QvL4hf4vD3kmFlm1DjHTvKvTL3YBm0hwchX1Or/i5I/nQ2+KycFQkE/ C2nm/1coTe9XSwFNbMkaaQP6wsDoE8o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 70F9C616F7; Fri, 5 Apr 2024 19:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 715E5C433F1; Fri, 5 Apr 2024 19:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712344813; bh=cVmiwv55exbPqh0GegYGrO5Eff/8w7HZ4re9a7wW9/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gU31alp4j+80K0uxaCifhSjrPBNRADPRlC5pu1dKcE0Va2za4o+aFzs6wJBlIkFX/ zVfU8YfYa91W4yeSwgebn8ylEGGZLy/CKFhPayqs6fqCKL2ZJzBiU6pkXLJrr+N1wC Ab0fP9odklmC6N178SqR/OUp4CpQ8GLRY+eDBaqAte62fUHvnNjNL1kc3FuqHkHTUb bN6DwxMgyG5A+HQeeil2JhKziQIlLwQjYqIDtb+r2z90J1seTS8MRTbOwBqscuGRZa mY3aBg2N/kwO5iF1G2Lg5rlT2SLHBRuzlNPLgmL9TdoC9bGmWc10qgtv+xcZAshwa+ DiBR5LBDgVVBg== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: Re: [RFC PATCH v3 2/7] mm: make alloc_demote_folio externally invokable for migration Date: Fri, 5 Apr 2024 12:20:10 -0700 Message-Id: <20240405192010.66986-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240405060858.2818-3-honggyu.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 39BC4120013 X-Stat-Signature: 7se8asqif3q6h37aw9bicos1jhcc8pxe X-Rspam-User: X-HE-Tag: 1712344814-253196 X-HE-Meta: U2FsdGVkX19QRyekR+fBq/pcxny0H4cfQY6aUIftJGClnSTkxuWhewYmGYEaLiGibmAcwTs9pVKYuhjKaaBBkrF0V1UpyuxH1o4vnMn1cM7O3nQh3KFWmRu/nOP83km0t/RXh9ZJqqfImRXoUpwyn0vA7GJgfV62+g8E3Jl2fxSZexoLdliiI6yJwhct9JC9PDHlOXaNGZ6SKNiKsgXjMVG8D2AfP6F9QSc0L5/L7jJY96FefonF+IdH/MF1ogj65zaOGbTF41GC0vd5gV1LVjwnpCZDNGucbdUPf1fCqF4jyZXsW9Y/WcCthIiOKehZhyYS9h+hivCUoAkf04QlwnQzUA5YDJgBCzF7daox8zRatOsW75GneluYpi3wC5hoj9iQcivF84Ii74keI1tQHo20dxjTwMxSID9QE4t/edhAadQe7eYd4Ob6L4vhyEquTRXO+Kdp14AkPaAGxWv2QwLJu8dx6SuPwY0WMnqfxdAxQrDvBvEPEIDAE8sU60Cle+gDQe1p+yf6TSzWMtaXDR89tcTp/ru0j78VkjcuB565EPMhwnmGfv+5X/cGi6d/C6ReTxMrwNs33w5OgZHoW19FHQ8+1g70DSWrdY5C0THRMd/8s2AkxEmNsFQ42Ln/PhRmH6jRjagNrnfznag/QXNCFrQOThncm/VFvEh2f8PSnz66KDsWBZMAKzJrQ7KiXey+Ojh4R3ofnYdXKtu7pbcFJMPP+zD2Dpl4r0TZN70zh4olKO8zp7aeiSCUTWQePeYdjlBE2qHMs7314noQ7koRi9ZXOlE3dez58jKnk7Qaf3xPmsm2RKRhbJ5ETnA+sR6O9UvUAerwCzNSVQ8ysv/C4JGp6Nz+8dQ7+LWzEMcV7cjAGe2IXAH0NSTLcqMYFEi6OSOE5VwYLphS0FAiaeRP3+3XnvM9qFAX2BDG3vfbL9G1raG+30FRtjkBXAC0UpoiD6goueayO7CVuDs VzUfTxPP TFYgh8z3QBNVwh7DXaAed6WtXYJO0vBj2VvBug3/L6+xtiotffDFcD/7zXsDU4gNZOGYWvhdfm5cZawuQBAbbaEEAf2vyXLHSpr2LGf+r6BJQOBUH9cUkq2t7ekwClamn28ZWQNqo92vn/3Chqi2dUKK4rwBncEM3up/OEyqwpBVl/2loWcIPmPJQuIJqaNFWrqcoTRe8egRo/SZ0HbixlolUehJIhpIiJ9afpliAjB0ncXnIv7CMbPhSKVYhgEfFqmcmb/F9U3wwq2/lMNHVhAUkBEBZde72i7nl6VI0S6aOiRHryqt5xWF5ng66RwrGTaDglCT6kcQrkt4JBMmvckcJ+kPTT4vnVaOSOCA5v2RMhlVaQN5k6xmnq0zjeIvyezy16LXVmNcYioP02LHt6/emQk0OSEV3T/0go4RJjgfhjFI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 5 Apr 2024 15:08:51 +0900 Honggyu Kim wrote: > The alloc_demote_folio can be used out of vmscan.c so it'd be better to > remove static keyword from it. > > This function can also be used for both demotion and promotion so it'd > be better to rename it from alloc_demote_folio to alloc_migrate_folio. I'm not sure if renaming is really needed, but has no strong opinion. > > Signed-off-by: Honggyu Kim I have one more trivial comment below, but finds no blocker for me. Reviewed-by: SeongJae Park > --- > mm/internal.h | 1 + > mm/vmscan.c | 10 +++++++--- > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index f309a010d50f..c96ff9bc82d0 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -866,6 +866,7 @@ extern unsigned long __must_check vm_mmap_pgoff(struct file *, unsigned long, > unsigned long, unsigned long); > > extern void set_pageblock_order(void); > +struct folio *alloc_migrate_folio(struct folio *src, unsigned long private); > unsigned long reclaim_pages(struct list_head *folio_list); > unsigned int reclaim_clean_pages_from_list(struct zone *zone, > struct list_head *folio_list); > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 4255619a1a31..9e456cac03b4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -910,8 +910,7 @@ static void folio_check_dirty_writeback(struct folio *folio, > mapping->a_ops->is_dirty_writeback(folio, dirty, writeback); > } > > -static struct folio *alloc_demote_folio(struct folio *src, > - unsigned long private) > +struct folio *alloc_migrate_folio(struct folio *src, unsigned long private) > { > struct folio *dst; > nodemask_t *allowed_mask; > @@ -935,6 +934,11 @@ static struct folio *alloc_demote_folio(struct folio *src, > if (dst) > return dst; > > + /* > + * Allocation failed from the target node so try to allocate from > + * fallback nodes based on allowed_mask. > + * See fallback_alloc() at mm/slab.c. > + */ I think this might better to be a separate cleanup patch, but given its small size, I have no strong opinion. > mtc->gfp_mask &= ~__GFP_THISNODE; > mtc->nmask = allowed_mask; > > @@ -973,7 +977,7 @@ static unsigned int demote_folio_list(struct list_head *demote_folios, > node_get_allowed_targets(pgdat, &allowed_mask); > > /* Demotion ignores all cpuset and mempolicy settings */ > - migrate_pages(demote_folios, alloc_demote_folio, NULL, > + migrate_pages(demote_folios, alloc_migrate_folio, NULL, > (unsigned long)&mtc, MIGRATE_ASYNC, MR_DEMOTION, > &nr_succeeded); > > -- > 2.34.1 Thanks, SJ