linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Eric Biederman <ebiederm@xmission.com>,
	Kees Cook <keescook@chromium.org>, Shuah Khan <shuah@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: kernel@collabora.com
Subject: [PATCH 1/2] selftests: Replace "Bail out" with "Error"
Date: Fri,  5 Apr 2024 18:17:47 +0500	[thread overview]
Message-ID: <20240405131748.1582646-2-usama.anjum@collabora.com> (raw)
In-Reply-To: <20240405131748.1582646-1-usama.anjum@collabora.com>

"Bail out! " is not descriptive. It rather should be: "Failed: " and
then that added prefix doesn't need to be added everywhere. Usually in
the logs, we are searching for "Failed" or "Error" instead of "Bail
out".

Suggested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/kselftest.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 2cd93d220f434..9d1d8c5a73ab2 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -362,7 +362,7 @@ static inline __printf(1, 2) int ksft_exit_fail_msg(const char *msg, ...)
 	va_list args;
 
 	va_start(args, msg);
-	printf("Bail out! ");
+	printf("Error: ");
 	errno = saved_errno;
 	vprintf(msg, args);
 	va_end(args);
-- 
2.39.2



  reply	other threads:[~2024-04-05 13:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 13:17 [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Muhammad Usama Anjum
2024-04-05 13:17 ` Muhammad Usama Anjum [this message]
2024-04-05 15:32   ` [PATCH 1/2] selftests: Replace "Bail out" with "Error" Kees Cook
2024-04-05 13:17 ` [PATCH 2/2] selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages Muhammad Usama Anjum
2024-04-05 15:32   ` Kees Cook
2024-04-05 14:56 ` [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Shuah Khan
2024-04-05 15:32   ` Kees Cook
2024-04-05 18:50     ` Shuah Khan
2024-04-05 19:36   ` Bird, Tim
2024-04-05 20:38     ` Muhammad Usama Anjum
2024-04-05 21:07       ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405131748.1582646-2-usama.anjum@collabora.com \
    --to=usama.anjum@collabora.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=keescook@chromium.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox