From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0493EC67861 for ; Fri, 5 Apr 2024 10:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E3A16B014A; Fri, 5 Apr 2024 06:27:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8942A6B014B; Fri, 5 Apr 2024 06:27:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75B896B014C; Fri, 5 Apr 2024 06:27:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 558206B014A for ; Fri, 5 Apr 2024 06:27:33 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2159B1C146D for ; Fri, 5 Apr 2024 10:27:33 +0000 (UTC) X-FDA: 81975101586.27.7071502 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 42B7C140015 for ; Fri, 5 Apr 2024 10:27:31 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C0hwgWCP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712312851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4ZWljBCC9KrF5CNn3q7EM6c1BT8pMAntpGQOmXRtUQU=; b=Xzy1GhElZJ1DMQt490xX8CDuoCSHL/fy8vObT7E80POW0S3jEoJPiJrAqtqxjzbAAWX5qi 0J5LEehhbMHKQLIUvTQlbZVJiCrJrYBTZWMy3iCOwL+19ehCwuwvgc1Lt61oA6wqb/6KOd h3EXg6QpHm01xYzZadbU/1aPaKl/qDE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C0hwgWCP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712312851; a=rsa-sha256; cv=none; b=RkPu6Mb6pLmQ+U5N7MdaUJQcYFWfPiTxF3jbpbULBV6sxJ/CamL6Ml3MP+3U7wTssikTLS ZWk6R6U0F9KaOWVKH9dsxvRsPgT9kd/ASxz8/zVD3wt3gl7n5Pqm94ZleZSqkZbEdMsuEC 7BjXArdbadskR+fQIe3THsI/Obejn9Q= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ecfeefe94cso358134b3a.0 for ; Fri, 05 Apr 2024 03:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712312850; x=1712917650; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ZWljBCC9KrF5CNn3q7EM6c1BT8pMAntpGQOmXRtUQU=; b=C0hwgWCP85xS4sSIE8DFEk/8gmpsfCTrcTNAobefoRtPLgNyRxZgRLiZpS3r7i0gMx UEAsVBApNNMkKk8sbaci38mOB6ytqfCkK9s0Lmt518muiNN7JikBlm1YU8t2h0Vk9bjV pXrnwd7xNqFNqFHVTrxJtg05eL+YCQOltvgv2TlhY+pMQMZKLl9lVcBn6/z4y4oAepFS rq3Fx7HjU9pjLgPSneOk/suO2UxJdVKey67UyIsEZWwzkIDHpNHck4ThlIS4F853VB3p pu/ZB/6WeS3I51ObByBV14FktXVcjlBbgBLyVvnLcuzMWC8uf6KGrKCvuBVZ/WUVwucq 5erw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712312850; x=1712917650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ZWljBCC9KrF5CNn3q7EM6c1BT8pMAntpGQOmXRtUQU=; b=LZFnfkIAkEYlf7YpWUVSitKVXAqbkQ3eZXeBeevNAYG4//cG5go+QSwGm68Im6uD3O k6VyJ6Dmm2sYPoWc6aZno/aqf3Jn/MVOAAfRga3G8L1wJd8qqj0YvqMqQGQJMfKiOxUd eyERD5gr4BHvtTr6AYkut6pkMFoLWBFf12sr9ocRDHr1a304olR980v2e4+ciamW/MCS dxr4QUGp48mO8hl8OEnRrbW7DTbCxrSnInXsamrRxJnrfTC3Q7VhyTn+hRGbnv1eA4Bt UEz8pO/qksgd7QB1dQKlZyHYlcsjdVJJUbF/KfCfa8g3/N5sSJjANjV2Hgmk7CP9Uwvl tOQA== X-Forwarded-Encrypted: i=1; AJvYcCXs2mptotpuqe3Q3eNi9ue7TOBaDvUaWir2Pu60iHwcriMsp4N5DjRuKshYzTXgIuJS+KJAEIEL8OfaH1m5Et61RfQ= X-Gm-Message-State: AOJu0YzwjQ/ys5AHZfqkqjshiY8Pkw8miiR74HI5b+m+HKK49dxHvCBG B5WcdyP4XhQskUCoq5i/6pwbxHiO55eOwNRAredp11FNavacOXMf X-Google-Smtp-Source: AGHT+IGtMKiEbIdv0FWwPdoZQEr/By0dCwSDG7UHQlGksBrCqvl3FEssVeROn/+hGtNQ6NcBdk65wA== X-Received: by 2002:a05:6a21:a5a9:b0:1a7:2451:aeac with SMTP id gd41-20020a056a21a5a900b001a72451aeacmr1784226pzc.16.1712312850194; Fri, 05 Apr 2024 03:27:30 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id f20-20020a056a00229400b006ed06aa3604sm113334pfe.82.2024.04.05.03.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 03:27:29 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: david@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, ryan.roberts@arm.com Cc: cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, peterx@redhat.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/2] mm: add per-order mTHP anon_alloc and anon_alloc_fallback counters Date: Fri, 5 Apr 2024 23:27:03 +1300 Message-Id: <20240405102704.77559-2-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405102704.77559-1-21cnbao@gmail.com> References: <20240405102704.77559-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 42B7C140015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zwgaiiinpcpqk67fa4h8oo85etj85dmx X-HE-Tag: 1712312851-129602 X-HE-Meta: U2FsdGVkX1/0ePHxkyJ/FfTB/SrhZccj0xr41LvQt5D2YvvkavH1giHFGuP3lU2TcLRIFneAdivzTi5uKHj1VXY++cBqmhGvIfjWcPozk9Ir+ynEHcTAZIsmxTq4pVMflMg0PEjq+8ZtroC+ronZrHMuON0Tz191vPFDNfnSYB4sc/iKlxJdqsN0p4hcjP4SlXZYwAaIQ/lYrrREdXDbglAq6XzKzOTUXlMeLjSKfqr8F3Hmub2RTq86zMR/w6bYdRDDvdk/KuARievu2CW8jDGp4UKSbQ733Wtv7vsJCBsYEG6MH39tNjESycBGNp80Y/wvJBQhea4uV78Hx4JsyH9K9quS0xJhOhVmQ+41vnLsJ4h4+fI2uuAs+rqdKSSrL7jeGwE+y7qTv+aJKKgW2QkuVCerWrZvb7YvM2SPg9XTjGscizG24LrEKN7xMkE94TAzkDh1ESJGwPdKDNzwfvz661XkOeQSy3Bs1nY1AXklX9Mzcj5ZOMFwTe0PNiNytPfVwVRPt535nF7H1GizeiCo+mphAsH0ONiEWfzeRFI03C8U4jYRTmgYohNOd0h2TKa8CS2YyFIojG9JQ/fB6vLfqseRSFqOEfW8oWgByUf9tF7xnZQjed1uisOFQVPCqOWbWbivCd7d0JaA+j+uKFMgVCInTwPzn0T1sfQbtrCg6gXRZyCcA/YkFsGtDKsyoQhvxY75JKDG2BisHBHJtqtrqHsSDQhl0bvcba2zKM3nMbGfB4JhTJGZD0N4sxPaOp5S8mZprNR7xOTC6oJ8xLEckDpKFl3/XKtU8Ktzwoie8Imco+rYCJkI7odCQe0hY5AWpvhjOkOyOxgEvrlY0n/QHDzjv7VrGEfyvTZ7DmVWcrtIjLEVJnB6MhzGTEJ66T0MirJZW5m+FQ4JYcaUNZJWh6DmSRHm8DeRurAepTCUcudac9jTtD6nGaDePonAndl0NesnP1gs7RooRFd 863bnF4H 5yAdWt/DNbwYgMOBr58ENAhoCoLy7d7yJdkpmwXpxd9PmzfLW2vbcjtTUAl7zakoraSy4fi3VfmP/NRtIBDrqs6PiipCDIvWZTR7OhPATjTOKouv5s/vl6TpPPWFbFc5VfwQXkTNB8asE4dddG009vfYjraP9L6/MTte8J+jbPhp03gHf65ADnaBRbo0kGxZtiiKm2qELieZnobQ+8RhGzIKwYj8nqxpiweerL+v6RN96Vju0ZWRWE3pEMAJmXYpvw7E3RMGR5N1C2Y4ReOwDuuqTpgnmkA6LJXLFo3kcizEEPwJ705c1ZyRnr9RUQ+82HsLm8CfGIvDoMD5ca3Ed7f1xd2R6Yxs2c3+LKqyHhXYv5r6H3vEI2rDdO9EQydJr5DLrvRLwC23iGAebLu0ADpaYkwzV5c4pjwqX6Mz/kyyRMpG317HGRf4jfv5mwQjnFo6g0z3TKwxRxJHMDndZ0/P3yc+bMQjxWtFePs2d9dK5REbDBmaRzJU91feXalhDSiBOUz7lgToFovcKoMXXq7AcDqrDAi4O6OPZWNVtKRKsFmdYJ8bn5rWbAgjrZrHLhqaz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Barry Song Profiling a system blindly with mTHP has become challenging due to the lack of visibility into its operations. Presenting the success rate of mTHP allocations appears to be pressing need. Recently, I've been experiencing significant difficulty debugging performance improvements and regressions without these figures. It's crucial for us to understand the true effectiveness of mTHP in real-world scenarios, especially in systems with fragmented memory. This patch sets up the framework for per-order mTHP counters, starting with the introduction of anon_alloc and anon_alloc_fallback counters. Incorporating additional counters should now be straightforward as well. Signed-off-by: Barry Song --- include/linux/huge_mm.h | 19 ++++++++++++++++ mm/huge_memory.c | 48 +++++++++++++++++++++++++++++++++++++++++ mm/memory.c | 2 ++ 3 files changed, 69 insertions(+) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index e896ca4760f6..c5d33017a4dd 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -264,6 +264,25 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, enforce_sysfs, orders); } +enum mthp_stat_item { + MTHP_STAT_ANON_ALLOC, + MTHP_STAT_ANON_ALLOC_FALLBACK, + __MTHP_STAT_COUNT +}; + +struct mthp_stat { + unsigned long stats[PMD_ORDER + 1][__MTHP_STAT_COUNT]; +}; + +DECLARE_PER_CPU(struct mthp_stat, mthp_stats); + +static inline void count_mthp_stat(int order, enum mthp_stat_item item) +{ + if (unlikely(order > PMD_ORDER)) + return; + this_cpu_inc(mthp_stats.stats[order][item]); +} + #define transparent_hugepage_use_zero_page() \ (transparent_hugepage_flags & \ (1<stats[order][item]; + } + + return sum; +} + +#define DEFINE_MTHP_STAT_ATTR(_name, _index) \ +static ssize_t _name##_show(struct kobject *kobj, \ + struct kobj_attribute *attr, char *buf) \ +{ \ + int order = to_thpsize(kobj)->order; \ + \ + return sysfs_emit(buf, "%lu\n", sum_mthp_stat(order, _index)); \ +} \ +static struct kobj_attribute _name##_attr = __ATTR_RO(_name) + +DEFINE_MTHP_STAT_ATTR(anon_alloc, MTHP_STAT_ANON_ALLOC); +DEFINE_MTHP_STAT_ATTR(anon_alloc_fallback, MTHP_STAT_ANON_ALLOC_FALLBACK); + +static struct attribute *stats_attrs[] = { + &anon_alloc_attr.attr, + &anon_alloc_fallback_attr.attr, + NULL, +}; + +static struct attribute_group stats_attr_group = { + .name = "stats", + .attrs = stats_attrs, +}; + static struct thpsize *thpsize_create(int order, struct kobject *parent) { unsigned long size = (PAGE_SIZE << order) / SZ_1K; @@ -549,6 +589,12 @@ static struct thpsize *thpsize_create(int order, struct kobject *parent) return ERR_PTR(ret); } + ret = sysfs_create_group(&thpsize->kobj, &stats_attr_group); + if (ret) { + kobject_put(&thpsize->kobj); + return ERR_PTR(ret); + } + thpsize->order = order; return thpsize; } @@ -1050,8 +1096,10 @@ vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf) folio = vma_alloc_folio(gfp, HPAGE_PMD_ORDER, vma, haddr, true); if (unlikely(!folio)) { count_vm_event(THP_FAULT_FALLBACK); + count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_ALLOC_FALLBACK); return VM_FAULT_FALLBACK; } + count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_ALLOC); return __do_huge_pmd_anonymous_page(vmf, &folio->page, gfp); } diff --git a/mm/memory.c b/mm/memory.c index 649e3ed94487..1723c8ddf9cb 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4374,8 +4374,10 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) } folio_throttle_swaprate(folio, gfp); clear_huge_page(&folio->page, vmf->address, 1 << order); + count_mthp_stat(order, MTHP_STAT_ANON_ALLOC); return folio; } + count_mthp_stat(order, MTHP_STAT_ANON_ALLOC_FALLBACK); next: order = next_order(&orders, order); } -- 2.34.1