From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F389DCD11C2 for ; Fri, 5 Apr 2024 15:32:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86EEA6B007B; Fri, 5 Apr 2024 11:32:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F7D96B009A; Fri, 5 Apr 2024 11:32:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6722B6B009C; Fri, 5 Apr 2024 11:32:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 394296B007B for ; Fri, 5 Apr 2024 11:32:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E23A3A1943 for ; Fri, 5 Apr 2024 15:32:48 +0000 (UTC) X-FDA: 81975870816.28.2E336F1 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf07.hostedemail.com (Postfix) with ESMTP id EFD394003B for ; Fri, 5 Apr 2024 15:32:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Id4/cMCj"; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.166.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712331163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5HBupVq8sRNQ0/e+zQ08oh46OVYn1TgMtv+BrDWwTbo=; b=dFG9I/ZCLtxaZ+ePolDL6LOxvOLZJl01+UOS04ABJJaueYVHhL8hd9JvSxB44gApx7P1xb JhTfuGZS7kt8gYE7z1kuiJzRxCi9I0m3oJeuxXhu77s+mUB0jbKRk3INnMcOi/q62vXLm/ 7FRAfZsddi6EEYLbmHISGj3BnHcvW9M= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Id4/cMCj"; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.166.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712331163; a=rsa-sha256; cv=none; b=k612fTB1MFNKk9lbnDshCT6g51l7o7PRESp+lEgWRVtdIwdH9hH89GSJo5jgOgQKIjcrBp FD84I99luvdB7MwAOaTm557/PHyfnblQ66P+/J/TG1GiDi8BKrQeFlG4h05t/qvQPRe4Wo QqYH5QdWkFzEfCWpK5eIy2RSIbRLsdI= Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-369ec1fbadfso9704175ab.2 for ; Fri, 05 Apr 2024 08:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712331162; x=1712935962; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5HBupVq8sRNQ0/e+zQ08oh46OVYn1TgMtv+BrDWwTbo=; b=Id4/cMCjxQgwskuDuj6bnyWNiucFLOvimI1iQ71F6rpARvFGODyMtkmTphUa9e+h7F Hctjj5DMPTWYiaZhMrc/j6oD+UhtrT5TU5IYqAY7aBq9H8ZGkFF2RwRSoSg/ks1MHSZX kpqxIm2p7OJ1B1LiyB9ZW294xJ7BrpH2MaiFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712331162; x=1712935962; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5HBupVq8sRNQ0/e+zQ08oh46OVYn1TgMtv+BrDWwTbo=; b=KlOCV2uBMnSDo3fIODYc4JlkUUGbuqst9X0wI8HgucJz+cc76+wdSQg9HhC3mHtybL jfyKtVfTnznLZKZxagADPfKARbld34RL+HKmnQsHa2h7Cf6fZk4j+7MIerqCQfnOqUvm HATBv630hZW0n/cLiBZF72xwTrO5Rr+j6e1V70O1t/9Absol53+RkY653C/ZLMz1UNL+ Y6f6kDWtS+ZGER6wEmVR5aCY4T8SO+RjTihrubiAUYig3XY20dUPcqVb9Wje70wa6dEh q4F0iga6+z1GvPgR+OxQIm2TvpnZFysdS1K7ugtOUhk3qP7FhIsvem8HLpSQuDLt7kMD PHEg== X-Forwarded-Encrypted: i=1; AJvYcCWrDgzmw2ubCmRnneVYITD6nEybXwSG5aazP1Iko4N09OG2xDhIZS54rTAf2QkYfBG9ZzoVJRXz0X8Y8/7KxM6dhUk= X-Gm-Message-State: AOJu0YzvUPsQJs2v+9lwsD4wMUDUYvmSyDgmMdMGX9cl0W+oaDAQCbBf imVwgWw0TLf1me2RzTbrEotKS4VB5/+ICwJwslQfPffjpKTJSPxHcfj0gYXAJA== X-Google-Smtp-Source: AGHT+IFAyS5NJbvUgCystqIUFG6PUixCvpV/gat4hk1z7KjiiUWgsTIr7EJgMOjn894eip4sM3zwUw== X-Received: by 2002:a05:6e02:1d0e:b0:366:89b9:565c with SMTP id i14-20020a056e021d0e00b0036689b9565cmr2174618ila.15.1712331154523; Fri, 05 Apr 2024 08:32:34 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id h5-20020a631205000000b005cf450e91d2sm1274954pgl.52.2024.04.05.08.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 08:32:33 -0700 (PDT) Date: Fri, 5 Apr 2024 08:32:33 -0700 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 1/2] selftests: Replace "Bail out" with "Error" Message-ID: <202404050832.35AE5A95@keescook> References: <20240405131748.1582646-1-usama.anjum@collabora.com> <20240405131748.1582646-2-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405131748.1582646-2-usama.anjum@collabora.com> X-Rspamd-Queue-Id: EFD394003B X-Rspam-User: X-Stat-Signature: n9znhi1zkfdrzbefq1o5k9f395qfpcoq X-Rspamd-Server: rspam01 X-HE-Tag: 1712331162-504886 X-HE-Meta: U2FsdGVkX18SGFxhbnIXhV23dVifofbpu47F6KsHHjpn/QRHLaTpkvSdIr90exDrkYSG3kLNOBqltsOIlP2npc2/mw5oO2p7Q4Z3JXryplvvGMnVS46447AAlI8H+RLzaw5Qvao4Hpt9G8L9lBIlgD2AAgdg/W/QhVbdATsq3d912FSL7A85/gi4tF6hJIWOluOJQeD25lVeDhgK6jLEIm4kZ8ncbyeCntHERigW5an398Rdk1AZWOz0sgC2Qj0Mn0vcQp6lMTgGhRJiTm8A4tftylqE/2v+J5/2ZSrhP3qEy5eDusAhlCOZLmz/m4dEBpO2Mbq8qv6aUyXafUPf2cjfqfbx8fbXbORPDUmnj8JWbE0aoNkvy4lQy1Wrl32griWmIqNEM0Yij6lZN2CZ3kZS3D7E3OBMTAz8wshDKWHfeABEYAGxqCS+tf33KazVNWgKw100h35HawyWZljMjn63iDkwR1ZF+4KAV//3D+jtdL7iC2aH6pLy0AlQ7Gp8uy3RFtK/c7OQWgg8tuPQwiJZ9i1VhzxBx9YNCNxpbXc0ujaRIBdNb97V6uHSHjqh/j26AAXima4YYdJtQx+v2DIIfXlZWKHHI4vAPt8MgNXJJg/577yrpwxLzMia2JkFMmCNirQs489s3f8cqZ7Bt3wqExDCq/OR50877A3QRgxf3JHpt/1rBDMWWC1EWyecFGoS2vVpdKh9dTG+5oGBkLwTVAVJ02IHi6xXCrPqu9FJtke972GrTMVDHE00XtMsaY2k9pQuSUFCMmxjdnc+o6Z0fEU1zr2d3p8sETJob72NFx2EhTdcOB/iJvVfFc7GuDuA+3t5wZjnrlKO8FT0kqUDNmrZU9QbUKDcQLZAnWNHfjSSH2hvnzxZN3Q40zRv0MmMd6yKLrtx0S/ikRrQSD/UBbt/RbY24zkPCyf8WZPGmrbE7pOm4KGJtIXGipUh8tNDONOGJLajKtWK6i9 ttr5vnwP H9u4golYJBFVOPUerONuI+TsDRy+41NymgP3r9n80nORH7/TtX5AiNZO/a14dUiVW65xEdA/YBk8EF32R3aTCLzFKg+6isNTmxG51U0bV3v8aG8yr7NhRqQr8xxBaKiP8TJTxrGFIZ0lQ1Xk0gZ6GHe931bL9eRcLoPq9fG4L/dAj4ZCAx3zip51Z5jur2f6oIkLtuazuGKdaIhBFsa2BA8l/aGj4E6imUT3fT160mEOz7FnjzPAZnyrAJXaA+mkYKbstmsCP5zj14gh1Rq8oAl7eEtz+1px6MKf8I7+XyJToZApGnZi5t4ijmedWBAfhZC3xp/DH6p9Qgssg16ngZV3NnQynJ04NINPPZfuvF85xZ8O/gRtnUMe49scDzEgdvuMmB05V7uWkiGO2A1Dr546kWWGKaZkhKJhi3InnahMG611CgCfm+3Xow2WMnusFwiceu4tCRarl4HgIU+GppGNgww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.050381, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 06:17:47PM +0500, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then that added prefix doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed" or "Error" instead of "Bail > out". > > Suggested-by: Kees Cook > Signed-off-by: Muhammad Usama Anjum Reviewed-by: Kees Cook -- Kees Cook