From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7658CCD1284 for ; Fri, 5 Apr 2024 15:32:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D78386B0093; Fri, 5 Apr 2024 11:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0B3E6B0095; Fri, 5 Apr 2024 11:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2C8F6B0096; Fri, 5 Apr 2024 11:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 946486B0093 for ; Fri, 5 Apr 2024 11:32:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 57CE3411D0 for ; Fri, 5 Apr 2024 15:32:28 +0000 (UTC) X-FDA: 81975869976.14.7C15642 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf28.hostedemail.com (Postfix) with ESMTP id E66E0C000C for ; Fri, 5 Apr 2024 15:32:24 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="JjAf/kQv"; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712331145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3zCHuG1riB67zTF6cGFfKkOo6cTBnZXN81xTdOBpCWY=; b=m81MAZnMWZ5E0RscMApRN/egMUpfUxjdxitcnlkGmcBh0xw6j30oAgyyIGdf7JZZE9KsCj GorE0LuoOORsdty+VDJ22R+/USovhdjfTuUo2JW0VufzLMVc8XPJAvUlLC4H0YUHfVaYm7 0Olxrcki8D6oklhy5QZUTZxH7GM73j8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712331145; a=rsa-sha256; cv=none; b=IGk2VFGHlnlABX81tVR4qtdGY7coDWDckzOyd7Sb8mT1UkdQXfg/7OiDfv2MvoORoe4Fti d6XeZY/cSOz5fC/57PGJyes0jzpy/YhqRP5JEhDarecYQarAva++WqWQK4+nIxI6kh5N57 dLKdVibFdO+7eVhTtR11474mKdx5US4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="JjAf/kQv"; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1e2a2d5f0b7so17077245ad.1 for ; Fri, 05 Apr 2024 08:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712331143; x=1712935943; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3zCHuG1riB67zTF6cGFfKkOo6cTBnZXN81xTdOBpCWY=; b=JjAf/kQv6KTxUESyhZyJ21QkO88jLNnC0IvU3bwuVW1SYN5T4nrUeSu44jmHBn61Dt Zuqa/bMjxC44a569m2IRCyjH//f33Ojh9SyngpghwZ8+upMrQfuP5Y++80aVC1gDSQ8f XrxTGUCLSaIiFLceCsUR3OEAJCtjQsmeDCTkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712331143; x=1712935943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3zCHuG1riB67zTF6cGFfKkOo6cTBnZXN81xTdOBpCWY=; b=VA/o22puJagIpSwPELL5pNdoqcEijb2m2sIQF/atLnjdSYcXBWAcvEoXuVrKlV5MAU e2taf5rd0XYPvHXcWQnncNUUVEBc368zRwvtbpNi7HzSBzWHOCrYu4257A/9JqUk7NaG erCjqQNygOdzvOBy+STdObWeZZ8ArS4pVeUY27DAUL2u/2el0kTEQbW5TS6VPUA3SpC8 ZSmfZOqujNmuMQv1BkrFxbgCVOSo17KDamk7oBuA9B8m3KJ9IoH2+1su0VSFAr76OQ5/ Dsjphab556dZXnAUdzrV+jnTQuQwakk7ktKxdgIioTbTDcC+NvjacjAXYv6jmyF7zb7m o57g== X-Forwarded-Encrypted: i=1; AJvYcCWj63Sco/eOzo6dLpeQmeU8Qq1V1rQZBXStfk8FEecbxF8TuNNAuITjknXdndqb5F3+Oe3gGj3nIIj66yu9Dci0Wek= X-Gm-Message-State: AOJu0Ywz+eqhycuQzKEBz3ZbO4RYly3WlSBKxQf2KCs/KJo+CRvIJoZu sd0By1T43djrKBj/PHMHPvs0Ay0nW+UD9mVIGuLb+UoNwfN8JlbXEkASBR4uTA== X-Google-Smtp-Source: AGHT+IEcd30JQvThROXLk6blXSCc/d9PBNI1VHjF0rNb0/xAuRQY0RK64NghWzC/QEFJnHzUbp+dIw== X-Received: by 2002:a17:902:ed8f:b0:1e2:577:f694 with SMTP id e15-20020a170902ed8f00b001e20577f694mr1785714plj.61.1712331143586; Fri, 05 Apr 2024 08:32:23 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id j5-20020a170903024500b001e29c6d5084sm1698784plh.227.2024.04.05.08.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 08:32:23 -0700 (PDT) Date: Fri, 5 Apr 2024 08:32:22 -0700 From: Kees Cook To: Shuah Khan Cc: Muhammad Usama Anjum , Eric Biederman , Shuah Khan , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Message-ID: <202404050832.187F972C@keescook> References: <20240405131748.1582646-1-usama.anjum@collabora.com> <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> X-Rspamd-Queue-Id: E66E0C000C X-Rspam-User: X-Stat-Signature: qmg84brcdojssq69cjh6yoodom9h8ecf X-Rspamd-Server: rspam03 X-HE-Tag: 1712331144-926250 X-HE-Meta: U2FsdGVkX18N48yPMsnm4tg7Vc0Tf+BKcG3sW/14PHiyDQfCBkBLHuuYTKBfHsMTYfX2Zr9WXDInAt5SWSrcGVC72gtZI5sTfJuJ9qWMYD5H0fD2n/nsX6FXjr5tLyIXPK2xMwkzWW/f3P//nsn63RRktsP4OBw/WDeZm0fBlHh+sVz9PMUwpq7YjiHbeNsXBxIaEJx6/rDFTFEkHcEHhcqNPQcBk1jjGTiFznTyoPWdDmVNZ1/s1DsaemTTXlR/vFRyNykCuK2gKMZwERSI9vt/VI7PbeI0DO59rCoXQXeVDoNND/D3iAvDWsHzi5nsJjPxwmGORh7XUIgZFgqMp7+5ebttWc8Ol/XiGuKQFxmcIZj+wnd8fY5keZVo2OWRlLm+iB7mOqIdhhzZdN7zt/pyvJRUfbVEXF6dw2Z9yJw4FP8Dhr+xsH5JlxaTaD1RJm/cmhVnXEMb1L3T/eDXDHve2u+CMYrDsGJsvYEpN9XLb6hsK+E/QPMcEs3v/oo/6MieU1ZgURHVnbwv2rYfVskOr7QKw17dUAXhuG9hFLJm/Rx1KzWwU+reLs1U2175Ou6IaPOKZnXIaCVgbNFhTa+sNrzyB673bZNzhJR91Fez2kmun2+KotoQKMEpJMibQxAyOheJ2XzwoBWS/9CmjiNbNqUkIb4Y/HW1cFoY97oRPmWa+4C4Wc/eZabcCsdQb/zAZBZwceAILBVgviT1eAqCo4VamLDOb5/HecOTehzy+n7qcsXoV5vvdXEP1CN+l7JHFGetCBspCELWZIfuZ8Bsp8mDMjUbakAHk6HTBi2nVyXeDC2ZKGoDfR5CIUVkwpNIiVX5NPvR3o1C+7+PTeyXVsMoIxmVNi5hrUxPYmmQ5Y5memQMfcm6JEnGCmiA1OPZqCzL7jydK0wV5mgvgdFG/CiF9DVeIM+OoVW7zug9rfU9co6KhmJcqKktkLjoggZYjWrc49FlB/y7mjL 2PeXDdTm hR1jAIIyiGjZvLvaef53Sm22DZ9FwMWfTMEwEn0nmtvJLLQfdPvc/oeZgbzzV8Bt4a3hv8mequKQWnhbHAac0kjxfREsQOUE0FgOZgdtuspL5Fc/N+vLgCjf8sZDfEjXpQhjAXnq3q0xRVAlU6EH2dciKl3JP4BgrfDI8+FxBUPUj+Ci2YtVBLqS4t0Fb0YjFzprT1G6wxolelVq7WEprZVzAnWtCXJXPDQcO1vABzbphLxsPDrpsJ6dRtko4FyfxTFJCfXjbst/RGlH/ZGyJpwScy0i1Rx5uNb4CtCX+G5pwX+X90bs+Hcp/YXIEIugXpGcaHmmkwf332oNWmsRsuSCpbIkOnGyNKv015oRENoAge5A6h0jxzw85Q5gZCJXoliPWZlTPpXJmelbaL1p275cFjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.035883, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 08:56:31AM -0600, Shuah Khan wrote: > On 4/5/24 07:17, Muhammad Usama Anjum wrote: > > "Bail out! " is not descriptive. It rather should be: "Failed: " and > > then this added prefix doesn't need to be added everywhere. Usually in > > the logs, we are searching for "Failed" or "Error" instead of "Bail > > out" so it must be replace. > > > > Remove Error/Failed prefixes from all usages as well. > > > > Muhammad Usama Anjum (2): > > selftests: Replace "Bail out" with "Error" > > selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages > > > > tools/testing/selftests/exec/load_address.c | 8 +- > > .../testing/selftests/exec/recursion-depth.c | 10 +- > > tools/testing/selftests/kselftest.h | 2 +- > > .../selftests/mm/map_fixed_noreplace.c | 24 +-- > > tools/testing/selftests/mm/map_populate.c | 2 +- > > tools/testing/selftests/mm/mremap_dontunmap.c | 2 +- > > tools/testing/selftests/mm/pagemap_ioctl.c | 166 +++++++++--------- > > .../selftests/mm/split_huge_page_test.c | 2 +- > > 8 files changed, 108 insertions(+), 108 deletions(-) > > > > Andrew, Kees, > > I will apply these to linux-kselftest next as a series since these > changes depend on change to tools/testing/selftests/kselftest.h > and need to go together. > > Are you okay with that? Sounds good! -- Kees Cook