From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B4ACD1284 for ; Fri, 5 Apr 2024 06:09:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6A376B00F4; Fri, 5 Apr 2024 02:09:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF14C6B00F5; Fri, 5 Apr 2024 02:09:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C44BD6B00F6; Fri, 5 Apr 2024 02:09:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A846A6B00F4 for ; Fri, 5 Apr 2024 02:09:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 729481605B6 for ; Fri, 5 Apr 2024 06:09:17 +0000 (UTC) X-FDA: 81974450754.01.276D6AF Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf28.hostedemail.com (Postfix) with ESMTP id 5C4FEC0007 for ; Fri, 5 Apr 2024 06:09:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712297355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjpUlKwELBdpP06tAlYM7enX6svsxkACaqZOzMm1f0M=; b=OZIXmDbTKRKMkxnett4w3ZIutG1AJdMzRphOGG1LseoDC2hnbrL0eG1836ejkJYWD9ER6e sv4WeP9FV75QT5cAjgv5Lp/mCibcYXUs9TyXXTJ6JHWgpo2WQaefdDgjstJU0BjSHaXsC1 k3ItrvyxCv1xh+yU9JYwhzYMqZ/qo68= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712297355; a=rsa-sha256; cv=none; b=KjvBp2+q4yk6AjXCDmIvOz8S3UwUwMb66wjrTBN7lyavYBDnPi3x2l5Yms0c80xkUj6pZy 2lsweyDzrbQE2H+awz7Iily/T91PPiBjNTZsky/KPnuOw1BzosDjhcfgRrsDLt3//HFoGK CM6PAJk3yNLDw7bxr4KH3D7Z6qv8C9M= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none X-AuditID: a67dfc5b-d6dff70000001748-ce-660f958600fc From: Honggyu Kim To: sj@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org Cc: akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, honggyu.kim@sk.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: [RFC PATCH v3 6/7] mm/damon/paddr: introduce DAMOS_MIGRATE_HOT action for promotion Date: Fri, 5 Apr 2024 15:08:55 +0900 Message-ID: <20240405060858.2818-7-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240405060858.2818-1-honggyu.kim@sk.com> References: <20240405060858.2818-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsXC9ZZnkW7bVP40g9Mt8hYTewws5qxfw2ax 60aIxf0Hr9kt/u89xmjx5P9vVosTNxvZLDq/L2WxuLxrDpvFvTX/WS2OrD/LYrH57Blmi8XL 1Sz2dTxgsjj89Q2TxeRLC9gsXkw5w2hxctZkFovZR++xOwh7LD39hs1jQxOQ2DnrLrtHy75b 7B4LNpV6tBx5y+qxeM9LJo9NqzrZPDZ9msTucWLGbxaPnQ8tPV5snsno0dv8js3j8ya5AL4o LpuU1JzMstQifbsEroyNM8+xFLxTqph67Cd7A+M0mS5GDg4JAROJ26v9uxg5wcyli64ygdhs AmoSV15OYgIpERFwkFj1VaGLkYuDWeA/s8Tl3l+sIDXCAjESH2aeB7NZBFQlfjxbzAJi8wqY SRw9PpMJYqamxOPtP9lBbE4Bc4l5jzeA2UJANZ8OHmOHqBeUODnzCVgvs4C8RPPW2cwgyyQE jrFLrOjdyAYxSFLi4IobLBMY+Wch6ZmFpGcBI9MqRqHMvLLcxMwcE72MyrzMCr3k/NxNjMCo W1b7J3oH46cLwYcYBTgYlXh4PebypQmxJpYVV+YeYpTgYFYS4e124E0T4k1JrKxKLcqPLyrN SS0+xCjNwaIkzmv0rTxFSCA9sSQ1OzW1ILUIJsvEwSnVwLjet/qB7OnPBmzmEtdW13gl7fzQ fE8npWbXjF1p/bUfO7U8bPxSv3r8iWBgl+bfYtiRfthSR/BMzsLy9y9ZH/1oEVYM8bqpde9h oNTii+dV0nu2hpq9ivT4c/XS+lVx92TvmdWafWDdyfD727TJrsks92M9GZdaPOrXedf19mK4 HN+XfdPcdiixFGckGmoxFxUnAgAvypFstgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsXCNUNLT7dtKn+aQd9CQYuJPQYWc9avYbPY dSPE4v6D1+wW//ceY7R48v83q8WJm41sFp+fvWa26HzyndHi8NyTrBad35eyWFzeNYfN4t6a /6wWR9afZbHYfPYMs8Xi5WoWh649Z7XY1/GAyeLw1zdMFpMvLWCzeDHlDKPFyVmTWSxmH73H 7iDusfT0GzaPDU1AYuesu+weLftusXss2FTq0XLkLavH4j0vmTw2repk89j0aRK7x4kZv1k8 dj609HixeSajR2/zOzaPb7c9PBa/+MDk8XmTXIBAFJdNSmpOZllqkb5dAlfGxpnnWAreKVVM PfaTvYFxmkwXIyeHhICJxNJFV5lAbDYBNYkrLycB2RwcIgIOEqu+KnQxcnEwC/xnlrjc+4sV pEZYIEbiw8zzYDaLgKrEj2eLWUBsXgEziaPHZzJBzNSUeLz9JzuIzSlgLjHv8QYwWwio5tPB Y+wQ9YISJ2c+AetlFpCXaN46m3kCI88sJKlZSFILGJlWMYpk5pXlJmbmmOoVZ2dU5mVW6CXn 525iBMbasto/E3cwfrnsfohRgINRiYfXYy5fmhBrYllxZe4hRgkOZiUR3m4H3jQh3pTEyqrU ovz4otKc1OJDjNIcLErivF7hqQlCAumJJanZqakFqUUwWSYOTqkGRuM05lmL5/4X2KG0/vU9 /zehc5peCP9NUohbvKtUgNlj+xYrg3mJyjNlDPVsbDze1gVFuy9207+Yd0de6BmDIcvz6dHL pn0z3h4ancnct2bJ9yUThRcd4D/i1Zx6TfbDwZpFWjP93HiLEzvVvT6U7Hyy47v/5k15i3uX thu2Mz8M2RlzI8XjoRJLcUaioRZzUXEiAIKQFJOxAgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 5C4FEC0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7nmx71wjy6ea7znw6okxd1zd3zcbqu1c X-HE-Tag: 1712297355-358618 X-HE-Meta: U2FsdGVkX1+tb19pNkXDS2dEIMIQe0CqZASEZsgcSPwxcOCGPoiIVmWcyRqSCpLqicS3s5RX51p8m8ZqW7XxhmPraJEzUInfkTjx9x8Utm3SudXfboqLrKSs7loOKV+nIuK4/ow1jG7m0TaTclS6U+Z1it+ZDmYGunfxpuyJmsGKUKjuOs9mnHe/DTGzfRq6kDP6QLie3h5FSd84vS487X8tfuJKvUVAJtDZrohNHs60L2yu8/3KrGhj/ErAFmvhvVehMS6bJ70OvTp/MbDnzkd40FfT6idTPJ3Y83K3QYGN7R9ySBggc6k8Bz/xzUkjTQkiGGxZouN4DYMyWsmQmNkCUIRaSnSDHb8sNO3Y7ehRmDwhMzq5frWcVf4I5qGtcNy4a0EpmW42BmqFOpIpttPg03RYK6iROjGHPIsJj7x1lHiwTGup5YShlhzUyhC4W5IRv8koWNjQglkWgjf95Y66I9HyNPxtQiFWFJFyMpnr3iCKxGCRONz4jqeDUSD+ZlCK27cPxExe8Xw7rkFb5H24QJhniHtQnaaJSLTwAtcdt5WHFIgUxxuJbnxyaUjEUixGnf9Y2GxzlLToVSxCOJVQbIeQhpVBZsBusvz5t7Bhaj2Mm/5CtkzVs0U1rro5ADiBdBQnWyavdy595GW8ynjTFxAckuVEzan6I8wsA7jN1HusRd3BImXIk+kzxjgvO7YzOB/jTaueoXWRPAbesWVxFh0GMx9YpNfJcIy5Tc+BG9j+PSRbczae/5iMCFqCW484nju8aF95hDuKLivZB2nw98WgGimJtsN8karwaO/mtF1v2PlSabWmE7sIFIqy4xh5+xLXl0e+apT0uLUGFDV5S+we3CcEV7s65TIRsBks3XE1QfAwP9zfapbMBTX7uWhmX3kX9IOgKpG0K3mxpEa8CHOTtzFcs67zLZrD7Fdoz662mnMH/GS4HyIvrjkVRzsHCHbHID6CON7oWp6 HsPpPJTj QeurL846LJGusIn2dQsslmku6ODzO9bIumxsPHjL6SVPk9BS3qP5ImgutgO3FiLIYqk9U4yAfa3tYbohC4p4biQKIm61vcabJetkauwmMnW5mm6GLr5MMGZP6q4xjy0fJP4hhttHcK41nSSE6b7tEMGpQHfKkfw/Qki5FxsrTwsT5JSBoHHo8JGfHsnehiCZCJHuS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hyeongtak Ji This patch introduces DAMOS_MIGRATE_HOT action, which is similar to DAMOS_MIGRATE_COLD, but it is targeted to migrate hot pages. It migrates pages inside the given region to the 'target_nid' NUMA node in the sysfs. Here is one of the example usage of this 'migrate_hot' action. $ cd /sys/kernel/mm/damon/admin/kdamonds/ $ cat contexts//schemes//action migrate_hot $ echo 0 > contexts//schemes//target_nid $ echo commit > state $ numactl -p 2 ./hot_cold 500M 600M & $ numastat -c -p hot_cold Per-node process memory usage (in MBs) PID Node 0 Node 1 Node 2 Total -------------- ------ ------ ------ ----- 701 (hot_cold) 501 0 601 1101 Signed-off-by: Hyeongtak Ji Signed-off-by: Honggyu Kim --- include/linux/damon.h | 2 ++ mm/damon/paddr.c | 12 ++++++++++-- mm/damon/sysfs-schemes.c | 4 +++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index df8671e69a70..934c95a7c042 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -105,6 +105,7 @@ struct damon_target { * @DAMOS_NOHUGEPAGE: Call ``madvise()`` for the region with MADV_NOHUGEPAGE. * @DAMOS_LRU_PRIO: Prioritize the region on its LRU lists. * @DAMOS_LRU_DEPRIO: Deprioritize the region on its LRU lists. + * @DAMOS_MIGRATE_HOT: Migrate for the given hot region. * @DAMOS_MIGRATE_COLD: Migrate for the given cold region. * @DAMOS_STAT: Do nothing but count the stat. * @NR_DAMOS_ACTIONS: Total number of DAMOS actions @@ -123,6 +124,7 @@ enum damos_action { DAMOS_NOHUGEPAGE, DAMOS_LRU_PRIO, DAMOS_LRU_DEPRIO, + DAMOS_MIGRATE_HOT, DAMOS_MIGRATE_COLD, DAMOS_STAT, /* Do nothing but only record the stat */ NR_DAMOS_ACTIONS, diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index fe217a26f788..fd9d35b5cc83 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -229,6 +229,7 @@ static bool damos_pa_filter_out(struct damos *scheme, struct folio *folio) enum migration_mode { MIG_PAGEOUT, + MIG_MIGRATE_HOT, MIG_MIGRATE_COLD, }; @@ -375,8 +376,10 @@ static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s, if (damos_pa_filter_out(s, folio)) goto put_folio; - folio_clear_referenced(folio); - folio_test_clear_young(folio); + if (mm != MIG_MIGRATE_HOT) { + folio_clear_referenced(folio); + folio_test_clear_young(folio); + } if (!folio_isolate_lru(folio)) goto put_folio; /* @@ -394,6 +397,7 @@ static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s, case MIG_PAGEOUT: applied = reclaim_pages(&folio_list); break; + case MIG_MIGRATE_HOT: case MIG_MIGRATE_COLD: applied = damon_pa_migrate_pages(&folio_list, mm, s->target_nid); @@ -454,6 +458,8 @@ static unsigned long damon_pa_apply_scheme(struct damon_ctx *ctx, return damon_pa_mark_accessed(r, scheme); case DAMOS_LRU_DEPRIO: return damon_pa_deactivate_pages(r, scheme); + case DAMOS_MIGRATE_HOT: + return damon_pa_migrate(r, scheme, MIG_MIGRATE_HOT); case DAMOS_MIGRATE_COLD: return damon_pa_migrate(r, scheme, MIG_MIGRATE_COLD); case DAMOS_STAT: @@ -476,6 +482,8 @@ static int damon_pa_scheme_score(struct damon_ctx *context, return damon_hot_score(context, r, scheme); case DAMOS_LRU_DEPRIO: return damon_cold_score(context, r, scheme); + case DAMOS_MIGRATE_HOT: + return damon_hot_score(context, r, scheme); case DAMOS_MIGRATE_COLD: return damon_cold_score(context, r, scheme); default: diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 18b7d054c748..1d2f62aa79ca 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1406,6 +1406,7 @@ static const char * const damon_sysfs_damos_action_strs[] = { "nohugepage", "lru_prio", "lru_deprio", + "migrate_hot", "migrate_cold", "stat", }; @@ -1660,7 +1661,8 @@ static ssize_t target_nid_store(struct kobject *kobj, struct damon_sysfs_scheme, kobj); int err = 0; - if (scheme->action != DAMOS_MIGRATE_COLD) + if (scheme->action != DAMOS_MIGRATE_HOT && + scheme->action != DAMOS_MIGRATE_COLD) return -EINVAL; /* TODO: error handling for target_nid range. */ -- 2.34.1