From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE76CD1292 for ; Fri, 5 Apr 2024 02:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D507E6B00BF; Thu, 4 Apr 2024 22:34:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00736B00C1; Thu, 4 Apr 2024 22:34:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC7946B00C2; Thu, 4 Apr 2024 22:34:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9FF476B00BF for ; Thu, 4 Apr 2024 22:34:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 57624120794 for ; Fri, 5 Apr 2024 02:34:34 +0000 (UTC) X-FDA: 81973909668.28.22A8B81 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 5B1FF160009 for ; Fri, 5 Apr 2024 02:34:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ifVj87xC; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712284472; a=rsa-sha256; cv=none; b=WSEm05DypRnpoHItpSwiwbP6/c58u3UCvAnB/9YyFibDyiLCN+H2kWpULjPki/lpqpD7p8 oYy1lqLm95sGh86Lx5tWtommTivxtmOAb8dzzUfHIM+25LlkbV6GDKs0LgUX04rS/QMkmS HXlcnGGNv2Tgjp9rb2smA1WyMwezrtI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ifVj87xC; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712284472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YggOfMTHpxo2322l/tx7/mfZecoLLSLuHm+PlAKVnlY=; b=EIKFpHljlGlN5ZHSqNVCVGgZFYwMwAjv/ONRB21BYj7Qd17D7xleDLNYOt+nH2h9TPnTqj 6ADe1XMIz5OUHfLpxNZ5uubt5Mj42pnsymkcyNilLJDaDr/3DIauE+h+WmfKP2NASwo9FQ Hyo3DinLhrb7XVyRpUikS/jQgf9Y6L0= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6962a97752eso11174436d6.2 for ; Thu, 04 Apr 2024 19:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1712284471; x=1712889271; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YggOfMTHpxo2322l/tx7/mfZecoLLSLuHm+PlAKVnlY=; b=ifVj87xCXDgamX1pANYafTbmq14FqkfKaB6fucLY/XqCEeN+3lFYBk9vAvlDQlaLda 1nTj6V/tWUz4c8BXfvSfnMGvARXijJvlHjt9ST/vTR6mLoV5uMiOQ/ni0tLrKaoabGIh Zl7Vkyc6Rn5SJNqsLnCVfSBbMIhsN6aH7rlOO3/zn1q5sDVQK/0aMLlE2Mdvfbq8agbU N8PzyMwRfz2IX2ueuRaNi1uBwwwoosycLFVSnJOgYWfLIV+dYtc+LyegKohxzSlsVIlL LsS3RbWarkDEe7+cstehJJhmckXk44jwgj8soblw0J3nBmf1jMnyALU64/LGgCSXayGv V0JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712284471; x=1712889271; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YggOfMTHpxo2322l/tx7/mfZecoLLSLuHm+PlAKVnlY=; b=I9udcwwCtTTY/dTsVTtnujeShO3EMj19B4nuKqqCiwfxkvVDT1mhWdeU3b3ycAuTng XN9nWTzp0Qkh+1Qk2GpM0JpxowkxOIsl+kq/EQ98mm+qONbwA1rjVX6a4oAsC5ewatue t9pvJddb+C6G5XzOlJYeHu1oU2FG8UGjpHtLz6B9nVgqL30g2mVTbWp38EscqCiPf+QP M2JRPbD3ft8yC0hYfwWupEA59qIETJcAhxnkSmB0dHVbZGU6RpTvbUtykDYej7Z5FiPU TsQUG9pGRs8PRMOOtqFdimQ69eNuNn2cadeNXUsfuRj3Nj0TnvJ2uQc5OAw371KwxAwM lCBQ== X-Forwarded-Encrypted: i=1; AJvYcCUWIVnOtaw69dSnO2WIh6WvWWvt+QJcV0r3mAgA0RBlHGYVvEcTdeAjljFOcGnxqBdMNfEyfUojXDWIhbsQ9+nz7z0= X-Gm-Message-State: AOJu0YynwkSJ1czQEKxsbYpg3zCPbMBiNka02fg7aMnLfZZcjDzr4XG6 h+NBhwdtcquuE2tFj2ztsjgUrINdEjvNlBENrLXTXdMI/mBBGGyBWTz3EZAyymY= X-Google-Smtp-Source: AGHT+IFqb0ZQ2yUFnR7Pr1NqJSMzUUBCk16I5RjHOCUoPc+c2t/90Dx09LrRe9sw7VQcaBvY+qvX7w== X-Received: by 2002:ad4:4ee2:0:b0:699:dcb:a295 with SMTP id dv2-20020ad44ee2000000b006990dcba295mr184742qvb.46.1712284471170; Thu, 04 Apr 2024 19:34:31 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id dp19-20020a05621409d300b0069938902539sm267008qvb.47.2024.04.04.19.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 19:34:30 -0700 (PDT) Date: Thu, 4 Apr 2024 22:34:29 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/5] mm: zswap: move more same-filled pages checks outside of zswap_store() Message-ID: <20240405023429.GC641486@cmpxchg.org> References: <20240405013547.1859126-1-yosryahmed@google.com> <20240405013547.1859126-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405013547.1859126-4-yosryahmed@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5B1FF160009 X-Stat-Signature: ut5m98z65wt5jsr5zb6ktri5e8u4b9j9 X-Rspam-User: X-HE-Tag: 1712284472-271799 X-HE-Meta: U2FsdGVkX182dNO7knjbn1/o0lRTC9rifGYhDgrJjif8vkTfBHp0K0HMMM9fLkS+gPhSofVWe+dCB2KpTlex57ZLnzfJhqNvBWdStBf0uxYjih5j4VALke8GBMWRunvOG1iZcN94JuPvWQuHye44Oh5xuLCP2mH6tVqvmxVl5BVvWaSPSN7JJdNZ2ifplNWwEYzXqTXsFRJKRD0/GC9/LGOvePXF+zodNXke6o1Ns2HVHQMSexRkSXUkRRfcn+FS+3nez5dshkEqWqvWPXKppDr1VqU2xd3y6bsJGDobJdRwnA+Mf7J5pcMqdG1boS0J+kBrIqOHoE+ZHpHLx63OJiOY7GT/5aoZeNAsLWjM5LT7XOdgEQq4w81YxAho2kIRFCm5NfHk4htjm/X6/Sm+bKko1KEEgrzSKu9FtZlKeg1DMLmwSxHFiTnEsEV5yvuDLiXDmJqPuhAgUc7ghUstqYqiVIXnV2TS1+wjQ1uUou9tYXlcspAxyYiJEc0p0CFRYgNs1FjAXNpHFytvohzn+3/IYfjCf8vdqaUtOt8/neIhrbXqTU5/25pH1pmv/zmU9gp/xPW6qKz8IupPCECgOflQKHbqjZjVp0/oThrkvdQzddKVai3PHPW0sf6s/nZpWHJfYm9KdJapRtBhUh6OmDwJTM3MXEHbJg3/6dUKbJ1J1h5Tzw/hPT0cqE7RKM9Vz/FMvKnCfTz0pI2wdu4En/UpzB+s4FiH7j5IvUHILapB8tJGetiP32F8hq4pHCEHJhqfqTnW+4KXOie5wK0Eow9qkkfnBeXPc/6i4+2B3xCWD26DsvtDgvc0TWqVnGPkVvEZLs7blxnBviElEs4a+DnexljkRAaVGGxqnX2qnCZT1GFrUFKjJbffeQTTYPgp0cfN1GUmlpS0hLoJc4hT+8QElm4WnbFxDRaH0OBQLTWPEJMz+d1EXMA9CTnJ+jOG6Z6zfFN/c1iWm3Vi1Vc yZ02MWrE l+cA+byPrBcHvxIN5HGPDL559blLgUCCmiXSg/gcLaEmXJzCmKmCpkHH3H5HFM4YUyJhXjTpJccUajn0dCNHCXFNJ09+mFF7Y2dVqaWyhuZOFkUhunJaTv9/ma/VaYfvhsactITN0ht8FrlV4gHROVFE9PmhKrcG1tBodWXeqsVdLpbrkhLPls0Wuv0PwHZc0ATDTR5wrgj8N2m39KKgG7LtExVWtcTQxA+nMcIWDpOa/xU3CsEYS43/l78onLoOY08uvRoK57iAFg3kNoNl/H+fXul+ooVYQXWqdj7nD2kvJXuYgKYdxaX9uD/2N4JmjPo21g7eDjnCT7+mjC3JI+fQRDtB0kPJvoDV7mvnurHLZ0n4YNFyebJx/GyjP5I/KDYsbdWOtVL4z4tYkxuBfOHPHH6eD02k1L24FYn3SH0nuA0yZ61M+olBfh7scZNARKCmACYSKZCC8PFoZ6mvvYyUWs8phjb//8tf4l/+9SLNh8lG1hbVMIkBa/8tWOpNQR2Iw7gcB+wfO9e9kbB55FUA2xAuJTMv6A7G6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 01:35:45AM +0000, Yosry Ahmed wrote: > Currently, zswap_store() checks zswap_same_filled_pages_enabled, kmaps > the folio, then calls zswap_is_page_same_filled() to check the folio > contents. Move this logic into zswap_is_page_same_filled() as well (and > rename it to use 'folio' while we are at it). > > This makes zswap_store() cleaner, and makes following changes to that > logic contained within the helper. While we are at it, rename the > insert_entry label to store_entry to match xa_store(). > > No functional change intended. > > Signed-off-by: Yosry Ahmed > Reviewed-by: Nhat Pham > Reviewed-by: Chengming Zhou Nice one. Acked-by: Johannes Weiner