From: Johannes Weiner <hannes@cmpxchg.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nhat Pham <nphamcs@gmail.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/5] mm: zswap: move more same-filled pages checks outside of zswap_store()
Date: Thu, 4 Apr 2024 22:34:29 -0400 [thread overview]
Message-ID: <20240405023429.GC641486@cmpxchg.org> (raw)
In-Reply-To: <20240405013547.1859126-4-yosryahmed@google.com>
On Fri, Apr 05, 2024 at 01:35:45AM +0000, Yosry Ahmed wrote:
> Currently, zswap_store() checks zswap_same_filled_pages_enabled, kmaps
> the folio, then calls zswap_is_page_same_filled() to check the folio
> contents. Move this logic into zswap_is_page_same_filled() as well (and
> rename it to use 'folio' while we are at it).
>
> This makes zswap_store() cleaner, and makes following changes to that
> logic contained within the helper. While we are at it, rename the
> insert_entry label to store_entry to match xa_store().
>
> No functional change intended.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> Reviewed-by: Nhat Pham <nphamcs@gmail.com>
> Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
Nice one.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2024-04-05 2:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 1:35 [PATCH v1 0/5] zswap same-filled and limit checking cleanups Yosry Ahmed
2024-04-05 1:35 ` [PATCH v1 1/5] mm: zswap: always shrink in zswap_store() if zswap_pool_reached_full Yosry Ahmed
2024-04-05 1:35 ` [PATCH v1 2/5] mm: zswap: refactor limit checking from zswap_store() Yosry Ahmed
2024-04-05 2:44 ` Johannes Weiner
2024-04-05 4:15 ` Yosry Ahmed
2024-04-05 1:35 ` [PATCH v1 3/5] mm: zswap: move more same-filled pages checks outside of zswap_store() Yosry Ahmed
2024-04-05 2:34 ` Johannes Weiner [this message]
2024-04-05 1:35 ` [PATCH v1 4/5] mm: zswap: remove same_filled module params Yosry Ahmed
2024-04-05 2:35 ` Johannes Weiner
2024-04-05 1:35 ` [PATCH v1 5/5] mm: zswap: do not check the global limit for same-filled pages Yosry Ahmed
2024-04-05 2:54 ` Johannes Weiner
2024-04-05 4:19 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405023429.GC641486@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox