From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7218CD1284 for ; Fri, 5 Apr 2024 01:53:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 738576B00BC; Thu, 4 Apr 2024 21:53:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E7C56B00BD; Thu, 4 Apr 2024 21:53:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AEF86B00BE; Thu, 4 Apr 2024 21:53:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3D8976B00BC for ; Thu, 4 Apr 2024 21:53:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CE52A1C0201 for ; Fri, 5 Apr 2024 01:53:21 +0000 (UTC) X-FDA: 81973805802.30.08339EA Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf15.hostedemail.com (Postfix) with ESMTP id 1971FA0003 for ; Fri, 5 Apr 2024 01:53:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PhrEGS/J"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712281999; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bJk7B5sSYiZNFvL6VJUzFBmpeuSDmsHpYN4Xv/JfWqk=; b=33k88C0UswwubAD4CMgmsYjBNhvQ/HE3EwrQw4dupRqWBVQ5KhXQSRc1BCFU0ZrZkLNMi8 f4TOZmQw1vrP3ps6ISAZg44fgr3XcSgA69r74sSJVDbX0HlNXNsut0+LxgQvmXXsDdW7PD n97BgUx0DuYxXdCzmUM3JSlHAXLY1aY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PhrEGS/J"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712281999; a=rsa-sha256; cv=none; b=60X6He/7RiSOA8YN0jkroA1APn1Fpgj7koB7r/B1NeUjrdk3GCx3eWk0m88pl+HHUWK5qh Af4hEtBIIw6/QYen6bHikrOeapwsGSvGZ1WYXv9l9ue940xQ3rBBDRK/mQDXHwn7IwpZ+K GSLsK0w2tUsXyhp0K/3XNRmDbw8gUFs= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-56b0af675deso1880269a12.1 for ; Thu, 04 Apr 2024 18:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712281998; x=1712886798; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=bJk7B5sSYiZNFvL6VJUzFBmpeuSDmsHpYN4Xv/JfWqk=; b=PhrEGS/J3wvruiinTrMN6spU7XtKxOpd5RmMWvhdiqSa5+sWHQSmB7qI9IQ7YGLGRB WSybakJZWDksMP24LbiraIwfFVM0TtKsSpYe12gbUKwYHDHv1TlK5t/bQ1NGjvkckxgB 7WmvmW9m2L1B5OyhhFUV1/i00tMCln4wDuzcBTtVoNWk7BhcnsGWEPWwJNDm8Tcb76dc DHc/tdfhJMfU8WigKyV0FX72lwkibEB62t6bRRCiNiZWtxyDo+yGaj6QyxPiEVdl4FH+ zbZ8eV0h4/kHt9ULOd3AG7kLOndcl4NfghhFtzHsBZHV8vYdX6OTLZElKUoLx9CoC9Rh Dumw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712281998; x=1712886798; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:date:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bJk7B5sSYiZNFvL6VJUzFBmpeuSDmsHpYN4Xv/JfWqk=; b=JF9nLStC8xB4osK3FFPQJJ+3ckqC69Ljp7xMhTNDqYW54LHXrGCSk/78IKfZu5cX58 H4NcAoNd28yiJV+Jq2BSeejzMBP9gkxpuTmtxXVft+fjnH58F+R3UkugnIfnyPE5lEYw d4CBjir0frjIMEc71gtbtHzUUkAKaX4r7QKPmaT9ai4b+ZX/w598glIjVxl9jkyo03pE KHI9W2hoOYjTJ8k6XIKwncfTWt/nJmJxYoE37PwAGC1kUi/5Kqaik0hdFWo9QUtEm5rx 1M6YA/05pPnmpcorkwVDuNKmpFG3uw+xOJGNSjdtfU8IemBBGCOuyUoHO/m4YOpQde3k A1/A== X-Forwarded-Encrypted: i=1; AJvYcCUhkzUHVGQO3iU1DEN3OZ0uo6eK/oQL3HRgMlFe12sbygGDS0LuVCMppr+ErNX1Tufdw8etlUXuGdi0HR4EhJbKC6I= X-Gm-Message-State: AOJu0YwQrmrot02hAtUdUNoHVdg1rMqqzdQEXykZhREr+UtBbF8di9zv mBlFNK10HYo35aNelVL+M9pPVEA67KgDE8YMpcv0cDem5xa9Wsce X-Google-Smtp-Source: AGHT+IEnmOL4G/9CZaK1Sz5LDaRlNOSnGEIi6o4OtmZvNmy5HI9YfMubLekXkvBKDHjjuzEikAnuzQ== X-Received: by 2002:a50:a6d4:0:b0:56e:38e:1c3f with SMTP id f20-20020a50a6d4000000b0056e038e1c3fmr20854edc.16.1712281997648; Thu, 04 Apr 2024 18:53:17 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id x1-20020a056402414100b0056e307db93dsm105609eda.86.2024.04.04.18.53.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Apr 2024 18:53:17 -0700 (PDT) From: richard.weiyang@gmail.com X-Google-Original-From: rppt@kernel.org Date: Fri, 5 Apr 2024 01:53:16 +0000 To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Paul Mackerras , Tejun Heo Subject: Re: [Patch v2] mm/memblock: remove empty dummy entry Message-ID: <20240405015316.xxm2qczwbsybq6vi@master> Reply-To: Wei Yang References: <20240404233607.5522-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404233607.5522-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1971FA0003 X-Stat-Signature: kbo1awansxwayymtbd9hftw5xy6ha8px X-Rspam-User: X-HE-Tag: 1712281998-991698 X-HE-Meta: U2FsdGVkX1/yjKZUBtdmG4lL+HnP/N7tM4RKykAfe26ytAtZ/h3ITZKmsSc+45rSRk0YmfJo5oPLKl6favVtL+tYQw91FkTDHvqdN/XuFEUlQpCuiZ+mgyeoB/4xHVsZUtu9CzII1jZR29ylh/Qz8+zPWmbjobOl7P5i7Kh05tXYP7n8nV2SIB7x2EqGIid5OxAuWLUIJs3CIcIN0FDhCV1dQ83nfS7Xz40QoOZVCguvOLnu+Jq8fKwomG8OuXxWi6SuTKkClLBSPuGulIQ7rmPKtY0Wklz83SUpH9+AkYAiIM7BDdtCVUAPlLYxFSJb6daIgLjMGr+OlnGPD+zQbPZ/Jx4K47teOEfArDov2PTHfALelnxwxCsZlpSBX6RTigdqyUqfGX39DHU2LMIX3cfkBs367r46B1fEGd6IHHptQDnGT0TTiYScYepYP7l56Vq5T2GBY2nH7bZg5Jl7IR6glpPL+9Pl0MTP0F2NDvqkti1lMpb5uqg6izFHd1b77jIVyRg4kraz03vSlY6n7ceGj+UNAE6EiOHrRBdYMqnENo1S1F/+1Lfe+2LkE4vFMzoUoi+0IrJt/jVc8wchehQ8hsgZdVcNTNpkZ6GI2Ed6CX6tPIEe40r4Fy5jpzzJF3RM381duwrznm7bvlFf4rRCXzA2A5OheQeX/R+g9hfyz1GbA/iGk8tOKyDxcSyTk999SSHK10AzsdIrjjXPjnggdCFQgo8fSDl81ZybvED8v0l2QiWAwkCgXrnP6ccglzvvcJMBRRaY66oBmdaH6t9EwJpuJZHopEtaPxOcsjphiBm1KcGagv4WTEWtPaL90W5kgxVA7nU7doKHGYwLbU8bUWq7KNW1Mi562qhdk4wNSMuVDgG0FLFczgl/r8AcuvjfewKZQevuXD0NqCzRNAh6mrGJMdomdLfFsGE2cY9D7wje8/RVKkAabZnvNyj6u4yrAiELrevQP2tYX9W /SpLy+K6 lQu/rCYiozh6riY4nZCsGC7UVXERIoL9Xs4jzOcWfT3iD8r7VVeeYVhIuE/yDHSDSZ9Fw4QP9gi1BIC0GXaoArrT1rouNR74tvJYvDNnFcVIjKjnVbk9hnp+u6pVoAHGmdQdlhKgXGiooz5Q+EkB+koMDC7hzqhR8CRpNDtcqLhv/03GRKr7Bhfhds2HJQOptoBx12/H3oUh2pJJEmMiOnYY7qd/T71a2S48PHDew7vFQfG1uRbsAtc4e600U6pJqACk8z/ZYHc+f28tzusba+dLvDE7t9Pfmxgg0rVG8xT+jq6WL/uRV2bPaEcIliuUcaNduy1CHWAWokfik2sawGQaCubCyHPyPFYnud5ZxuqWiAewSsVypeuGwBUvmwpJ8DyUwCpQ76RI+0VyBrgHBAV2bWAbfKkBV4K7HWYEirWQfK42IfrDjoTsycinBicS4eibd5VbOC8/SWlC1iCA6DEiBHJCfBMTxkupYte2ko1u3N7dBJQOPOTjexCDasxiRx8ZfHGM2/DOGDdqSpl3wsdg7xPkzfvvzCi2MJpDxeys1UGwcUcxUOICKO2FS0a3rygG6fsD3PtoNxZ/lV4wuBMzelejP6icOpJFWFB6UVDoL6FI5KXq6+8O7qY7ZJvm+2PT28ZRW1mhjf5Pel8njmWPEjPgOWZBDD+5tjNB9sv//hVwcHFg8+Os80UgVAU9HOBUTkfeG9TtBcLwUF5s3BqwGpqmecEaHLx8qY6Qi/vqH+8OOAjF6vyvqtGQgvNy+m2nBgTX+98VEtEKpuXuzDCS0OIxKI2xJlzWnuORGrR/MxLnA0PDIZyStZ3z6KInu848PLMb9oPXFIUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 11:36:07PM +0000, Wei Yang wrote: >The dummy entry is introduced in the initial implementation of lmb in >commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization >use it."). > >As the comment says the empty dummy entry is to simplify the code. > > /* Create a dummy zero size LMB which will get coalesced away later. > * This simplifies the lmb_add() code below... > */ > >While current code is reimplemented by Tejun in commit 784656f9c680 >("memblock: Reimplement memblock_add_region()"). This empty dummy entry >seems not benefit the code any more. > >Let's remove it. > >Signed-off-by: Wei Yang >CC: Paul Mackerras >CC: Tejun Heo >CC: Mike Rapoport > >--- >v2: remove cnt initialization to 0 and keep special case for empty array Sorry for the quick hand. Please ignore this one. -- Wei Yang Help you, Help me