From: richard.weiyang@gmail.com
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Paul Mackerras <paulus@ozlabs.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [Patch v2] mm/memblock: remove empty dummy entry
Date: Fri, 5 Apr 2024 01:53:16 +0000 [thread overview]
Message-ID: <20240405015316.xxm2qczwbsybq6vi@master> (raw)
In-Reply-To: <20240404233607.5522-1-richard.weiyang@gmail.com>
On Thu, Apr 04, 2024 at 11:36:07PM +0000, Wei Yang wrote:
>The dummy entry is introduced in the initial implementation of lmb in
>commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization
>use it.").
>
>As the comment says the empty dummy entry is to simplify the code.
>
> /* Create a dummy zero size LMB which will get coalesced away later.
> * This simplifies the lmb_add() code below...
> */
>
>While current code is reimplemented by Tejun in commit 784656f9c680
>("memblock: Reimplement memblock_add_region()"). This empty dummy entry
>seems not benefit the code any more.
>
>Let's remove it.
>
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>CC: Paul Mackerras <paulus@ozlabs.org>
>CC: Tejun Heo <tj@kernel.org>
>CC: Mike Rapoport <rppt@kernel.org>
>
>---
>v2: remove cnt initialization to 0 and keep special case for empty array
Sorry for the quick hand. Please ignore this one.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2024-04-05 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 23:36 Wei Yang
2024-04-05 1:53 ` richard.weiyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405015316.xxm2qczwbsybq6vi@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=paulus@ozlabs.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox