From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794ECC67861 for ; Fri, 5 Apr 2024 10:15:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECC0E6B0141; Fri, 5 Apr 2024 06:15:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7AF86B0143; Fri, 5 Apr 2024 06:15:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42AA6B0144; Fri, 5 Apr 2024 06:15:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B9B3C6B0141 for ; Fri, 5 Apr 2024 06:15:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 847CB1201FA for ; Fri, 5 Apr 2024 10:15:47 +0000 (UTC) X-FDA: 81975071934.18.B163335 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id D349510000F for ; Fri, 5 Apr 2024 10:15:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=caMJ71mm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712312145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YlHakz0pePqX1EVIcYkNWJxw2vrGONVf14PtzliwJYM=; b=7L92e/F37Jq3X/81QxykHFmi6D8UaVzKkpFS07CFPhk0EDjw8UdrdFcYT/E5eYeaxYj8F9 Dp8Sdw4Re7pb9d5HkHO4uf6V0ub5I52CjWcW19rGYNz/8daBmx1Gao/YTvlMeQ+RX+gKRv L6LYXQsmwYfSgI9c7ZRDkpjdTszfkW8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=caMJ71mm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712312145; a=rsa-sha256; cv=none; b=3JzPjcWemSsWar7HWjOdiO/xly/GRLf1RVZNzscPataxQyDx1uM6iw9p9M+FzMHfcr+vKX BIcvtTvULVy9dxnhJdlgrSqx3ZuBrRSiKJAgiI1LBVsbeRJl3e5CNAG27nnoMMpmfT9JZf tsirVymKn1G211KJdoBOLSi6h6qN/5w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B88CD618BF; Fri, 5 Apr 2024 10:15:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F21BC433F1; Fri, 5 Apr 2024 10:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712312144; bh=yIHeOwT1Z+4CwFKwe4RcKGCjnk0s2xBp+R1BOpUfFsg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=caMJ71mmy73c69ZyZyNX4wS/2d8Gtly6EtzykUIE0yXHbrAMwv7eMWt2apQEno6io 8Ny3HtFvTnC9Gaz97HDodO14jUPgFC3leggZFXx05N0QdQvMLPMYwokSZFQfHYbZxp O/nEAmSn8QWyea3nkipZVjXjYGJ9KgFkOeQnWOkMeRzcnwCDzqKGT2YLEgcy1zW6DW epW118aIRpl+hKttSW1y64jhg1CcH5IhVBH6IsGyDznq/8k7bxLKOAjx7fl1UZW+BT erfELlSyjrxr9gChb3R7X47yIZZ6/lr6monLIC+TD0k2YntQu2xsEIQ2MH1kiRPpGw NigJI7ozoCNng== Date: Fri, 5 Apr 2024 12:15:34 +0200 From: Christian Brauner To: David Howells Cc: Christoph Hellwig , Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Message-ID: <20240405-kanarienvogel-besuchen-63c433180767@brauner> References: <20240403124124.GA19085@lst.de> <20240403101422.GA7285@lst.de> <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> <3300438.1712141700@warthog.procyon.org.uk> <3326107.1712149095@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3326107.1712149095@warthog.procyon.org.uk> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D349510000F X-Stat-Signature: ju6kp95onkim9u76um1ab7h8pw56ubbu X-Rspam-User: X-HE-Tag: 1712312145-310030 X-HE-Meta: U2FsdGVkX18wmfwNQhKEfydWvxdz85djPioHvWj1BNSQlNYIYYcn/zOTpIJxojcZkPsFijDdi1GgdU+khqwqXUWAFnMo5oLgNpiAndtSjWBLwVuLKxGaBuAFtkDL7ieDg35hqLaILkC+zbLDTvz2QJnB7jzxi1+RXnLNA4XXeW72uCW47MU2wWn75GjYjXFNPgliWxvNU57lIxWWXU2fB5VNSw3zMsUn513ZYdnmSU+2SbKPr/jYUBU7pJW5Wy8ejGhJNHsIkQdh/QHKWIAULwfNkXdi8GxdQFXcVFUiTtmdI/xJ9m15vzYRt83ohuMEFb3ULaEDng9SddulJa6Qf1PCTbYOaFyPQJ5iCEDCjtPZejkN2KejZ30AwOdRG6fB/o3893HiW6fKrG+3ykwmRzcxOO27KbB51MN1dlwvhif1f4EKvZtOvOM2qqYC/mNHOyMBij43NtsCJAVinZqNn49+t2z2g5XdGhflJb48SaP9I0mz86Xos0LK0enCimt2u2/B76R2aA+WHfRVXMFa3rmKeLTlnnGCTQJAAjmVbnex3OoADCYbRoZDiqzJyfgslWipITmjsroy+FRqhX30nc6gBNkmjGTX/vhcpS5F1Vll1LR2Cpo81MfDAvKG+vh8FMwdaruMRYYzOL6dVZ3BbRP3I+MRJ5i0cMd1TEa7lN12okgz8obGzA/bWMoFAXP2lgpcmPZCpjcf1CZDbfW0bWOq/m0H/XA4BAoToAOWARvSPXqjK9VuLsbef+vDNVLYVxT8nOhwZKuJjAT/E6Etv9X5z6UiyNDEaIkURMsph0o+KAlJY6Zcy8O+d+KEsRf/g3GYkApN3mwqQ/PWTXxe57cV2PWjUxtKgKnkh7XllT8XYVlN1UqOLr1u0wXBNX9QI3YychLrL1wjPQ8F24ZRvpqZef77RkdnW2kxbNpwrn1DzDIPrrZi/Rx4xTlqB34rKKdKoXglePRjikddYr2 aKFmZz2k awUCM611sBGc1EwyYRjfHSEBIji4juOTL/Acjus7diIc11vSNyHgRdLqi61I8yYtPdSc9il8QBpmPlDZo0NiQL9FRMR2kwaYkRrwhxCiahZoIGGojPqKyzMRKVqNivYFH9n12ZVTGTjvODDnf3uytZdAp5a1JKwQgJfUvoi2QTNjgtn4yHDM5oi7AOK4eqKTdThQxnEIUSISRGnx+1PKHxrQPKPXQzjsKqlUCKlSbNDbvSOw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 01:58:15PM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > > So why are we bothering with EXPORT_SYMBOL at all? Why don't you just > > > send a patch replace all of them with EXPORT_SYMBOL_GPL()? > > > > No my business. > > Clearly it is as you're gradually replacing APIs with stuff that is GPL'd. > > > But if you want to side track this let me just put this in here: > > > > NAK to the non-GPL EXPORT of writeback_iter(). > > Very well, I'll switch that export to GPL. Christian, if you can amend that > patch in your tree? Sorted yesterday night!