From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E868CD1288 for ; Thu, 4 Apr 2024 20:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D9156B009A; Thu, 4 Apr 2024 16:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 089056B009B; Thu, 4 Apr 2024 16:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB9CD6B009E; Thu, 4 Apr 2024 16:41:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D0D096B009A for ; Thu, 4 Apr 2024 16:41:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 492F11203E7 for ; Thu, 4 Apr 2024 20:41:48 +0000 (UTC) X-FDA: 81973020696.01.06CD492 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 92DE680015 for ; Thu, 4 Apr 2024 20:41:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xCB5k9Se; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712263306; a=rsa-sha256; cv=none; b=qCLQn3wUj4OmrqVObaVZnrbLDID7yATOYsyOBp/OHamQj86fcXWqXXhkYsbBMEKAw4wgVk zcEKOs1+bYG7wLO3goFsDsOd5i5V1708WaSrHbtt75XLCUUCmzx0D7BiAbHk0zsEUOzKdt Pass8MjDuBw3UZbUPTDFJcXZblL9vEQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xCB5k9Se; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712263306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JLj/fJONyVS2miA/LhFTE/6P3LOiLgr/bE+NM3m/3HI=; b=2LMVuuyjsPRJz1hi44FqmhBauNJ+IKEn91MUKOGF22lakS01HifYsSfPzGzDzaUoGku3fy hUEjvz/7RjugwFEQ7/1EUG+9lu1hpiJktf9i9YgEhPAjlN7eqe6HR7suWEZCRDlEsQOVaf rnj4TYOokLzgmMOHmEU2l4fn2AaIQeM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8E0CC61769; Thu, 4 Apr 2024 20:41:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B6DBC433F1; Thu, 4 Apr 2024 20:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712263305; bh=5EXluho0KtN3URvwtosuDEWmlyynq454hH4ObqHZHag=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xCB5k9SePGL1h1GjwnTTRnvuZmdNdiC8yJV6IlVJIMOf3ftmdVCLUngRHXgP04rA7 K3G7WehZQo9Qxiw+2DjJioBZrncTdVzzEcYmgShf/zlKAqGjvdHyOYgqJHRK2Us9dm /xlxd456P2LEoOVZeD1prKQXkXpYLXjS3aZ0cakg= Date: Thu, 4 Apr 2024 13:41:44 -0700 From: Andrew Morton To: Julia Lawall Cc: "Uladzislau Rezki (Sony)" , Linux Memory Management List , oe-kbuild-all@lists.linux.dev Subject: Re: [linux-next:master 2674/3921] mm/vmalloc.c:1079:3-9: preceding lock on line 1075 (fwd) Message-Id: <20240404134144.8a13404ec84d0a8eddb6dd6f@linux-foundation.org> In-Reply-To: <673197af-61f4-669b-e0f2-b229603498f1@inria.fr> References: <673197af-61f4-669b-e0f2-b229603498f1@inria.fr> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 92DE680015 X-Stat-Signature: 1h6hyi5o1dqh7kyaxcx78moibiriwfs5 X-Rspam-User: X-HE-Tag: 1712263306-941021 X-HE-Meta: U2FsdGVkX1+0ciistg4oxVi8zgLfVqOj88bIJi0HEPh6ceEyfMUaBY1iFNeoFSOaIKTk+i1dLAta+GpUmk1rr+7PbhCIy38IUAj9tsh4RWce/JiWjH6u9uaJxNX9qdiIMg0ErpDdGg63QySD+Z0BuNic64nEO8/Kv9sePWUex1/DgkMH52/gHMq8SWCc1b6fln9LZFE04WdFyuG8wswx/dmT7KRgbeWBQIUUmyiPWScTWGKoq0NEP56c/JLaolehuzZVJBNoxeQcXEK4Vi7LIRwSj8n0Q+7K/2hnjSbbMZUuOI/BDscE5lOgXyBl6ajpQr7Dp423jOcG6GdrK1X/zERuluE+qjGuKree9EzZlT1voNPtMX/I58gti1NmFfAmg0VB3DlH46GHxq8MkhSurmqub1LMN9CZmYFOfAxe3taIuNpmDA0hnvaVHnOzIzTNoW0hHxKwovNcCJYVajNiGvdHaOPEG6kIOdy545sKqxx2NZWyCOdhtNlaxCu7lKQT5v5d2bMrdzQuYt3Rre5WvXLVFcBRuy9IaF6W0GU3c5d6ESX1Jfeh5Dff/dvc85i4GM7vvcBw2TKhKFMaG1QUiMrRuMqi3FX4XWsFhDEzXmR/IMCl/WFBFLC29hH0MDsTFCFjbEFR2iEDWpCRuLivedrNFOV6Uua+ZwO2vJAeYM06dbcb7lukpDLqCOhIcd4haMGNT3DmlOGPDLMlONQTzOdyKJkDkfr1HENux9ggZhvKuopQo6VcCijPDYMNO7/NOvp62Wr9LnvbuCnpFrQ1SZQhADJti7b4nv/BL3UAmnAHOER4JH58+MuEJuh6Oi5KPSreG6zLc+Evy7FsRBsODCHrWar0FVx5jJBWppsAXfsqJFcEB8KGcOgXvVDRkn9kH8cr6/Xmwg0lCQpRp+yYZWeGyfos0aQdQdiQwxLQkhbQX3MYwEeQxjLlEpWgH5hYIEiGqLpde5sMpuAxo5m 4XfQ6G4W jIHW7U4mPXQi7yvpP0iMUQdtH519T/CA1koHLJCUS/jffFboRjhlT/WK02NXx4z9JRRc6PhviXS51MBnPQ2Y1F0l7u/uCk6Vf/uVWleSMcsMh7ocjFBFguT6/TSIjgF+x1zBQnixzbbuzaTWuLQwaMRbSKUJ2B+EU1LhEKBeDwB2QKfStVDhjLIrmx6F/eqD3hri9oxwwLQJctLizpVNzdRQGsuv0HctM2w905tp1y43Hr1ebML+u+xuOqAapqxD+zLGD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 16:19:42 -0400 (EDT) Julia Lawall wrote: > Please check whether an unlock is needed before the return on line 1079. > Thanks. The code looks OK. And documented! > 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1041) * If success, a node is locked. A user is responsible to unlock it when a > 53becf32aec1c8 Uladzislau Rezki (Sony 2024-01-02 1042) * VA is no longer needed to be accessed.