From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6813CD1288 for ; Thu, 4 Apr 2024 20:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1D26B0087; Thu, 4 Apr 2024 16:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3920B6B0093; Thu, 4 Apr 2024 16:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 281206B009C; Thu, 4 Apr 2024 16:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0A34E6B0087 for ; Thu, 4 Apr 2024 16:37:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 96D8FA16E1 for ; Thu, 4 Apr 2024 20:37:33 +0000 (UTC) X-FDA: 81973009986.23.9A18476 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id E919D1C000A for ; Thu, 4 Apr 2024 20:37:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=khwTkHXk; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712263052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yXWXvXaQQwwdlGUzvlG1EN94rlNOVaOKWLnNHntvCjU=; b=IauJqHx2/HBPLncjziwKiccLYo7tzRHsjgDBeOfCTjzuka541C2Jf9itiGCEClHiX43hEc 18Wtrvx8EKVvCJbYSE/DZ0VniZ/SqCRH7StpE7L/dXhDl4M6ps6X+oUk+yAu771SGdvn4b I+yFMk3hqBNL9myTGeX9L3ROf4i6IEw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712263052; a=rsa-sha256; cv=none; b=enjGmlZNgGgUQWmc0HGFRjB07vn0vaxPCkGCQFdtxxYNw4mpLdDSqI2pGnzUi0K/8FK/fp MzyHzpAIRdYeNxgyZFUNQuN5yls7mNJN4W2xM3YPyN3b5xMfl5DBAMwLeQWF8B8/AiuXJ6 hK1MFRoC3NYVWLQN+KQvUTqE0dp1EV4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=khwTkHXk; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EE15B61768; Thu, 4 Apr 2024 20:37:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34191C43390; Thu, 4 Apr 2024 20:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712263050; bh=xOQUEK2idfQXjXTkdK30ijsm3ifktBoOy9VrkQdzNRY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=khwTkHXk9LKus1LB5F1FSwOahT01SmpcrJgqZugyKsvzvqOehNBbCIodSj9MVTYXB rjukLs2wHTk4nGnAcWJfS8QPoKK0bIVrOil0WpGxQUlc8ylNnINeG0e3G0z6NGe55V 6OZ6a4dZK05g0ipmIjW28Tj3q5/gLd8BlLUqrqW8= Date: Thu, 4 Apr 2024 13:37:29 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: David Hildenbrand , Matthew Wilcox , Lokesh Gidra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, zhengqi.arch@bytedance.com, kaleshsingh@google.com, ngeoffray@google.com Subject: Re: [PATCH] userfaultfd: change src_folio after ensuring it's unpinned in UFFDIO_MOVE Message-Id: <20240404133729.df00c3517e0b2cc3fd0d7e3c@linux-foundation.org> In-Reply-To: References: <20240404171726.2302435-1-lokeshgidra@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E919D1C000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nczhwd9syxj3u39oywgi9zg85rn3cycc X-HE-Tag: 1712263051-688006 X-HE-Meta: U2FsdGVkX1/VB+1s6/xq68Na5sidIJgBWGiL65sRUyuAbq6CppWWwe7jsqL5PACvrwxsvPc397cuUkUk/R6tNJfw7jQs1+FXlGZhF/FI8TeXpUVWonMMLZxk2ogyra1UpVzva5qUj/vIehOl4WtcwKdPa4UoFfLxS7P7Gt4qicWWz44jeRrFm44g2bDdmaNUxvKUXDjyPv4mc4li5Fs3OBLqop0l76/OEH0kDjF98ctpf6qM4lQV0IZ7F1qcN6/NICVSqwSN7q4W8aj+F6Wyy/+lUkFnXRibX1v7e2r8zJ85PAdaxlW9YQDMTM6c9QWUHTIkjtHjqMJOGBQgSK5b1E1QVUZbJB7bWhb69rGRY47sLE/9X8Oaq4vvxMSYP0n/xpmx3+S4P4/JN1Vl6WUumVEI08RQSlp1uFrVx/4WUBQtE3wtdBPudSZOI5ENzGictEFIE1ZKtm4ol5LW0yRs4mPQxmKeEuJpjWe6kb6r2Amg1ZAsY7+BfC0okkdyPQ/OkvkjsaRrwoNaOgxeWkYP4ZyrKSQEwANUdUpqMTBPVt5PmlTcRIiEmD2cig/4ZcTgzkElxXUznXVPG8Q0EzOZef/wYIcwmS4G+3YS9h6YzvqZ8kK1xZLX3KOWb/oFPRIp1eR4V6hTd/xs5HY+TNrbQc6UB66+00HZuTU2pFlLUW16cOO14Dut51pgE7h6Xuor8c7OdnIL7rZA47dPHyR8mqF5XScZ7jB6dHClaOJ7eS8yiOqzu943Lg+wiLCeRuFd8A5nO1XMxfo8f1hwkFISrseV81QOVNaIyWSB3OLWCS7PCOYNbtECsis7gHoZfspLmNZQuAaBnIhkrssqp9TIrJhIeLe+woqS4Q+91rQUm0Vj7dR6IC8QCVV8PjGuOssLldDmpulvJbmOjOFIjXZKDxB4UBgLMIzqmUgGW8qVrSuM+ep7K7XCpXduqyaqzs5Mg6Ubx1J4hCHp4HzB7xS SsM8arS0 kwwkE05FRG7A6VBFkT7A6lvb6xFx1/AyS6jmuuBpfSfQ/65BsMKBNhGT39p6aEmQ52VSFvaT2h48qhu5nugCPSm9GN9zpXn5APFKzM6TUNJPfNp+3b9rBGgL0k4XhFpOGL2ZLoVzAoa8W1qbf+/NZiEEV0wBeiU5XZiB7Jiq3ENh/DUGWlyUMjybHidR5/pW/4xPRK4gJ5GxJWrWFq8blzm9+ctnGo0JDIS5XskCkYxYuWafMcXmjKt67WT6PW7BOnelVz/tu9AGR3ehh8oe5podB5jkL+yBK5p2CUWRfYjuL5f4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 13:23:08 -0700 Suren Baghdasaryan wrote: > > Agreed, I don't think it is required for ->index. (I also don't spot any > > corresponding READ_ONCE) > > Since this patch just got Ack'ed, I'll wait for Andrew to take it into > mm-unstable and then will send a fix removing those WRITE_ONCE(). That > way we won't have merge conflicts, Yes please, it's an unrelated thing.