From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D4E6CD1288 for ; Thu, 4 Apr 2024 20:31:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9FC76B008C; Thu, 4 Apr 2024 16:31:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D508A6B0092; Thu, 4 Apr 2024 16:31:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C181C6B0098; Thu, 4 Apr 2024 16:31:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A4C156B008C for ; Thu, 4 Apr 2024 16:31:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D1ACEC01BA for ; Thu, 4 Apr 2024 20:31:42 +0000 (UTC) X-FDA: 81972995244.07.FC08E60 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 11867180010 for ; Thu, 4 Apr 2024 20:31:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NTlQyc15; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712262700; a=rsa-sha256; cv=none; b=Z39tfZXFWgGBBiGzi8AulwV2mu9e3URVZGAZDYUQMRc9e8jqIPjTp2JHbdodY/7iRNr1tG 97IrC5P5cti2RjBWmirjMFqXdZvbydGXlIcTVyZXj0AJ7NspyoP/c7aPzKuSZ4k2mihgcH 1R/56ewUzVo46S+U37l8UfT0wfEb1xg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NTlQyc15; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712262700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zABF3TbOB4McGYmG5hP/rJ3zhLq++phh1UlfJ5jgSGc=; b=5ofON/oITj57D9/fNOObS1jUgP7EXXL1OBzxSm7lBo1vhac60lYLPrSqtsHNJ5tgw8VcS3 01flGOOjKQR9svQ2Zmj0kDHt/oHQisl6x2BqSGCVkJV18GV+WwtfpeaMUauZk3r0V7djoq XgKH/kM7DJcKlpj9NnF8GlQV1K8jZLQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EF90361719; Thu, 4 Apr 2024 20:31:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41B6DC433F1; Thu, 4 Apr 2024 20:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712262698; bh=Hew0RwkTVS+l0xV7qv/+83XciUA+bvPNzdeJES2OSX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NTlQyc15FdIpH8wOQyWjdMc8ZAOzRRTs+StY6AGUQ8aSgIpT7U6MEU0T/fmuyZviy K3fDvwFoqOb7TYdlZjCXLuzfOk9ivwYIWgn9HI2LADsG4HN4as9HbEaPxVkJuNrOZZ fVFPdzrzbWjMzZ01wXPrfGGLtOHoybr3B9Q1Vl68= Date: Thu, 4 Apr 2024 13:31:37 -0700 From: Andrew Morton To: Peter Xu Cc: Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huacai Chen , David Hildenbrand , Jason Gunthorpe , Nathan Chancellor , WANG Xuerui , Ryan Roberts , loongarch@lists.linux.dev Subject: Re: [PATCH 1/3] mm: Allow anon exclusive check over hugetlb tail pages Message-Id: <20240404133137.560d15c1a3bc7176424901fb@linux-foundation.org> In-Reply-To: References: <20240403013249.1418299-1-peterx@redhat.com> <20240403013249.1418299-2-peterx@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 11867180010 X-Stat-Signature: ijcwan3xnmo9mokkdpxuuw95pudihd3e X-HE-Tag: 1712262699-537064 X-HE-Meta: U2FsdGVkX19WizJU03U7K+qST1VTDrBYbxFwRm/9usaUMQlk5nL7hGiNsxFfbBQyfM12WmY/Eq5NwLef08r6gF70kZr6i1oFn6nkrOKV9ZeL/Vls4wVJ3OfwVcD8oqGK50MIJpVIfGj013c0JVFaJg5bnzMd+Fi9fDt0deJx5t0J9L1/q3k9ddaF5fz86v3ptGK6UmkCRp1bSGu/Ze8aIOlRrFx1qeKN9x/eYdX6znZXkFZul6FtFSdCSotdY3kArn6uS0/c4rYFpHekzQvOp403yH8x6ECLCKD6LXmrzMblSHB5fvnxR+GxrVZQq5fC8DqZi9GzqOCUAFNmPVU7V4MM+EcPKvc5YT2A0fZwBHVNwyxmD7ZNm169sksX0lwYvjQ2WxG8IFl1bLf2jHkUwZq0qP/HnDuE4YNhsCMLSYUEj4gDlIOyvVvFHDToS9hYHXn1uKAWw7IDi/p/KF2ca0JMHYTH17J352sWJhQ5zr392NJ3Fd/RpsXjz45PqOvQhZo58OYgFuoOdzHeymoaN299QrfWLvYUzC26akSmYlEQSpXL9xwjxJdixpCsRuLJOjDuPisF3j7mn0egnitzjJ/Af+vfmVpyIvB1vcQ9G89dAzOtvbrEOs9qciQkK1AG8Ves5zr/35c75urgYk9Hm42uXj6Ty33Vyd6otuWaXvCl7tXSZUxep/bu/R1+8GpqwLmATNPVvtKFSRBvMAd7qkLZ4N+ouP7VJeffbOhlUGavTvneEFrsVhxT6qBksH0dAHmjWKoea/z6QqjrDDVtGd99mEgzL8RKpu5WnecLv8u7nFqrRrKqlxkRd9GKalbfZqF8DlxP7TEiMczwl3EZmW1/3FJa7qJmIxnSvZNVsvqYRW3toNJ/pCk3d0ofyOzbrWW/8S9sGDME96DHE9yALj9LUEmuM658muD8D3isRGak4CZVMkbHW1iOyyK6AYEMxjCXcRr5Ep58d/0Yr6N kHP+PKG7 4VGWUDzds7IM0ADn4v1AwPTfNeWY3FQQvjvWwvJVHxJqEu2RYqDbl/A8QEfOe5PKVe97A+uyXHrHleLpUc9hklCmmP3o9ULfnp7DtXiJ0ckZxkkXIKo/Z9VVYdYTEvjQb0B4IHatQT4aPQO601+O08UV6eeWIOK32VK/OuciMu+wuleb7gTmCMbg67UgdLY+9s8t6mq0morNZnupHV/iFWhiVdRcLxFxCGpqNGmMhdv5xNM6dP8haHwOntURs3WyQ/wd6E1aldyUGMi7u3kjViRkSCfWks921WCIvnjWnQKZ/y4jzzZpR4YRaGnov9uIfBg76hQPemW7FFOZAye5MXniUwowca1mPSevXpnpHZ26SIHg4rFXXVdF5GP/VavP2u8Fa0TEIgkhFZNaPqLVbCfDI/NtI5V0XW8EoyY1Ydl0Etoz9/eM5Ocr/7UjJAsqsuAt/hI6ifz9dWhrtDIsn3wX4QU2tdkxk3z8hU7qCjaA8FglSyTsyhlRw3AwRrv1VGq0r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 10:21:21 -0400 Peter Xu wrote: > Andrew, could you help update with Matthew's fixup? The comment is > definitely better than what I wrote in all cases. From: Andrew Morton Subject: mm-allow-anon-exclusive-check-over-hugetlb-tail-pages-fix Date: Thu Apr 4 01:27:47 PM PDT 2024 simplify PageAnonExclusive(), per Matthew Link: https://lkml.kernel.org/r/Zg3u5Sh9EbbYPhaI@casper.infradead.org Cc: David Hildenbrand Cc: Huacai Chen Cc: Jason Gunthorpe Cc: Matthew Wilcox (Oracle) Cc: Nathan Chancellor Cc: Peter Xu Cc: Ryan Roberts Cc: WANG Xuerui Signed-off-by: Andrew Morton --- include/linux/page-flags.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/include/linux/page-flags.h~mm-allow-anon-exclusive-check-over-hugetlb-tail-pages-fix +++ a/include/linux/page-flags.h @@ -1096,11 +1096,10 @@ static __always_inline int PageAnonExclu { VM_BUG_ON_PGFLAGS(!PageAnon(page), page); /* - * Allow the anon-exclusive check to work on hugetlb tail pages. - * Here hugetlb pages will always guarantee the anon-exclusiveness - * of the head page represents the tail pages. + * HugeTLB stores this information on the head page; THP keeps it per + * page */ - if (PageHuge(page) && !PageHead(page)) + if (PageHuge(page)) page = compound_head(page); return test_bit(PG_anon_exclusive, &PF_ANY(page, 1)->flags); } _