From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67655CD1292 for ; Thu, 4 Apr 2024 20:17:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7B326B0088; Thu, 4 Apr 2024 16:17:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E04A96B0092; Thu, 4 Apr 2024 16:17:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA5BB6B009C; Thu, 4 Apr 2024 16:17:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AAE176B0088 for ; Thu, 4 Apr 2024 16:17:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3CF3AA170E for ; Thu, 4 Apr 2024 20:17:43 +0000 (UTC) X-FDA: 81972960006.19.DD97B69 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 20EE410000D for ; Thu, 4 Apr 2024 20:17:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KrPXV2nU; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712261861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1/BpcDo7wYeLVoxPZ2sfAcmGK+Oeq2S6p5XPIvH5Pq0=; b=kjEMEfxlTG9mUQQM1O8w8pB0S6DlPO5eeTiskV926UDMWGm5tL5Al3RJMeaQNxA/deyw5T ///faVYnsqwkyMBHGgN8tzjwe3zZ2qtPphsEKuL3Khvg7Pgp2awc6R41xJzen6ZwXlOoSS obH/RfZayvEGnWD01LgFLpmcR+NF7gI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712261861; a=rsa-sha256; cv=none; b=jhraTVvILpp95hXXCJlfpH3bvNYmzO+7QJ6E85AE4n9cHD9AayX8KC3w25eug8UWjFFJp7 3edh6igCkKnpoXCDb5EaVTkN3OJSWH6SGCurdIwUPYGYv+rlpK/Kolk7F7M0RvA28dkuGT bEh6oOMsgzRlGoVRKf2d4+WZiOQhk5s= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KrPXV2nU; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 35570CE31F6; Thu, 4 Apr 2024 20:17:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4357AC433F1; Thu, 4 Apr 2024 20:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712261855; bh=uykSneamCfF91Z/ip8svHyKAw+MkquNPh7Vi9yNGe64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KrPXV2nUuxnINYnVsDC2scz8wmTQL9G6CTPHM3m4EQ7Ut6kdqjU80M3ndXjnpHer/ no17YZbPA6u2uvY/cct0dtcjule66QChVpLLA30Dc0BTmdyYy6kZWF2+STTMWwOJkr CV913q0bfcZ6OHJYi1Dnv6JwvBNxDS2mdpEUIwNE= Date: Thu, 4 Apr 2024 13:17:34 -0700 From: Andrew Morton To: Frank van der Linden Cc: linux-mm@kvack.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, Roman Gushchin Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid Message-Id: <20240404131734.5fdd7380202cafcdc44a4d2a@linux-foundation.org> In-Reply-To: <20240404162515.527802-2-fvdl@google.com> References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 20EE410000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rocfaw8swuisz66jntwu17bxo1so5s1y X-HE-Tag: 1712261860-935844 X-HE-Meta: U2FsdGVkX1+Po5HxBDx3tmwIKNWxFljMSnS4NUL1xGrF95O/UQK5QK2nfiBaUU4dR4fLyLVLEHV4f7vFfdeKXLzihArPgWzRS2pFYIJSQS57jJBmySNSD7LO7UVqqFNaQh4qoXTqAWuaLNmgUgp9J1WHrpOKfA6FC0TktThh4Dr4uTgXF7Pv6WrH6gYOEwi8kcxt0eQiHZDR/geRUE7KEuyN4nYLPfIJLzrMHZ4zizy1VJ1c/DIW79w5JeuYYe+9DqkyHWg3Z0Ahkn9IFuQqjkyy8FzkjAVFH1qqJcOqSr1/cnPnY9L3+EC2F6TdGMzIH5GxONbZnzm8Eu+lcbdjS5lLKsrY8LBmOqXUBAq8dyo1Pw/71C0BN17FAyKl93Y6o8GLZWjMQ5/1alyA3tfTJf6JilcutOrB6sszGwwk69C/8gIAhS+ZVoUDopAQiY5EyVSqA5xvLRrURV8YXLtWqt4Yj8YozNSPiKXlISs3nIS/8tNvESLEwhniJYCUjJlbuuO+rKM4ReXFtQK9FlISjxhglEtQHmP1A5+k7Bp7Y9QYdvT4uTs7ZYNTPl5kDrt/nqB0ZlTuKGfVkfO1bGFEKwAhK9Oe26xaNRkzcvm0eBmelIBSOYoCdIJ3p1DHn8KvTb/6JMIjbh7MXJGRtynJnVjB12lTA8SyGEvLHj0J271WuMESSN8Pplv15DWQyXTrNsY2c3yDwdNamaF4k08J4VnphfFpIsOzW5q34Zo4YjgusJTYNQZPD8rSG0id5bSJlOuMnaSbst/D3FU8hainZTn6a9S9Bnw4RA4eQtSL9IsRnsJxAWmovsErlIf03J0GlrlRov2fjMcJssECzGUw8tSe5eXjmZGfWmwIdFVTuPfdQySIUvCHyHDBK2Fq8kF3zXVSwWZxKebCMaHi3CtlkcborAL2dSJ0XRGYlBAfLBSCRYtA/h14paHzRyFASnK7HI6DajVFgvy4drrPKxP MteGVUmF cpYjuqlNdwU4Cd8i7tWWEZxd+KrTNJJK66z3Y1An94BbDR6yPAWLVMAFaz2avKpwsI7VJ4TklhR1hOzH5LtxHxxbHQ5GFG9KPlamVyaH/hD7reXRhWDBiLGYEwtRx5EYBIR5Q1ZvF1NDK5q8Ydu7za1c3QIt1my6iuMrBmPx2L1O1Nqtx8Mt/2bWd3nD+81lsPGh6S+O/bwS8RPZEf9QGXG3mqZKgnvZLUq/2xCRbPwpbz3GdeGr97sL7eKhfm1JU1qDcLSccJlhQXL2UVJ7YtGCzTiZIjqd1Ad9CsfuWgIrxc0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 16:25:15 +0000 Frank van der Linden wrote: > The hugetlb_cma code passes 0 in the order_per_bit argument to > cma_declare_contiguous_nid (the alignment, computed using the > page order, is correctly passed in). > > This causes a bit in the cma allocation bitmap to always represent > a 4k page, making the bitmaps potentially very large, and slower. > > So, correctly pass in the order instead. Ditto. Should we backport this? Can we somewhat quantify "potentially very", and understand under what circumstances this might occur?