From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB898CD1288 for ; Thu, 4 Apr 2024 20:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62DE06B0099; Thu, 4 Apr 2024 16:01:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DDC06B009A; Thu, 4 Apr 2024 16:01:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC366B009B; Thu, 4 Apr 2024 16:01:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2EC886B0099 for ; Thu, 4 Apr 2024 16:01:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E49B61210C1 for ; Thu, 4 Apr 2024 20:01:09 +0000 (UTC) X-FDA: 81972918258.12.2EDD9AA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 281588001B for ; Thu, 4 Apr 2024 20:01:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=v3ZDjcx2; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712260867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tx0p2zm6YORQ9OO9+YoSesp8h6QYQafmH8Pydzbg9dA=; b=dFUA2iRLG6faCrop6eYdz5PtjLU/l9Xyhbc3EeLHP6WedlPblUqkXhM/Wm6Wrf5bEq4w+5 qAeg7sAl9dNajsuVOAHlYlf+zCBo8vVPHjb9LEe7rzR0ohiR9/HsdHdqgnQo8uYhlKmqC8 Gag1qa65F5dbq7jkFT25hSQc5raOpIw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=v3ZDjcx2; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712260867; a=rsa-sha256; cv=none; b=A5GQhL2HqKisNWrpRDBkbFiy13mQ+Ph/ADl3qEKzhqfzpK1gRsvItAvEQjYdC8iVn3nx49 11cDIvwgtQb//Mnlnds5Ed3p7ARskx/aYeE3m3Xn+pRUu7JZbf8OYREiQcdDeOBlMOoTEb caO16WTvzqM2FU067oZxs4LM2XE76JU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1795A61753; Thu, 4 Apr 2024 20:01:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37915C433F1; Thu, 4 Apr 2024 20:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712260865; bh=jDgRvDUXquf8+1TaLuMSDg9OKMhNKkoBxWlEmTKp85E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v3ZDjcx2JDn180LtBtTUY0btLp75KXzlujdo9T4C8aNGCv0gHU1XYnl09OcNjXzsv MxprMsVHDbcCEy7oF5q3Tc/g3dZIs8phM8mN/U0d1LRHN2+YhVANRC5jroDLIwWA5/ KlIjzseq8tJWn951wgdkSfWHObVQ00Hj0SNj83CI= Date: Thu, 4 Apr 2024 13:01:04 -0700 From: Andrew Morton To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Christoph Hellwig , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Dave Hansen , Fei Li , Nathan Chancellor , Wupeng Ma , Ingo Molnar Subject: Re: [PATCH v2 2/3] x86/mm/pat: fix VM_PAT handling in COW mappings Message-Id: <20240404130104.858c02d23216eb82438444d9@linux-foundation.org> In-Reply-To: References: <20240403212131.929421-1-david@redhat.com> <20240403212131.929421-3-david@redhat.com> <20240403151249.0f4fc5b4f8c07630fbbb6338@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 281588001B X-Stat-Signature: k7wmkfc9yr86o5noipczjmxhnrzg48s7 X-Rspam-User: X-HE-Tag: 1712260866-594914 X-HE-Meta: U2FsdGVkX18OkoiNxcJdGNOYgQ+Sh1XLfzL+WmtGFyDj+8aG/b1aU6RC8JlMVP9ow3VYrtJUZr4+pfWHQPrVkwQ1L6FmiX833dFdzCCXgSsOdm+t/Km/7KrkRBo2sZISr0lZJs7K2MtXc4Ut26Exz2TBW/SvWf9dstLRB2o6C06RMd80txbYusu4mwcVcNqQ+lZDtpkiDcCgC9sZCXF4Brjnl9n10HiRpedGLLg05eonxdBhzXw9oK5FCtclt2nc8YPeiHbvFKit/3Lwm1//tbfOad8Ftk2flPU0oJU0krjRf7cNUfU8iavVJzxMyeEUhsN30r5LVOQtgLb7H5izW52A4sayCzUCyY8QIhy/uYok1JPF7NR0wssNyGf3C2VOJic5EVhiN4iOoCMYbht+6o4rCLa40rZ6oqbgOhFPitWRLeSbPJ96GY9MS9KViH5KOWu/T99aU30fju69R9LxNHJJ7CD1JB+UeNFxDCPOiWidOFqouDuV+CdDJzJ8tkRiPaVH9Rr8V3dlghkWw7//Ir0g+WzMYK0mM1cw8uGCzL5lVasc7ss562zb8BDN7v1bmdU7DK2dcagdUcddR8b91zBqbCmH4SXFvvo2jqcgtaCOjjr+n5LK6w/NMQiIuYvnzvuB9CUx9dpuX0Phoz9K2xTUE/EW1Mka4JoV3YMWmDgeYinKnLarXSR42U9b5dswczG8X8mgKHxgeo1uU/tM6nkVSf7ICu8pYmRr/T4mW5IZhk13da7r5ivErcDKt5SaVyTpn/clap4oj8lnEqvmpi8J19sXpX/LH3REpxy5Ahlh5t1WOlZ57bLR4yhh090NYtjrKayAx18aSdKgQDO86Y9SAXHUizFFmwii0RJh9D/XJpREf5pLZ55vQoeDXKkIX8Q8jD5h+7V9C+rc7VaZ4c/5IHbEJ9IfHd3PdR37NMniQDfc30dmU6m4iMWd2Ku8q1UlPzgG4gId2VL7VA4 5XyfdJzd hpkrUhO3LH/7l43nB8Jdm2I7dH8OcHcP1dwOBSnd1Wf1GO2PsUn8HbJauRwRPiA92eas/gRIz049193d0wwOxoBUpMxEzdX5e0s9ZoLAolpbDSrq7SVxLuyQn3RP1pR9GQJDKJde21c5dLFDEiLYSL7KxNA9FALUAs90GAMU+b8yk1OI5aVKeCQa0v+8BabdD4aJVQCotrcTWrcksPZimYi2oRsEa1F7kk06qxRAnU+OuXUil2piTlananfPS9CwaPi/9xh080rauy4iPSaMs/jZXU173wwxAZWQPNwXKcQDvvy/O29Dw+8sF6bP5rXJBchtN4k0DL4cbL09rcrS0OcsP3NzE0l/fU7AVxS2iKnzLTuTE+aOl963Zy6xhWHCI/M4l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 21:20:06 +0200 David Hildenbrand wrote: > >> Reported-by: Wupeng Ma > >> Closes: https://lkml.kernel.org/r/20240227122814.3781907-1-mawupeng1@huawei.com > >> Fixes: b1a86e15dc03 ("x86, pat: remove the dependency on 'vm_pgoff' in track/untrack pfn vma routines") > >> Fixes: 5899329b1910 ("x86: PAT: implement track/untrack of pfnmap regions for x86 - v3") > > > > These are really old. Should we backport this? > > I was asking that question myself. > > With the reproducer, the worst thing that happens on most systems is the > warning. On !RAM and with PAT, there could be memory leaks and other > surprises. > > Likely, we should just backport it to stable. Should not be too hard to > backport to stable kernels I guess/hope. OK, thanks, I added the cc:stable tag.