From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB33CD1284 for ; Thu, 4 Apr 2024 18:17:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28EE66B0083; Thu, 4 Apr 2024 14:17:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23DE46B0087; Thu, 4 Apr 2024 14:17:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105F16B0088; Thu, 4 Apr 2024 14:17:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E7D996B0083 for ; Thu, 4 Apr 2024 14:17:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2104A161044 for ; Thu, 4 Apr 2024 18:17:49 +0000 (UTC) X-FDA: 81972657858.13.EA7AEEE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 6BC4F180023 for ; Thu, 4 Apr 2024 18:17:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=VKWxIBSO; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712254666; a=rsa-sha256; cv=none; b=26WDfrVxJ7ZvP2zSknqgaAN+M/accJneK2wDRlaQP34hD/0oPQVK9hd/8VJk7bsq8mFx9u SG8YO98ji0ikM3RBO3yCH+LSSVEKDVDnxkc1rGZtPL63WJl0k+3BHkQfyWQEm/AFXgdwBC FL5cjx56eWxK0jM5JoTY9iqY02Jirfw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=VKWxIBSO; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712254666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=83I9k9ZrdsX2r7O7H5Gkj8PYJzbyq6W1ygBD5t31yoI=; b=H00LpUC+xSa5fwR0DwgcI+ftM/xD7bkvzkIQ5YY8Zo07CMzqGHS/NAsInQC+VaboNW/Rob yAcndYjxsEGSArW/L2VTMLKkCWsaAs5E79CsCfBcuTGsoBGnvJsYrWl44ML0UwUJyo1G3h OfdClaWTkJ9jsHOEXFYxvbv2EIvIys0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4D53F616D9; Thu, 4 Apr 2024 18:17:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4C39C433F1; Thu, 4 Apr 2024 18:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712254665; bh=Ys+tfPTB29dKoiO/XRPcPu+ySPFIy2NcZ8tTJg+DcEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VKWxIBSOGkkveo9J0k/54HOhz1qVvosnpYa5vwgUx0d8aeKZPIDtcC8lxDXRu07GP +qxe/ydvAexKVD/ILep3so990PjkvaixsUmi3OebfdphMJ30C+Xd0+fOt3kTqYcDZb zmx/spqkAqMr7wnwsBtxtwgApyJZBL55sIdUXLnw= Date: Thu, 4 Apr 2024 11:17:44 -0700 From: Andrew Morton To: Arnd Bergmann Cc: Andrey Ryabinin , Arnd Bergmann , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Mark Rutland , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kasan: hw_tags: include linux/vmalloc.h Message-Id: <20240404111744.40135657cd9de474b43d36c7@linux-foundation.org> In-Reply-To: <20240404124435.3121534-1-arnd@kernel.org> References: <20240404124435.3121534-1-arnd@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6BC4F180023 X-Stat-Signature: pjwgtoshdwrwggoujmzyo4y4b5ax67nj X-HE-Tag: 1712254666-272124 X-HE-Meta: U2FsdGVkX1/FanDiCeJwsVdoesgsLG6wEF1yntg2vT2as5SgzM93AmxmtYCVuq9PF/JaGplqvj4uvmV/vKST1p2UclmRzfzVWTys1EaGLh9fwLMJEe0FQafiFGVv8gMSQcJ9JZUHcvIZneixV+A9jHOy3Tg/PB/ZGvcMcZI7Xkc+28TQ9lqsbEym53L7UGOVGdA7Vr3ZNLG1iPbkmWUe9GCAa8WYdYw4yMLSLHfHiS7FOoZWmUbYMGj/utLMBBaaZtMhxII5/2SZAdcEBCRKZQBdoDD4dkXBBhI616eri+0wH6zh9fzL8M0Syu/V1IWxgASB4rZT6nRSYsEqIZFV1sn37ac7ZtlSt0e58WfO1PBMqASodp7SGhH2IQt0KV33l9xttLngJY+lME0P+ieITF36hpUS1o3gOuMTejnmwMqItOOdMgCeAOQYTvG2y41knq3bvGJ7lJSEYilG5IfZhjEmCZahUfcJRzJdyKah9EBrGWui7nBgD/ju1iWmww+u9N4TCcSajKgAkL2v3r4LCGQEv+AmrEJ5YnZK9VUj/Y3gJh730mW0C5s1BzDxSsK4UPoNWtmXL0hoxbsZpyyoVUHz/D463PPlx8z2iqLLL086hHJulfzzGDn+Wz4UQeiAaRfuAeDoKfelDo9aLXXjeyGq00XtNi5LxxOdEPv2vpKgIfR/83ud8v6e/5l48KRlqa8RvTM66AkwCG54IPVq990zOsnZxNGnAAab7maGCyXMKPAIggIgQJLuLLmAG66X+is9Os4/tT7lZ5pGzsvCx5RIdMd4REsUNQdk5XeJdNRSbSVuF30QZVvFMjKPUjxtVTXy69kwjnHAcxfwJB1k8bOPG5e8zGgfifmhBv9eDq1C2H/IYC98TlDvZErQtX+RgVCzIeHQW3HkoNXs2lonROO90z9UpmjYHxYewdzYwdSWREmWsX90tMQyEuAXkxrQ8VnFWP2iybWow/Sgo+I xrWJZ82T 60jKsTHSiQLUXQvEedpy6hp5A7yxfTsB+lMCW/rxloki3yEMDsNt/gtMcl8dHMsrh3BqA4j0DDdONdXqMK8EgoVhphcPLFl6zHaw6QoC16oVO3I9QOysvaWEEJlnVqndr69etG0xKgJwqEUkJ3fYKmdXk/qVxH+CWjozWIwyEzNu3O2CW4e7NZ/mXSSZYZd3RAHeN/KhGbKtgagQZGTU0V72jsTM9WgWCFIunJV6CNxDJj0TU8fZRsdM3fJwkIiuOkT0IyJXhKUIJTy2pPiC1/E5eHU6fpVEf4d6H/zSBYuvMjDLmOtw1FwVQ4TulWlNh5EQ3wEBT+T42CRa3jBztG/hA/USFP819vZDEFUMz79zgrdXgtsF8O6afc6JLXTkfTbEsVhEdbU5VwoVQaBPmZEP7mNPBZmRj22MbCFg1XRQEBQYigzsRJJ8zTQ/IF/vzMd+W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 14:44:30 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > This header is no longer included implicitly and instead needs to be > pulled in directly: > > mm/kasan/hw_tags.c: In function 'unpoison_vmalloc_pages': > mm/kasan/hw_tags.c:280:16: error: implicit declaration of function 'find_vm_area'; did you mean 'find_vma_prev'? [-Werror=implicit-function-declaration] > 280 | area = find_vm_area((void *)addr); > | ^~~~~~~~~~~~ > | find_vma_prev > mm/kasan/hw_tags.c:280:14: error: assignment to 'struct vm_struct *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > 280 | area = find_vm_area((void *)addr); > | ^ > mm/kasan/hw_tags.c:284:29: error: invalid use of undefined type 'struct vm_struct' > 284 | for (i = 0; i < area->nr_pages; i++) { > | ^~ > mm/kasan/hw_tags.c:285:41: error: invalid use of undefined type 'struct vm_struct' > 285 | struct page *page = area->pages[i]; > | ^~ Thanks, but I'd like to know which patch this patch is fixing, please. Is it mainline or linux-next? I'm suspecting it might be a fix for fix-missing-vmalloch-includes.patch but without knowing how to reproduce this I can't determine anything. > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include "kasan.h"