From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C875BCD1284 for ; Thu, 4 Apr 2024 17:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ACDF6B0098; Thu, 4 Apr 2024 13:54:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55D936B0099; Thu, 4 Apr 2024 13:54:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 424926B009A; Thu, 4 Apr 2024 13:54:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 22D476B0098 for ; Thu, 4 Apr 2024 13:54:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD431C0148 for ; Thu, 4 Apr 2024 17:54:00 +0000 (UTC) X-FDA: 81972597840.26.4060D07 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 88F5518001D for ; Thu, 4 Apr 2024 17:53:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZJXqo2n5; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712253239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4wy6qBYMLq/CXP2BzkFbdolN5d2ZgKEbeXR/WYDQhM=; b=hFDIEotUINnflTlYhq+eR1BgOx35/STeqdppfG+LR1R0k2Rw3R+5w72QAcBf+lmdriG/xw C02ObdkIn75bHAHMv0O4QGGumEfX/AMbLs+bXPagWiO0VZTaTwxcRXJehUV8LPZ9A9bJSt x09tIwgH/5LMXjuiL6WrLkF9ISIQx8I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712253239; a=rsa-sha256; cv=none; b=xDxzMF2en+s54zqPmKBJOlz2NpOZeHDNbN0gvHkmOZQPU7F3areRxkrKnEnb8PXVtJeH1C PYOIfigqiVjpJPgT9K47XLCVjBlZy9svCl0O9QSOpw71AlIRuX5GsVZtS7VbERbH6KZTk0 Qxt/jsnevsxrToPe9BjCZzmKiP3QsyE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZJXqo2n5; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2A121CE32AF; Thu, 4 Apr 2024 17:53:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47EB5C433F1; Thu, 4 Apr 2024 17:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712253234; bh=MMcUkHlDFXVaqbNtiKCkenn3PkUiF9CXnNNLThdCsAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZJXqo2n5aTksSZxug/ipQJc+8UVOmCndmtpp1cEA+8fAA6FP4Bsm6HXHq2YHqAdP+ Fnq65FsBtYt3FLBf2pqAIAq7Ajum2wN06b96r2QLDqcXZa5ppTlkJJKRxh+JuTIEG3 WVzSKv8YfJDZMEJQ4laXjXdYBBWBQbvXKkakTAH8= Date: Thu, 4 Apr 2024 10:53:53 -0700 From: Andrew Morton To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Dan Schatzberg Subject: Re: [akpm-mm:mm-unstable 300/300] include/linux/mmdebug.h:114:35: error: expected expression before 'do' Message-Id: <20240404105353.ba7b383d976018512e760eb5@linux-foundation.org> In-Reply-To: <202404041924.UiccBz3l-lkp@intel.com> References: <202404041924.UiccBz3l-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: n69zrzcuiftyd8fxcj9gz9ikjtucaoyz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 88F5518001D X-Rspam-User: X-HE-Tag: 1712253238-438702 X-HE-Meta: U2FsdGVkX1/FcdF8OHTJJ1Mx7Xbz3jhRQYBZlUwLUB7jEn02BIaEri8ezDNV7RfJCMNI+UYZYiRw8MMmzjGCNJhM3IifmM5nZC9bJuFyQW5cvIsgK3L3NfF+fAJPXaLKh3SPGOz3UGkHDgsRf7RtfEUxbY0oesMnCHDAUF7Uk2lAy5IqDHwGx238o7USco9zNBUpnPc1fWn593ngxP7UD/fOvt0GWybCSxyNceKm51gICH+cB+tn1zDNwEfFdIVu/fSBlCemRQIlh1tF61hbzGye3H6SUNOhagk7eU1BZ4KmJHU7ox7Z66Nb/LUbloY9XiplHD1gfg2y626OSQthS5DCPwdKEPcm3P0ALjoS/VeXqQ2sYap4VoYm7dnIu14EiRArjg/Y/vfZzFLyCYDSdlzKlsHE6s1Z0LYlcSyYtDn3yPMlQZDEFPKOqVPlmzK6lIxdp1irEcOCjdL3b4qE0m+QzNjUy0PCiySt51X4poXp14zWRWHryexJ7DCre4OgZU4+k9umNeTvWCEBqoG5jcvJrJNz9oIFpkWnkuIDg/HwRPRD8mGkLNCyeHA9UTxEQwHpK37rHR6tVbf0C3ZoldroaS5pudgaTuhu0XHPTZcUICa6laCeZ9lhT+T/ArpZ9DITs+oqvei4kr8zdfWxviJxEfDokUNDLPwudtmW59EEAhIrHclzswgFvzJ3SuENu6ik2krD3k5kSfL8Bs01+SRtUuX8/N5YZ558C5TU2ELpzuBSULER31R8jTRuaOpcENfhARQLyPL0yDYFgpO2hJJW4pIqMFMKCa4fSLYKpaYeIdOasIF0bkS4xGRgkh6CxGZoK/JuIVYkeCy9MZ6uNf2iW/ChV2FZFK6j4bUGVB+0VjpXNEVwk1LzNtOdU95ZOQ59/9M6ED7xsTVoW7qajrIludDJBDWumjgkZEHEW+qesVTnpYtcZVcUkPvo7TC1vroCHfO+iFpQ2Icke19 couRlnfi tXg3SaRESHXaXX1lUuetvuafjMD7omFBb1zLB9Azw/zX6sk8pnZ5mdDE4JQklQPp1eQGvyKbC/x3bP1Vxk5rDfh7sXgkZhexqERu6wFJF/ga2nygtK34FyCRqeej/PjYfU+OUArArpGUvgP1tuPc0vMq0qGviEzgXloamlMe/AoUAtG3gpnIYrOVgthCD4fALTGQnmxraOcF+PtUeRC8k9y3rWJBoTHWENbM+ohXBym7OD2BdTlpAHBff1L04L9V2TwysjAS9JsTaJ3bNNV7Iggx9XBM/h9azmWHGxXwQL+Mllgb5ajgEiSLwgXqA19eMp+75NdrkAvqogrNr5cItBDhCRWFG7aVCdwtHsTB3GXp5oMldQybVt9gq0aP6E3L3MxL36RY8WNHp1Sn2X92mKLu+acDPvYT5Cycy/jER1U+McGzQIheOKeG2hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Apr 2024 19:31:40 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: e04f729678f630b7304f9a8d5d22819fe589681a > commit: e04f729678f630b7304f9a8d5d22819fe589681a [300/300] __mod_memcg_lruvec_state(): enhance diagnostics > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240404/202404041924.UiccBz3l-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240404/202404041924.UiccBz3l-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404041924.UiccBz3l-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from arch/arm64/include/asm/memory.h:213, > from arch/arm64/include/asm/page.h:46, > from include/linux/page_counter.h:8, > from mm/memcontrol.c:28: > mm/memcontrol.c: In function '__mod_memcg_lruvec_state': > >> include/linux/mmdebug.h:114:35: error: expected expression before 'do' > 114 | #define VM_WARN_ON_IRQS_ENABLED() do { } while (0) > | ^~ > mm/memcontrol.c:867:29: note: in expansion of macro 'VM_WARN_ON_IRQS_ENABLED' > 867 | if (VM_WARN_ON_IRQS_ENABLED()) > | ^~~~~~~~~~~~~~~~~~~~~~~ Thanks. Macro is annoying. --- a/mm/memcontrol.c~__mod_memcg_lruvec_state-enhance-diagnostics-fix +++ a/mm/memcontrol.c @@ -864,7 +864,8 @@ void __mod_memcg_lruvec_state(struct lru pr_warn("stat item index: %d\n", idx); break; default: - if (VM_WARN_ON_IRQS_ENABLED()) + VM_WARN_ON_IRQS_ENABLED(); + if (!irqs_disabled()) pr_warn("stat item index: %d\n", idx); } } _