From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6677CD1288 for ; Wed, 3 Apr 2024 21:12:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47E546B0085; Wed, 3 Apr 2024 17:12:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42D406B008A; Wed, 3 Apr 2024 17:12:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F5186B008C; Wed, 3 Apr 2024 17:12:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 120296B0085 for ; Wed, 3 Apr 2024 17:12:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9D46C1401F2 for ; Wed, 3 Apr 2024 21:12:53 +0000 (UTC) X-FDA: 81969470226.22.DA71A51 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id 5241640010 for ; Wed, 3 Apr 2024 21:12:50 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AvVi8LMC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of nathan@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712178772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OhewUsTCeDFq8xyIu5MjA9BruMTOLLNvnjeXU/NxsuM=; b=0HmlZdTyfQmjERKDtqpGS1TYcKhAmFJUg19KfdCAn0g52i2HzNX7CgwgGP//oXmrgqaFXj So+UHS8R/Vf5A15nFJjSE8ooQEWrc99KLrBlTaU0Wbi0hJsHEg3cdCBp9wkH8SW1n0c67O Pgrm8vSmYm5W97Tdbg7780iS/5pDoaI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AvVi8LMC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of nathan@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712178772; a=rsa-sha256; cv=none; b=O7dZQ39ONxKGs0OXYKx1ErdUar6L8oVWa2G0hAYQLQp8KfDPssuXAI49rDX9GYyiLtZCfx jxMEhMjQuptEYlu/u61mCd6LU4J1SPAqe7XRDa4+ZfKpzgxgAwKV54RVjui+Xrg06MI8rX X2lOwsJBeABDdr/COfHdN/7HnihpFkU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C23FACE2C17; Wed, 3 Apr 2024 21:12:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E15A6C433C7; Wed, 3 Apr 2024 21:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712178766; bh=eAxmNahq0qz4MjguPAZcqC0KPuy9iIiFN/TD17zLp6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AvVi8LMCPmD4vtizYlqbbrKdv6QHneAbgdsDhvVCwOCKlEjxORkOrxxsJaVKKe7ib YfLM/rXrgmOgLEfBvFZMk7h4uuO1i9LQJ8M/6UOuM3j1UhfgLRc8vtGUdYkyvOB7qF FK0zIrKPLUKf2X5PFEHqblNLkN3++ZGBDxB0Ckhu7GEuMY1ENqC6PtyP4PptCVwaCA a2tbItT4M2CDmlu7PtN/anCWs0FKgXZEkpfh6sPHkTM077WDUkJUHG5B3YhvYpuPju xPxmHBxAuN4+ZSpTgL2wp6f5XhRGsP7bV4GU68Ip1Yj2vPHXgYGKnLcD5SyRvdfCp0 PZSDJCo+DH2qQ== Date: Wed, 3 Apr 2024 14:12:40 -0700 From: Nathan Chancellor To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 01/37] fix missing vmalloc.h includes Message-ID: <20240403211240.GA307137@dev-arch.thelio-3990X> References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321163705.3067592-2-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5241640010 X-Stat-Signature: 617jhsddc7uffq95iurphu9hy3ib5oug X-HE-Tag: 1712178770-850362 X-HE-Meta: U2FsdGVkX1/wiF70O0ZzX+ZBAF1OSH5kBWTezgaHWCIvecoKzJsTQB08Ehaqdgy14/xOICgHhbccAzO1YVheDMr7sc9f5G2ZTlrQE6tmvumNvDgsPhBqSr6YzQcpZ29sAtvIJVJHb2YQDAjA6ZhHlpbDDJL9jybKirBjeHrUdzwVPaKxNoh9eVutiB9FbH0ERP6dujTbt6/ddUk+iO2jxEEnVawLCq6k2NDtHpmLhE8VRPcoIX6k+ZmHU/nPLk3KRamHccZYM24MBYKmqWs85H9diBrXzn9YIqVdnIBDuva32qARU/WHKjiPrgke7g/Ju1CP6GebBUN4N9jBCTw7sKJMhOEVhj0YvI3RlGXqZRsWvqXCUVO53sqA0Z7FLF+DFP42xDREsa6M1OeKt2lmSoELi9dcg8/csQAkZl8V8pAzkbJm7wVN08ln77wEPQhOfEUBkZGIzRvN6PvDwBVf/rOjyVuD8T3DACXDOTkMymZKB6UkUwORfhZKRNEdnh4CnY9YVp2OkqtGd6SkjcryIHx2MZTKHagJiiWbHLm/xm9wpECCv8VG9n8SxDwkEu855tDRjWk64srwgiqBMcfeNCHmhH9Rtz7Att36cjMbDPxYmNehd4PykmmYWoIDxxRNNRAOhcw7AyC+1pKT+gvEUp9EL7c/EjTv3z00trRFl7MNkWVq8W34xAS4Iyvxo4CaMnkl44PD3C23gmSysBUqnIdvziPsikKarpHbzCDiyp6g5+cngpWvLXM8G1+Yl8M+1zeXMoyMVQoT5NV9dQhzSAft4oK8H6cH0XE5Xwf4PO5xbSLet8XimjrcjBWocTAcUy5+OqtrzcV72KvM+LbEJd0xw8JLSr+TTm8WBFMXErCq8BW1rJ2uxMLvYsg8kEn5e0e9/xG3akQQeFZ5G/UnTS/00KKbP8c3IGA1n3dsyFeC/YlyhjKuZoQvnXOONpPw7RBN+xsLNOprPRohcV9 qWtBlmWA AUef9+Hh4VBGzUwlwsd9QuxtwxXZN/GfIvjiPKmzmGpoFefo/8NvG4/2fjem9+xk6E3+UeuW/KH5I+//1dIpFXNHcDHD2Oe/FQT1909TWxfyLXr8j9mRWHmImqQtAD4ID8UAypC3xrB4y/thUYTfpINCVwra2TUAJy89GaOWeZz8q35Uy74dKCrUjfjMvNrZy2+8VvBxkNwrBzO5USFcabRDnHBf0mXcxyRHU0PS5UfOHm9zAD7TZcnnpfE4BcJii8vsx+WGXr1kawGH2eU9Iamit3CklHahhm5Gro4w/Hfik435+NPocK9Q8b3FTVPqUeHmHdZtufljrMFEfIVjxgOHNEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 09:36:23AM -0700, Suren Baghdasaryan wrote: > From: Kent Overstreet > > The next patch drops vmalloc.h from a system header in order to fix > a circular dependency; this adds it to all the files that were pulling > it in implicitly. > > Signed-off-by: Kent Overstreet > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Pasha Tatashin I bisected an error that I see when building ARCH=loongarch allmodconfig to commit 302519d9e80a ("asm-generic/io.h: kill vmalloc.h dependency") in -next, which tells me that this patch likely needs to contain something along the following lines, as LoongArch was getting include/linux/sizes.h transitively through the vmalloc.h include in include/asm-generic/io.h. Cheers, Nathan In file included from arch/loongarch/include/asm/io.h:11, from include/linux/io.h:13, from arch/loongarch/mm/mmap.c:6: include/asm-generic/io.h: In function 'ioport_map': arch/loongarch/include/asm/addrspace.h:124:25: error: 'SZ_32M' undeclared (first use in this function); did you mean 'PS_32M'? 124 | #define PCI_IOSIZE SZ_32M | ^~~~~~ arch/loongarch/include/asm/addrspace.h:126:26: note: in expansion of macro 'PCI_IOSIZE' 126 | #define IO_SPACE_LIMIT (PCI_IOSIZE - 1) | ^~~~~~~~~~ include/asm-generic/io.h:1113:17: note: in expansion of macro 'IO_SPACE_LIMIT' 1113 | port &= IO_SPACE_LIMIT; | ^~~~~~~~~~~~~~ arch/loongarch/include/asm/addrspace.h:124:25: note: each undeclared identifier is reported only once for each function it appears in 124 | #define PCI_IOSIZE SZ_32M | ^~~~~~ arch/loongarch/include/asm/addrspace.h:126:26: note: in expansion of macro 'PCI_IOSIZE' 126 | #define IO_SPACE_LIMIT (PCI_IOSIZE - 1) | ^~~~~~~~~~ include/asm-generic/io.h:1113:17: note: in expansion of macro 'IO_SPACE_LIMIT' 1113 | port &= IO_SPACE_LIMIT; | ^~~~~~~~~~~~~~ diff --git a/arch/loongarch/include/asm/addrspace.h b/arch/loongarch/include/asm/addrspace.h index b24437e28c6e..7bd47d65bf7a 100644 --- a/arch/loongarch/include/asm/addrspace.h +++ b/arch/loongarch/include/asm/addrspace.h @@ -11,6 +11,7 @@ #define _ASM_ADDRSPACE_H #include +#include #include