From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96956CD128A for ; Thu, 4 Apr 2024 01:23:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 078606B0087; Wed, 3 Apr 2024 21:23:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 028DD6B0088; Wed, 3 Apr 2024 21:23:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E327F6B0089; Wed, 3 Apr 2024 21:23:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C66E96B0087 for ; Wed, 3 Apr 2024 21:23:25 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7FA68A04F6 for ; Thu, 4 Apr 2024 01:23:25 +0000 (UTC) X-FDA: 81970101570.06.03CFE14 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id C020B100011 for ; Thu, 4 Apr 2024 01:23:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=x+BYGjbY; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712193803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SvlDr2y+Ob7kmjmPwSpuKpySQO/bH1vGiHXxqMbrUh8=; b=x5Tc6j6xrl07W60cktBoTKjy85FAKVUtywkg/4LV/KV4Sw4UFuuy3SQl1YNxK/lpoorba2 XB4G5toXvmsBh7RfV3rzU078sU0LOHnVAEOZmaaL70Ytsa/Uww9OTE0hn0ZiDKshd8pVUM D72lm+ThGTRziCEufHFIzZ3fm71zV/U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712193803; a=rsa-sha256; cv=none; b=DfJMhXmkmzgrCM59v9cXJFti1SNGK1juirutD/aVaEppLmZWjoePXPwSPpYXVS8GpPppHD 49aqAmkqau9QqdiaQXMGYi0fsKLD320BD9IZ38ztQXFdAx/gE9idlVHN1cCDwLZTn5rlyC 5K6lbXvKMXzvPwUIiCbOjCJ+WrTgYSU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=x+BYGjbY; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8666F6120A; Thu, 4 Apr 2024 01:23:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CCE4C433F1; Thu, 4 Apr 2024 01:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712193802; bh=9URrAD4orwea2h0JUDYqZmyPdfENFD+fErFvc2LrXQk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=x+BYGjbY91XJTlptfwwpdhOxujYVJoHL83l7liK4etCRE4+klynk2MQ4AVH118p1z PXCKTuU5+3PMd5iEQGfMJXoueP76m9i1+jb2EWzPBEUoPqtc5DRKvtXNyUqFiydAF6 8Y2t0d2vZlLwJC3MW3pgjAgpLIylLJv1mtHb3NVg= Date: Wed, 3 Apr 2024 18:23:20 -0700 From: Andrew Morton To: Jiapeng Chong Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot , Suren Baghdasaryan , Kent Overstreet Subject: Re: [PATCH] mm/slab_common: Modify mismatched function name Message-Id: <20240403182320.93491c23ed5ae19e94158ceb@linux-foundation.org> In-Reply-To: <20240328020711.125070-1-jiapeng.chong@linux.alibaba.com> References: <20240328020711.125070-1-jiapeng.chong@linux.alibaba.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C020B100011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xhi84qrxc5jnc6ry3psagbifjxqtcz5y X-HE-Tag: 1712193803-200552 X-HE-Meta: U2FsdGVkX1+xp91sGUv7p95PrQPTpajW+MZXkHeq7RSwRDRXBcSpBpZxo6hcOK4qp9EaeEGcjT0bdKJg6eMcB/Slo91EysNXogExcOypfXyEhDkhAdLl2HQ56nx0dwh28q1gyk+8+h4OiLyPDOBQzp3TMXZP8A2YngUxkpc3hsOs9ljm3d4B0Mr0XhFQW1fY7q3LSvYtMzpH3gQ8lVeU16JsEvhvqRIcq15mIKU2k7Jdr8s4l0MVOW98PGyJFRlIqntJ5SyjzEsEu7GWseFLaEjvfP6dpoLtqwE6X6/1qOWna6wGG9aGTi3Ez5GjiSDX7IbWAaSAU4JnIzG4YeSat62+XR1vn1AoBzx7jgk1dcU2FySWZl4RtrmKp0VTNooPAmT5SZTCZg/fUyltz0xwPTzupAf0aYvlc3NGqV1r4qDiAZqbQlhMLhaoSl2AFHUxX4aylA7doMiSMXJaj37mMK4L2Ql/qY6T7gsYoI2CKpipgGwzEncxcys8VDqS+gKSrwyNx4Sm4hD+QNZk2eKEpfBBrBeyRbaQucztqQpef9wU1mcOukpSMkn2RCMFlbyQ/re0W9HMBinU9xPXxNnb5iOxwZBd2R/WzEuwUV0jvx7y8kPmpVvGNclhYfk80Zaco29tCqAmSkZRJ8gIK7LbVJSjbqRJCYEFatZJlM5pjm5pVdZ4YuDsl0RorLt58bE7LdqcOGN9uyLCF19ZinQFqgjwARAPVgJy6DoblcdQZKkKhX74Nt3r0U7gghfcCWFAHiuLwxbcgNYmQkp8wlN9XmclslBTrvSUu6SjOQ3+JlnKWy3GFJn+YQz87Bvg2XQ2eI0Yc08pbumCgTNL0lfZXdLr2lMF1eKeki6PGqCtk/m5PzPnE4yvHpxeVPpAZrDmeDlZ41rvw+VOWXiCZGksGVPzny6UFATt5ZR1QTEWJ7b8mFvz7YDxQpqzfYo53/5tmCLxw3IZ0Bi8XwHSu61 9HWnljzu K6XjDspDBjEvM03OY5kX0wdk7Tj4qQahvRmmoJ+6S1egw758nere2BtyljsL48ujy/UduehkaNHS55rGaPClYjZhl5m4ePVTI1X+l7AAzEcpFTElsKHcHo4dNMbyXOPa7RVP0Zm/rcTw5gDR9nuFa6+DBnCR0mpBN5u/HrJBCDysjogusBjZr43WTyc1g7oU+dZyEQwy4GjXTBNj4xLByDEcVZU6qyi1+FITRJZQSgseK2VcqUr6Hj6v60NytvJvNFzJyBaRVCaUJoGzhgXcjnouSwUlzSER9m/r4VS4VNzoHmqBXFbKCoJzd0CvQM79cp6CPNHqPMHhARS3jRmZ1HsrMc9dzpV5OGRonJlq/rAmwgTty9GkEP0IQlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong wrote: > No functional modification involved. > > mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead. > > ... > > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags) > } > > /** > - * krealloc - reallocate memory. The contents will remain unchanged. > + * krealloc_noprof - reallocate memory. The contents will remain unchanged. > * @p: object to reallocate memory for. > * @new_size: how many bytes of memory are required. > * @flags: the type of memory to allocate. Well ok, but krealloc_noprof() is just an internal implementation detail. I suggest this documentation be moved to the new krealloc() wrapper site. Because krealloc() remains the thing which people actually call. Presumably the same applies to more of the new _noprof functions.