From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D4ECD128A for ; Thu, 4 Apr 2024 01:08:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4646B0092; Wed, 3 Apr 2024 21:08:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84546B0093; Wed, 3 Apr 2024 21:08:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94C2E6B0095; Wed, 3 Apr 2024 21:08:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 773596B0092 for ; Wed, 3 Apr 2024 21:08:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 15D74160741 for ; Thu, 4 Apr 2024 01:08:00 +0000 (UTC) X-FDA: 81970062720.03.6E8D0DA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 809D24000E for ; Thu, 4 Apr 2024 01:07:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=p0SeqJJv; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712192878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KLm26wgMmbzjzRlJbtfsumedOrDWBf2I9dzhXGuV0Pc=; b=eKAfcs2Fj6NOoNbynLFaejfsU7m9akDXjBVjjYYihtBtGXy5haLCpJU8IZt414mmSrS3wd EAIrS6hBZMq+vtZa4fasCPPSwReKuo8qIWrl0NEfqnwAKoE9RF3b9V2fNe+CqflvzDh1dn Mx2NqZ5fxobiJMze87qkQ8MmmB9t6Iw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=p0SeqJJv; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712192878; a=rsa-sha256; cv=none; b=wHTE1mD5LmBsEdO76N2gukpqpxPR73Y3NlGu3LzccIVliQoJR++Z69LapOebdFzhc098Tl 8B2EPYgVaCVPifKZtiiTgwcveDiDxnsORwZLtYA5P0HlItsVyo0qBo9pD3A+u+YxkZu05h zRBA2t4Dbh0HqR0lzIv2Is4wOhNwfZI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14BAACE0AC2; Thu, 4 Apr 2024 01:07:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07B1FC433F1; Thu, 4 Apr 2024 01:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712192873; bh=FtaGvZn9DU8zSy564EUnjvqdBkYKe+7qJxI5a/lH6GE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p0SeqJJv5v7ULZGvarHpc1u8KHj7ZFli8N09Omm2YvQzu7bRwLxryoH9UnRltzubl XvFEtCl7YTXsjpcqwRKp9kqT59CkvQTC6Lu1rNqo+O8VI5K6Y6GJn5gh2y3U+XLqb0 8UtnPjuYEc0CVtYAz+h//EWBxcQUS9vqQzHHoy0c= Date: Wed, 3 Apr 2024 18:07:52 -0700 From: Andrew Morton To: syzbot Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [cgroups?] [mm?] WARNING in __mod_memcg_lruvec_state Message-Id: <20240403180752.f95e1b77e033b5e03164c160@linux-foundation.org> In-Reply-To: <0000000000007545d00615188a03@google.com> References: <0000000000007545d00615188a03@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 809D24000E X-Stat-Signature: mbudxafghxrf1kyqj1mggod6xpgkhz1t X-HE-Tag: 1712192877-473532 X-HE-Meta: U2FsdGVkX1/TliGPfDU4NmnqRgn4mlt5lNJtfyYLlPZDrNfKXUjrk2F91+9vnSuqpkbOn8NODdzS0f/8Ox9hFaD82ScO9PZbapV0t0qr7l359rIYODNVfyQHly0S9ie8PDCpNk89Rq7PbzfTI0IlJ+g54fxvFSoEmMavzSm6SI2b6mDmwAq5b2z4EAjBUB7ZcwWd/8/cfuoHt2y0bfhZUyX4XZpTfm+hUxLvxK9b/jyeOgIf7h9G+incJ1d4fgtTR24tSDuH+VhoBgfKyu1zEyskoUD8HKkXMub+0ZgOX+Z0l34nkaMiBGtO8su8VYkZMbt6A43upF3JbxJPK+WWEC36YMled6sjqEe1l7X8KjSrGbjvZfGq3rwJqWInc0uxoNIuhl/AQ3dDb1ylKJGdk0S2xyJVPEFJqhkYVxreMrBaXRgg83FR1xrdz0ASioGmf5U78V8mLD7XITMTY2KeU4+Cajp5ALoagvFdvqN1soPQvp0YHt0Rt8FdMnGSCozOVkxG7KN82NyCdHGQpG0aKqzAYA+2M1taBPmmcVThxBqYl9BQs+ThMw7mT2I6BDiNMGO/dQsY/nbQ2NoAKmoG8ONn4AihrwP35NjvaJk71Nxfe6De2eKtMWWVFuf563xuV+g/lFPGnOW+Y9TH50mgb3Xcq5ZdzHxV+HSm85PAh+yNZu9GekPx6eUbR12X8DN+yu5cGTAOi22hnafqkIQ1NO+h0y/TILuqlBAnum2RiPRyzGQE0SrVLUBuiCgoPcHL4igBtCEf8XFYC6AyKjCU6359Auxve2iSOtuBwRlBOPh+aO9g7ScCggXU8By2wlaIbNLRw8BgLNXTcOd5XKX3upvInFYQ7TXDqEJFNged/KpaT2ZG2AkG2q3WEkmhP5UtD+0/nzo6nyYJ57fgVP7FAT9HqtPJp/hxpm8RZ2nlMBFnAKYQNafObfUmcfV2I0vR0uMeqq4lmA6WAMa0wfI TKw/YsJn s9BvXquKRJU2fFHONTtPx/wsqXGnsieQrmKo5+rlNgFZTtcps+/JYI9gsUTfD/fwVWighQW62joEfPzekD3SLEocHnqEyiemZBu1xMg8frmEW6VygSiGyZ+w6mVjYyTAaPGXXW367aRb5YK0bAqCvlLtXRt2qInDtuzTANxhNGMZ+2L8a/eN7szWsTrIJ2NIw8aID3NVekO25iLyHpWCaVcSGjwxAv37DAKF1LS/6BCoZaDu40aVOSsrdkQhgl17Kor4HDCWduCJbSczUjGKkhIMhx1sEWy0SDNnFseeKxME0pyTtQbUr7/jQ897v7A7Epk0HtPorAjIMcBjI3jnhU0WdvVkv4yaAYMlg0iz7MTjV29bhtB070D7ycJ9iwz/9ATANf2fepGWQIsfXXeXHpKf2t19jccbibbCdmVUguwNCyNCQ+212M55BnY4dRaVR9Hemn618p20NXx+KVI5NJmf0CscW1QtrmO08+zQsm6pAjXtgH9bhVuFA9zabK7KBrw16KQ0WQI3TX5V6Fndy5l4Dif8S4phjvFdo5fPb9UR4808Ewv4V4bPnGMFIIdAyIEiVNScZKI6rwolVoPLepztPf2cvtLk2cAsqJZuAni0tfRM/xmzsn4KQBywdbzW1XwuEZAhYVx4jjBhCTePT7itUh1LFOylYeq+cjSAxZhFM5KnxybzcZnu3tgRpnT5ZuiKyPbLHckS6I2Mc5Ac8Vt+r+b+R6TYzgN8bSxNDvf3tn9vUwsvUXfRPAJF7VVHpsdi5C/ISRHB0xfpa4B5A5Q300mVvUxFiqMKT7bFotok/ii3UxIdXcuypuBO5xOMFlUpEtfQuXQBDy9IQn0RlMp6d5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 02 Apr 2024 01:03:26 -0700 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 317c7bc0ef03 Merge tag 'mmc-v6.9-rc1' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15fd40c5180000 > kernel config: https://syzkaller.appspot.com/x/.config?x=f64ec427e98bccd7 > dashboard link: https://syzkaller.appspot.com/bug?extid=9319a4268a640e26b72b > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-317c7bc0.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/efab473d72c0/vmlinux-317c7bc0.xz > kernel image: https://storage.googleapis.com/syzbot-assets/5ba3f56d362d/bzImage-317c7bc0.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 30105 at mm/memcontrol.c:865 __mod_memcg_lruvec_state+0x3fa/0x550 mm/memcontrol.c:865 > Modules linked in: > CPU: 0 PID: 30105 Comm: syz-executor.2 Not tainted 6.9.0-rc1-syzkaller-00178-g317c7bc0ef03 #0 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 > RIP: 0010:__mod_memcg_lruvec_state+0x3fa/0x550 mm/memcontrol.c:865 > Code: 45 85 e4 75 1d 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc b8 00 04 00 00 e9 80 fd ff ff 89 c6 e9 a0 fd ff ff 90 <0f> 0b 90 e9 a7 fc ff ff 48 c7 c7 18 43 e1 8f e8 32 51 f8 ff e9 5e > RSP: 0018:ffffc900034beef8 EFLAGS: 00010202 > RAX: 0000000000000292 RBX: 0000000000000001 RCX: 1ffffffff1fc2863 > RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff888024b92bc8 > RBP: ffff888024b92000 R08: 0000000000000005 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001 > R13: ffff88801c326000 R14: 0000000000000001 R15: ffff888024b92000 > FS: 00007f0811bf96c0(0000) GS:ffff88806b000000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000000000cfff1dd CR3: 000000003e4e2000 CR4: 0000000000350ef0 > DR0: 0000000000000031 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > __update_lru_size include/linux/mm_inline.h:47 [inline] > lru_gen_update_size include/linux/mm_inline.h:199 [inline] > lru_gen_add_folio+0x62d/0xe80 include/linux/mm_inline.h:262 > lruvec_add_folio include/linux/mm_inline.h:323 [inline] > lru_add_fn+0x3fc/0xd80 mm/swap.c:215 > folio_batch_move_lru+0x243/0x400 mm/swap.c:233 Well it beats me. I assume we failed to update for a new case. I'll toss this into -next to perhaps shed a bit of light. --- a/mm/memcontrol.c~__mod_memcg_lruvec_state-enhance-diagnostics +++ a/mm/memcontrol.c @@ -860,10 +860,12 @@ void __mod_memcg_lruvec_state(struct lru case NR_ANON_THPS: case NR_SHMEM_PMDMAPPED: case NR_FILE_PMDMAPPED: - WARN_ON_ONCE(!in_task()); + if (WARN_ON_ONCE(!in_task())) + pr_warn("stat item index: %d\n", idx); break; default: - VM_WARN_ON_IRQS_ENABLED(); + if (VM_WARN_ON_IRQS_ENABLED()) + pr_warn("stat item index: %d\n", idx); } } _