From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C10CD1288 for ; Wed, 3 Apr 2024 21:57:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C61266B0095; Wed, 3 Apr 2024 17:57:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C11506B0099; Wed, 3 Apr 2024 17:57:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00446B009A; Wed, 3 Apr 2024 17:57:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 96CA56B0095 for ; Wed, 3 Apr 2024 17:57:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 46B94C038C for ; Wed, 3 Apr 2024 21:57:27 +0000 (UTC) X-FDA: 81969582534.06.0C7241C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 586778000E for ; Wed, 3 Apr 2024 21:57:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="l9h/o02G"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712181445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2nkufhyA/xsWZQWxFBYmwJwlB7P2mmbJZdrcboKlE/w=; b=0EFnFl/dod6LnzRS0xLoOiVsh90tDgUf4d/Mx7rE7J00Ku6AF1PaQeBuXrH2ja7b+yqrh7 InRpULVZRHydzttsMOtWPT9Z3XYKlAuMPn2+BML84pO0FksXLvcDrXS1KBVeLI+byidf9d axCCZ/WvFRR7dD4Y92r9rhwwTHaT1rg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="l9h/o02G"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712181445; a=rsa-sha256; cv=none; b=FodmtlH30TMbpMTNxAMdoGG0+xXN6tpf7kV9/KiVOX1dUJBr9Wg4ZypNCVB9UnOKZL5be+ MEncXZrDWCKHcP/ktUbXzI8yq/GuRLn4cZJ4Uj0PyXJFiHaymkrXwl8ZCHfWlgdYcfKm4R aowfZ436SQ5BPP4UBHp9HFl30vNSdgo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id ACCF3CE2D00; Wed, 3 Apr 2024 21:57:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2CFAC433C7; Wed, 3 Apr 2024 21:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712181441; bh=swXtrHA3rER2QJ+fD07Evx50D4gtMpu+HnO1sa4c/EA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l9h/o02Ga244YGSNLzrpYM0UcrQRElwNL5U/5YHYYALTPPLZn9YgtrmeyMFLTeySb 3xxFIMHilLdG3rmPXE+wbgra/DXAXAqdSoHz4QM9t3LDsmWbSJ6Rk7zsPzVeaqQz15 9Z7DiM4D/Y0S1s0nkAwfZoQqJ65CSaIAx5SrRD/s= Date: Wed, 3 Apr 2024 14:57:19 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: sfr@canb.auug.org.au, kent.overstreet@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH 1/1] lib: do limited memory accounting for modules with ARCH_NEEDS_WEAK_PER_CPU Message-Id: <20240403145719.547d1083fede2cb4ca2c41ef@linux-foundation.org> In-Reply-To: <20240402180933.1663992-2-surenb@google.com> References: <20240402180933.1663992-1-surenb@google.com> <20240402180933.1663992-2-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 586778000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: iygfu1c5sabyy6w97e9k7zezf3oaqaa7 X-HE-Tag: 1712181444-541439 X-HE-Meta: U2FsdGVkX1/5yA7h8im4PEBp1tRdhIcuQy+vlL1c2UxD2zAyK84uz5Ipa9r7NrWptrpc7/MmEReZVjwJs96t2ENUhhhY+pPq5JXwOHBcFRo+sQ4imrwET5q+9luF3m0yhtOcpdgSzm1EjXP8itaMRjAR3Vw4B6sKyPLCIAD5KVMKzsnQy8pIzEx0X8XP5Ba3dpaw0pXv4bkTfsB5fsQ93B1dRSpsdIdi4jq8XxSB+0r3I8OwKqLv6Y3+JOkYvMT78DVbYek32zjqc3X1o+qGNP0TwqyUc9VrY1nKbVJ6c0/ad0p0J02nHwVuF1C7A1+I0ZtNBYMLUuBo21oO41W0vzHj9YXcLEhSZho05vyMLcXGxuLlu2nh060ngl/MYenJvhc7GUeErv63npXUDgp0W303o9pRN/j5ZSZKxc38dqKYNGeF485txAfldWGLSpF6pYyTkWn31NjtM+tWive7c1KFI5pt60Wkb7FEWphNCZ31GiUALDh54aM17TXXFjYnEykD8gDJlaXT+wgWYhcQHoQGYWJwdNB+6n7rfEgpA1RbnI3fOHCq49704LfI4LT6uqS66dbIUOMiT3gRE30s+mzajM9FrqVlArGJHG6451ulgDdZEtzJbpoa/oIKU+0l0RlJPamlCuOdcrlyDOa6Wjq8UQDcaF45m8j5V0/ClkYIktgjqPLibMPHALRrrySJErputHahp9l0her1t40e+DBz1s7FsF3CwVSzUfN9c7dX7mA7aAhMqu/TVyj9bb6rHNA55cEqxl0Zgbq6+m/TeOcpfuFiHO4tsuZpV6J7bFY6PPBrbsbQ3K+6tisfFi+MPQHuubvuHHz3C1u7eVkMPtXiil00H8A7/qHs6vQTjQWSCd4HqwTtzLTH/slHcG8wZilMfIkxnNCY1lonSjfQffJkVlXo9LxPOqZhDJhA0gwZGVjPawNlHuCqiZlQlPPzJlqxL1UEFmVvSwnj+0f 38P7EqZf RIBhk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Apr 2024 11:09:33 -0700 Suren Baghdasaryan wrote: > ARCH_NEEDS_WEAK_PER_CPU does not allow percpu variable definitions inside > a function, therefore memory allocation profiling can't use it. This > definition is used only for modules, so we still can account core kernel > allocations and for modules we can do limited allocation accounting by > charging all of them to a single counter. This is not ideal but better I'll queue this as a to-be-squashed fix against "lib: add allocation tagging support for memory allocation profiling", OK?