From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E07CD128A for ; Wed, 3 Apr 2024 12:08:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE03B6B0092; Wed, 3 Apr 2024 08:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D69DD6B0093; Wed, 3 Apr 2024 08:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBB796B0095; Wed, 3 Apr 2024 08:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 99F7B6B0092 for ; Wed, 3 Apr 2024 08:08:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 69B8F1C0F70 for ; Wed, 3 Apr 2024 12:08:49 +0000 (UTC) X-FDA: 81968099178.01.31555B6 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2092.outbound.protection.outlook.com [40.107.243.92]) by imf21.hostedemail.com (Postfix) with ESMTP id B3ECD1C0020 for ; Wed, 3 Apr 2024 12:08:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=nNh21PyA; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf21.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.92 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712146126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y36j+coR/veq+AhDz/Y+4pEbXQYKqpMkg02kmZ1Xx7w=; b=UYEhETrXoGq9/U65oxLzcMcN1jASs0giXE0X3XfMfwGsy6IKYFZ+E0xBCQfcfRzNwYG9aM SrK1ef13v7WqMXzAZZRsdFBzYdrJetYxxMc2duvindWg/RXfXaTAaWyA7QOwFntu2sp7FK gNzM38cKEB66Eq2501sHKZrIFGZ8hcA= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=nNh21PyA; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf21.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.92 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712146126; a=rsa-sha256; cv=pass; b=zWFRHGupWh9oh4C656BM3OcEVaSxfGKmRrXtMrdCzOYheRRP1vV0ISVvxJZWGOchJZbKrQ K1ODFrBrtNP6bkaSFFfx8NKC45PID1XCAYUinSl1+uB8Xe39WI+5P1r8vHAGAi699XAP6S 699R+tcQei3EoA7hq9F7VfxLmcZJAm0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mj6dg4NgXo2koQtkxJccWHqoD9exTFAZ7XqmMBHt2j6bzxzC9Fz+7Rv5redlgK8/FObJm573nkAHJzqj2moDyw90r0Gh6xYzND8Ny1fLsHtjJK88tN3CmRlxzdlhqswuK5DNc5PLmXQ66STFixqkFdqVgENTAaRYCyTWaU+m6bMvBOxo4Ze5/aif7N74JuJTT158/VJR9yLHE67SpilOVEkza2emlx+xz7lJzwcBUqlE85fpF+312HDjoYKwqHvxi0Q7Atg6ERfkyjPmDGo1IoQ/U173p38oJzmRmmZmOmjhXtz5qY15MWrjbtOdFoNWToe/zmOJnIpu8XIBn4/RRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y36j+coR/veq+AhDz/Y+4pEbXQYKqpMkg02kmZ1Xx7w=; b=MuUizv83Rhxn4VS4aGFUcHnpuSZ5s8NNyf27SZnbUoIPUK6a1uPchW0fNkLvc1rTBvbnpPLjWBBEqn4lGyN8Y3dfR+j+1RiSwncXEzeAkJf05NqdKRIC514YnmjxYfcklVoWr8o2GxrCEdrw9V0l+pJRnLslDRIMQe1FapX7ojNIU0sjpl8GOVth+o43U/B1TIRKKmyWbKGauZtcQW1spBQNs4Q/4pdIPOepBKiTgsx87P3j5FzC15JmYiL7yFMGop6z01U6G9TPBn83jY3s/bRav4NrrM7NeUOu+gJagu4ZKPtoZQkt2Uro3BP6g7BrXrh5lROCskvP7bvtpiROug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y36j+coR/veq+AhDz/Y+4pEbXQYKqpMkg02kmZ1Xx7w=; b=nNh21PyAgJxzCDOH2FGKmvSP/mLF96W2rtbne/m0oCpmtP94e9woHSJpUsOH+aemqUVMMuKDdIHs46WFpndxeR319vgq0bnSPY+S+2m1pGhI/ZTPlRwMha3SU0iUnw9SHTdzAYdAyvx0WCNQHkLaP+NSLwhwhM9kNnyazQnS5x1Tuca5sgdbM9qlKNG62RKORIx9Fa6g0lrkin+UPuHKbRZnMiVaCAnjj70H6QsINU7bnAp9KndAHHfnrzGgJOf4QETiaTfvXLdrP2owYTwc2A5OnXn3FpOFPIsa5LiQyWJWxiQMKg1RNNCaXf9juzVUBTxFraZCv3qcpVqzY/+/Bw== Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by DS7PR12MB8290.namprd12.prod.outlook.com (2603:10b6:8:d8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 12:08:43 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::6aec:dbca:a593:a222%5]) with mapi id 15.20.7409.042; Wed, 3 Apr 2024 12:08:42 +0000 Date: Wed, 3 Apr 2024 09:08:41 -0300 From: Jason Gunthorpe To: Peter Xu Cc: Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Mike Rapoport , Axel Rasmussen , Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback Message-ID: <20240403120841.GB1723999@nvidia.com> References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-6-peterx@redhat.com> <20240402190549.GA706730@dev-arch.thelio-3990X> <20240402225320.GU946323@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SN7PR18CA0020.namprd18.prod.outlook.com (2603:10b6:806:f3::14) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|DS7PR12MB8290:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7d5Drxicj9Ag1dwLcDuEFcEjNK03/mtTdDuPv/+0E+qGLHKkCQJoVH/u/CbZuPLrYXgRmrapnirIFA8LOIf+KAfaAtuQOakqev5oc5paMcTrbB/rWzX3wTWeHLi21/NKaXJG56APRAl510740g0mTHTr8lLMD85wWg+80d5g9NphVzfb1lRhqUjSx0yGfper/3RV/PE9Yli757VwRSQOiRFhsmuSxeBOhc5rL2FbEXL6yPixi4l4pBHb9Td0rJ4i4+z5UuoErAraZgnUcmcSY/x+oE6T0DpI3R63biiThXd+OzETp+/QitfdEg7LPguZHqORJ4D/xSxj95U9DW/yKRP8tTG08s0Qc5fxiRndmgbumhCzY6hiB+cuuxCWWFRI38RMXo1h+Ox+E2quJoahUCdFKzQ+7KJKetSkAySmrnEl4SkHeWQmEXpPR7YE+QyumqVEODAP75hTSuPRdIP72xftv+wcahF27t2thJOk/GC3oQxqD6YvOzDGHQFHLaJ375C+wLidEWxjwdBzadQxyGdkqLgMWfuW1OlavfEVWoq4CVLpmb5U6fKT6eBf93R/Md9TZJESBJVclwGwhJs5c7tIp6OSjrqjbIrLWk9ZOvKHN8rLN3eb98PH3xJVzCnUFQHsX1m/QLHklfgCyxpbhTFMNWbe57Ujtcu4rQ+99lc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(366007)(1800799015)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7dPeEXo85Anym/htRXm3/v05s5CWDH+IEgsNsIZxrBbSa8kn5SRwnvHx0zO3?= =?us-ascii?Q?BiHLYAXHNVH4310Zc0aQpo/IA53d5xwMcckgup+QMmBYdDiYTJI39SvTszdT?= =?us-ascii?Q?w4+SMkfeJ423XVaj8aWv4KY9fzYFLvV2BguAsBelaGL5yDUtPEsMewddwTpd?= =?us-ascii?Q?bAE39gwVqcHAcz5L4hi2ap8lmvPD0zfXBO3HY9lxTcey7RbJO9SPZ8BARaif?= =?us-ascii?Q?AaLTTChfm33lXZvRVq0aVLSpaizO5q8ONd1uLKApKp5cE+MktygcWLxJoP9U?= =?us-ascii?Q?48G1Cr71fX+pJ0dr9EskqPz34ZuogK6Ta3P1ZXlEccpDminsRkRi+OhYpkbz?= =?us-ascii?Q?enzlx6pmOLhXT94+xBfFiEjZg6TEVvMolza9Yx6fbdpki70z7CJL3OhWz3e/?= =?us-ascii?Q?qAugtbHR/UIQmCOY1Nv/TRB053aqNDQjefiu9Yuvlz18iLNXmXrk2Gtd4ZSi?= =?us-ascii?Q?aitrnwlZvae9Nv1wNyXYzZRNun7FsnPQz2OKFEt7F82FgWBSi4rz7yusGS0Y?= =?us-ascii?Q?dKEfLYuBpz4Rz1ZfeRNYBg4U0M3nLn2cjMN+k7u5TmgSK6lBbO/5spPPUqDA?= =?us-ascii?Q?ujD8wNlsxADVY1Tr+VCYGJa8v4kiMb9hq7VBbqfKUjgoHLgGydvvhi7ZVbHU?= =?us-ascii?Q?iLoE3PuBsWei1yEomJKltHn/eNYZxluK3IdA+8CBuAc9OGHPP45pig/hl9pn?= =?us-ascii?Q?AZoa0hOb5XMBhXJNrWL0CvRxTSLx5Q7tBtW04uznB1nn1jDphmqcWrjSkATz?= =?us-ascii?Q?acZZST9v14dXv4V/2OzPvIf2ijICE6Tvv8FomZXAIRPBT/64w07xtBLQkpsg?= =?us-ascii?Q?vL0BBbs675siQBIjCdJLm1m7hyraR+ObpFXPNmOgjRxaPC8liSnl9UQx72sM?= =?us-ascii?Q?OQtVEiKj+F9gBoyVHX/LlZqTdp67drsWz7yZaKrOJEa3AVZwpOKC9Jm95v9c?= =?us-ascii?Q?zCFqGnGIuZRVu/NYWCRk9v9dUflkdRz/dUCafujw0pqqWOdZZ87eGZ+vTsOT?= =?us-ascii?Q?aJiE2PDliDXjGbjKNbqMOIGgl+AQJbzPASFsccVZjVKIfeifRcwaq2qFwWkm?= =?us-ascii?Q?UCLQqw4ezq3R5C4awJ4PgiHUn13ZGJDFX+s4VEez9nX5VbfAVhnks6PnuEcA?= =?us-ascii?Q?FaWkkh0hqECLGPcwbnsowCKTAu5C4Jha2qyKoWWBhAQn0mBMgB46bqvGpgS/?= =?us-ascii?Q?ZTZKHixSfhL/U8OlgwTFeyrCe5xXkiV/tv1wPwmWo4HH8Q61yHeChKJ6R6pK?= =?us-ascii?Q?skCGyu+XeoNzd+mvvlts5zud8to0B2FKqMeoS5jeiEgi7Pi/JjGPTIFokTGt?= =?us-ascii?Q?0mhuOr0uOL0PRkESYaFn8u+ma29q0X+y8j9f90caka86CJLwhVXoj4oltS/i?= =?us-ascii?Q?7hajPSpTT/8wgTYcSmYioLVmgs1WGhBFFz0LPUMsn/7yOVHCshnJcg1tXmng?= =?us-ascii?Q?2SBXwnriXVc03Ow+KkTUNzeljeGL7W6zd25KiuC1XHWLuLdjCmaxTo9trLDs?= =?us-ascii?Q?SenWy/wo3Yx1Le+tIv4gae89tC501DynX8L60nzeZTKTDQ7KLXrqfrab1e2X?= =?us-ascii?Q?O3AG/VstJQkpQqp49tiE8dvlG1ySaio++uCogt3O?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce796d5-6291-4946-c6c0-08dc53d6ce35 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 12:08:42.8975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vcqeO8smnJ2yHXJiT4G/jEqlS6nSh+02kCcBY902wQMF8jp2DjJMB4trd+v+y+SW X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8290 X-Rspamd-Queue-Id: B3ECD1C0020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yu5xpznzubicoefkynn5rcgc6e3nn7bc X-HE-Tag: 1712146126-5685 X-HE-Meta: U2FsdGVkX1+ci7F2bZZSi0p0twhC/HKBl3DfyprbIu/HgickZZ6ptWG7jsdzEdzVTAyYrBOwO1u5+f4FEf5ctAIYV5GXGlGsVKwTO9pywgnJKav3M3jUsQE04vutg9Xp87nFKpkXGLshgs5hLYhKoMUQghrbu9G1uxAnJS+tCDv2EYXc+En58b0VKcoCqYRZj6F296K40OMCUVYEn97bIBVufoR1o46FRKyBtYHr07apFkWRzguQP2H1jYoeB6E15uIl3+bKmd7FSGoBv5iaPGWlmG2jWewI72MGDIIS+i1G79yQkFrkTQmJXf7aiaY7guo3j/8TAgiVJBI0/hO1MJnEI7xfcxotAGnqss+LrZaLFFnSsFubHLYWNnTFXTuBKhSI0nvZgz/pfzgBcT2bEnM3B9Veih2Hxt1QeyysmjbkhCXtVgq5qdqvZy+tjfWnfWw6yApsKQg8MGgmvKywJuGFKMpe9zm/DtYuJiwG1SI1HpTsE4kEtWOOZQXb1+oQOWPvTgToQ9UCVmobvuMKVsTSo2AnyJ/hF8GpF8uEbckFQc108H6W1kTHJ0a7gF3k+Km5fs2+/czTolELYj5tOyEVvzS07esHDHbyzycK9aAQ7/2IRdD9dR8ipqIKXjJFxiq1ew0ctIBoVWUUEiYmjCmAulKuwXTAUT/T1Ca0N4L3IoY2gBrEt30BgX25elSs2kzoBhJ0+W/PYEisHf5SDU3WDYNy48V4CgRON7z4XrJ0gHLl8Scuhq5zQr9vPO7PyRM5I15jbEa0gLt4AdXBbg66jisQbB8KLKvskBjatEsO7MAFmIRCvHcYlurdADJmLjlSf0rMBwWMehiPcsovs5JuhHIiKNh03w5UISkwweMkrvsK3o7lmTV3OK2J5uqfvVliWKsrqRsUrZwHO4gjmolLvfXNqoaFytw5p5LYT1BPdwjwid27LSukC4a0qV8kZYZiqOrl5xwbQgAFQ+u c+EVZuyy 6YRb1STEwEb1PZt30GuoFPS168SKDyAepXwmqxs5d1wBfs4RMwlOar12CLQVvF6ZCjU1P9gWDm7+2XVFhq5l8xvfF/pjIyd6dSK7jjDUjH+/HJ/oQmjBThP3dAAqeReEaXKf+gw9sK9tYNADVtKum8xha8o1sYzED5l+86V0SGliHY2YTEloNv/jkjMuhff6ZhBXxKXRbhSUOc8M/0vNODXFR3+QrGoUDoDQIa9wy80coy0l4FWDBNPusUbYH8Me7pkza5+0ETVivB00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 02, 2024 at 07:35:45PM -0400, Peter Xu wrote: > On Tue, Apr 02, 2024 at 07:53:20PM -0300, Jason Gunthorpe wrote: > > On Tue, Apr 02, 2024 at 06:43:56PM -0400, Peter Xu wrote: > > > > > I actually tested this without hitting the issue (even though I didn't > > > mention it in the cover letter..). I re-kicked the build test, it turns > > > out my "make alldefconfig" on loongarch will generate a config with both > > > HUGETLB=n && THP=n, while arch/loongarch/configs/loongson3_defconfig has > > > THP=y (which I assume was the one above build used). I didn't further > > > check how "make alldefconfig" generated the config; a bit surprising that > > > it didn't fetch from there. > > > > I suspect it is weird compiler variations.. Maybe something is not > > being inlined. > > > > > (and it also surprises me that this BUILD_BUG can trigger.. I used to try > > > triggering it elsewhere but failed..) > > > > As the pud_leaf() == FALSE should result in the BUILD_BUG never being > > called and the optimizer removing it. > > Good point, for some reason loongarch defined pud_leaf() without defining > pud_pfn(), which does look strange. > > #define pud_leaf(pud) ((pud_val(pud) & _PAGE_HUGE) != 0) > > But I noticed at least MIPS also does it.. Logically I think one arch > should define either none of both. Wow, this is definately an arch issue. You can't define pud_leaf() and not have a pud_pfn(). It makes no sense at all.. I'd say the BUILD_BUG has done it's job and found an issue, fix it by not defining pud_leaf? I don't see any calls to pud_leaf in loongarch at least Jason