From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1B8C6FD1F for ; Tue, 2 Apr 2024 10:17:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C34B96B0099; Tue, 2 Apr 2024 06:17:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE4E26B009B; Tue, 2 Apr 2024 06:17:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFB0C6B009C; Tue, 2 Apr 2024 06:17:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 93A976B0099 for ; Tue, 2 Apr 2024 06:17:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 295CB40B42 for ; Tue, 2 Apr 2024 10:17:18 +0000 (UTC) X-FDA: 81964189356.10.E7D6DB4 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf05.hostedemail.com (Postfix) with ESMTP id 25E69100002 for ; Tue, 2 Apr 2024 10:17:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712053035; a=rsa-sha256; cv=none; b=FkeO4dRcJgC/2+F0r6qMc1eieph8DZY2P/HlyYHW2Dw2oIgNOcK9pFM0SsTvoWVRpNTnob U2DZIADpEqAjHl7kQDIlQyZSjc/mMFYS600EYDPK5A7q8INIBemfHUP3VZVqDzxl6ik8w0 ZapaXG5ygMowZ20dWx8A8S9RrfgzJgE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712053035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ot2kOanyMxnz2vIwU34IXv5ETrtji830ofVhMMDL1wI=; b=8J482mKehoa15h6vueDndXyjqgm8YgHUPj5HSjRMHS+772M21jBMSyn0eOs6GUC4MNHXVF EFJd8M1amm1WmWU+RWonfV6FDhkZwYs9gpxA2K17991PkEFTvH3zQNCS4NVoIgDZSl01EC +TrwEBg5QR+TE5iiz5DJU9QGq43EEVw= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V83bQ4VC0z6K98F; Tue, 2 Apr 2024 18:12:34 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id AFD60140A87; Tue, 2 Apr 2024 18:17:10 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Apr 2024 11:17:09 +0100 Date: Tue, 2 Apr 2024 11:17:09 +0100 From: Jonathan Cameron To: Yazen Ghannam CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v7 12/12] memory: RAS2: Add memory RAS2 driver Message-ID: <20240402111709.0000653a@Huawei.com> In-Reply-To: <71d41ec9-17ed-442f-8d68-a6cb9bcbb4b0@amd.com> References: <20240223143723.1574-1-shiju.jose@huawei.com> <20240223143723.1574-13-shiju.jose@huawei.com> <71d41ec9-17ed-442f-8d68-a6cb9bcbb4b0@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 25E69100002 X-Stat-Signature: z763hryb4mrw6cmxymqeayh5b93giqdr X-HE-Tag: 1712053034-293132 X-HE-Meta: U2FsdGVkX1/ZgptrA6hB+vivQiNFqd4F2SDa0HOOUUfi6mlALMQyrC+jyWbKtriWEUZAARWVDPEIjh9LE3U0FGOD2kbvB9wra0EXbNzweF6MNj7OoxJhxeR5B47g8JHDB+0lQUmTw29bGxoNqkwpiIPaarH3Y223Sw4o/C/Z8d7yCsw00k/1gPzQVq7jWmeEm+PT0sEKXOFd/JrycJHzci7plhMuXUQDGfpMQsQnEgJmePXUDOgPt3YmnN99PSvB6FtVTyzHXSNcz/adLp8whbDLu+nXYIKgqeIKnuAau0lezSp3b5c7kp+hRlr00mxsMOSyQlz0O5DglGsldpm70w0pMH6j3EeyFoBDIvysZqnbtO9tVn5jL4sbRpdCzL4wbBSOgqgKEs7bYjlZZCdCQvmwVAf728y0WHgCP4rGcEbG41AzcTa5FAEtGrLoo0XKrY3JjM772OxuTJRXtuD/twhfJHi5cNErD3o/chSObr16MSbd9fnedpBg8aRAygUtdvN6ORxbabJJBxYAB5OuJmFAmD2tzpPm3ZQY5tnwW4YOro9BAlR3JJXsmKKDLdIpme4zP219kBpwyu08GQbn4mhq2FJxuwcp+9euTwXUPdchaNhb6+3zGlaBX9os7m6T/Iu6TVUt8HG2tJWXS1vbV0CMxS/bBpYv220dqO4l71CCNk1p9KwXUEdZyb8lC2dZKiUNrfk4wOXvdE2uHP+slI2mWiRE0QMhtPL4ca7Vb5F0K2e5NTJlUJxnYUKA5Ekll2i4zdNjNBP4UoebZrReP/fZAn9YR8HXp7Y7nzxVw3kV31hQzH0P9a52guH8ZAFQPy8mKaHvGKUQix4Y7sVE0UfRhpdFmLN8065vD9ycwQTQWviHKZ8gYIalJSKP5eOoFZ9T5wfL6TQZwbq2awp/8jXTEYNb5lbg9KyOGa4mWyUbMbrMfrJUgBBAFO1sqU8AVAEmLi3I16BMsbZezCD l4q6O/xr PJ0PLYQEcAnxPvPMUxgwCD0m2q7igiloMtH1+bKtCOoucMWahWzp08tSdhOy037JF1q5tfQem46QQFVILJ4Klmy6jgE5ymzJ5V3KKGshjdV35oEO4Lm1mO0+Yq1Ww6flTSNQaGmKGTDQtJMpHQv6TS2ZXFgFMg4OOTlV/Hwamskj2pTTyRQ/RXzgT41zv3eVmr2Rv6kbMXZv+leNU3dwRxkMw6TkhyL6fvwxxN5TzXhUfYLpdC8taf+pEIit8uOqqEBEdIRkyw0B+Kv4MyetLomdO+Z0bIiL8p1p9onqcnLOyqyEOyUd4NFU6bA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Mar 2024 11:23:38 -0400 Yazen Ghannam wrote: > On 2/23/2024 9:37 AM, shiju.jose@huawei.com wrote: > > From: Shiju Jose > >=20 > > Memory RAS2 driver binds to the platform device add by the ACPI RAS2 > > driver. > > Driver registers the PCC channel for communicating with the ACPI compli= ant > > platform that contains RAS2 command support in the hardware. > >=20 > > Add interface functions to support configuring the parameters of HW pat= rol > > scrubs in the system, which exposed to the kernel via the RAS2 and PCC, > > using the RAS2 commands. > >=20 > > Add support for RAS2 platform devices to register with scrub subsystem > > driver. This enables user to configure the parameters of HW patrol scru= bs, > > which exposed to the kernel via the RAS2 table, through the scrub sysfs > > attributes. > >=20 > > Open Question: > > Sysfs scrub control attribute "enable_background_scrub" is added for RA= S2, > > based on the feedback from Bill Schwartz > on v4 to enable/disable the background_scrubbing in the platform as def= ined in the > > =E2=80=9CConfigure Scrub Parameters [INPUT]=E2=80=9C field in RAS2 Tab= le 5.87: Parameter Block > > Structure for PATROL_SCRUB. > > Is it a right approach to support "enable_background_scrub" in the sysfs > > scrub control? > >=20 > > Signed-off-by: Shiju Jose > > --- > > drivers/memory/Kconfig | 14 ++ > > drivers/memory/Makefile | 2 + > > drivers/memory/ras2.c | 364 +++++++++++++++++++++++++++++++++++ > > drivers/memory/ras2_common.c | 282 +++++++++++++++++++++++++++ > > include/memory/ras2.h | 88 +++++++++ > > 5 files changed, 750 insertions(+) > > create mode 100644 drivers/memory/ras2.c > > create mode 100644 drivers/memory/ras2_common.c > > create mode 100755 include/memory/ras2.h > > =20 >=20 > Sorry if this was already covered, but why not put the common scrub and r= as2 > changes under /drivers/ras/? Hi Yazen Location / naming etc is definitely an open question. Given the OCP RAS API has repeatedly come up in discussions (and that has a much wider scope), a RAS focused location may well make sense + some renaming to avoid being memory scrub specific. Jonathan >=20 > Thanks, > Yazen