From: Barry Song <21cnbao@gmail.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org
Cc: david@redhat.com, willy@infradead.org, ryan.roberts@arm.com,
yosryahmed@google.com, hughd@google.com, hannes@cmpxchg.org,
surenb@google.com, xiang@kernel.org, yuzhao@google.com,
ying.huang@intel.com, chrisl@kernel.org, kasong@tencent.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com,
hanchuanhua@oppo.com, Barry Song <v-songbaohua@oppo.com>
Subject: [PATCH 2/4] mm: swap: make should_try_to_free_swap() support large-folio
Date: Tue, 2 Apr 2024 20:32:35 +1300 [thread overview]
Message-ID: <20240402073237.240995-3-21cnbao@gmail.com> (raw)
In-Reply-To: <20240402073237.240995-1-21cnbao@gmail.com>
From: Chuanhua Han <hanchuanhua@oppo.com>
The function should_try_to_free_swap() operates under the assumption that
swap-in always occurs at the normal page granularity, i.e., folio_nr_pages
= 1. However, in reality, for large folios, add_to_swap_cache() will
invoke folio_ref_add(folio, nr). To accommodate large folio swap-in,
this patch eliminates this assumption.
Signed-off-by: Chuanhua Han <hanchuanhua@oppo.com>
Co-developed-by: Barry Song <v-songbaohua@oppo.com>
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
Acked-by: Chris Li <chrisl@kernel.org>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index 010e7bb20d2b..f6377cc4c1ca 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3850,7 +3850,7 @@ static inline bool should_try_to_free_swap(struct folio *folio,
* reference only in case it's likely that we'll be the exlusive user.
*/
return (fault_flags & FAULT_FLAG_WRITE) && !folio_test_ksm(folio) &&
- folio_ref_count(folio) == 2;
+ folio_ref_count(folio) == (1 + folio_nr_pages(folio));
}
static vm_fault_t pte_marker_clear(struct vm_fault *vmf)
--
2.34.1
next prev parent reply other threads:[~2024-04-02 7:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 7:32 [PATCH 0/4] large folios swap-in: handle refault cases first Barry Song
2024-04-02 7:32 ` [PATCH 1/4] mm: swap: introduce swap_free_nr() for batched swap_free() Barry Song
2024-04-02 7:32 ` Barry Song [this message]
2024-04-02 7:32 ` [PATCH 3/4] mm: swap_pte_batch: add an output argument to reture if all swap entries are exclusive Barry Song
2024-04-02 7:32 ` [PATCH 4/4] mm: swap: entirely map large folios found in swapcache Barry Song
2024-04-07 2:24 ` Barry Song
2024-04-08 7:18 ` Huang, Ying
2024-04-08 7:27 ` Barry Song
2024-04-08 7:49 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402073237.240995-3-21cnbao@gmail.com \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hanchuanhua@oppo.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=v-songbaohua@oppo.com \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox