[akpm-mm:mm-unstable 262/270] vmscan.c:(.text+0x2c90): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here

[akpm-mm:mm-unstable 262/270] vmscan.c:(.text+0x2c90): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head:   0cef2c0a2a356137b170c3cb46cb9c1dd2ca3e6b
commit: 57fc2afac84efdb0968e028382023a937bb4d6a0 [262/270] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240331/202403311952.oxw8fSed-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240331/202403311952.oxw8fSed-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403311952.oxw8fSed-lkp@intel.com/

All errors (new ones prefixed by >>):

   or1k-linux-ld: mm/vmscan.o: in function `mt_find_alloc_memory_type':
>> vmscan.c:(.text+0x2c90): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here
   or1k-linux-ld: mm/vmscan.o: in function `mt_put_memory_types':
>> vmscan.c:(.text+0x2c98): multiple definition of `mt_put_memory_types'; kernel/sched/fair.o:fair.c:(.text+0x1dbc): first defined here
   or1k-linux-ld: mm/memory.o: in function `mt_find_alloc_memory_type':
   memory.c:(.text+0x1810): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here
   or1k-linux-ld: mm/memory.o: in function `mt_put_memory_types':
   memory.c:(.text+0x1818): multiple definition of `mt_put_memory_types'; kernel/sched/fair.o:fair.c:(.text+0x1dbc): first defined here
   or1k-linux-ld: mm/mprotect.o: in function `mt_find_alloc_memory_type':
   mprotect.c:(.text+0x0): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here
   or1k-linux-ld: mm/mprotect.o: in function `mt_put_memory_types':
   mprotect.c:(.text+0x8): multiple definition of `mt_put_memory_types'; kernel/sched/fair.o:fair.c:(.text+0x1dbc): first defined here

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-unstable 262/270] vmscan.c:(.text+0x2c90): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here

[Andrew Morton]

OK, thanks.  I'll drop

	Patch series "Improved Memory Tier Creation for CPUless NUMA Nodes", v9.

and shall await a v10.
 

Re: [External] Re: [akpm-mm:mm-unstable 262/270] vmscan.c:(.text+0x2c90): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here

[Ho-Ren (Jack) Chuang]

Hi Andrew,

Thank you. I'm trying to figure out the problem. Will send a V10 to fix this.

On Mon, Apr 1, 2024 at 11:20 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> OK, thanks.  I'll drop
>
>         Patch series "Improved Memory Tier Creation for CPUless NUMA Nodes", v9.
>
> and shall await a v10.
>


-- 
Best regards,
Ho-Ren (Jack) Chuang
莊賀任

Re: [External] Re: [akpm-mm:mm-unstable 262/270] vmscan.c:(.text+0x2c90): multiple definition of `mt_find_alloc_memory_type'; kernel/sched/fair.o:fair.c:(.text+0x1db4): first defined here

[Ho-Ren (Jack) Chuang]

Hi Andrew and SeongJae,

These compilation errors can be solved by adding `static inline` to
the two complaining functions, the same solution as SeongJae mentioned
earlier.

I've tested on my end as listed below and I will send out a V10 soon
after I check a few more things:
```
$ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/
[22:53:24] Configuring KUnit Kernel ...
[22:53:24] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=../kunit.out/ olddefconfig
Building with:
$ make ARCH=um O=../kunit.out/ --jobs=8
[22:53:30] Starting KUnit Kernel (1/1)...
[...snip...]
[22:53:37] [FAILED] alloc_size_kmalloc_const_test
[...snip...]
[22:53:37] [FAILED] alloc_size_vmalloc_const_test
[...snip...]
[22:53:37] [FAILED] alloc_size_kvmalloc_const_test
[...snip...]
[22:53:37] [FAILED] alloc_size_devm_kmalloc_const_test
[...snip...]
[22:53:37] Testing complete. Ran 306 tests: passed: 260, failed: 4, skipped: 42
[22:53:37] Failures: fortify.alloc_size_kmalloc_const_test,
fortify.alloc_size_vmalloc_const_test,
fortify.alloc_size_kvmalloc_const_test,
fortify.alloc_size_devm_kmalloc_const_test
[22:53:37] Elapsed time: 13.331s total, 0.003s configuring, 5.837s
building, 7.482s running
```

Btw, I noticed there are 4 failed. Please feel free to let me know if
any caused by my code.

Thanks,

On Mon, Apr 1, 2024 at 11:23 AM Ho-Ren (Jack) Chuang
<horenchuang@bytedance.com> wrote:
>
> Hi Andrew,
>
> Thank you. I'm trying to figure out the problem. Will send a V10 to fix this.
>
> On Mon, Apr 1, 2024 at 11:20 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > OK, thanks.  I'll drop
> >
> >         Patch series "Improved Memory Tier Creation for CPUless NUMA Nodes", v9.
> >
> > and shall await a v10.
> >
>
>
> --
> Best regards,
> Ho-Ren (Jack) Chuang
> 莊賀任



-- 
Best regards,
Ho-Ren (Jack) Chuang
莊賀任