From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7E4C47DD9 for ; Sat, 30 Mar 2024 09:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C52CD6B007B; Sat, 30 Mar 2024 05:12:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02D76B0082; Sat, 30 Mar 2024 05:12:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACA4B6B0083; Sat, 30 Mar 2024 05:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9062E6B007B for ; Sat, 30 Mar 2024 05:12:38 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3CC58C1221 for ; Sat, 30 Mar 2024 09:12:38 +0000 (UTC) X-FDA: 81953139996.01.DF1729C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 83E3F140006 for ; Sat, 30 Mar 2024 09:12:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Jc93oTzQ; spf=pass (imf26.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711789956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYex0pOiYy+WjATI+qkGCtrB8PeiJwe0PvQDd+QkJVs=; b=Ahba6RWfJjJdKQfdtMRN0gTVvi+LXwNb7cKJinHHHT/z+yq/XyiRfDR1RFnzGH6kxoB7Dm YGqq/raWgz6Y0Ly6pNxIWNKtdaM56LXnpOST/ibutMdrDmMwObkRXKI/g6zeEWX95QVbVt +cnSpDndAjWKE2N/nArKlI9BAszptUo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711789956; a=rsa-sha256; cv=none; b=jh2LRh7xJ/T0YLz9bAVongIEIEgy6FCi/3fLijEHpSNHKVZb4Y5zssnwh3rI/E/+C0a9G1 iz3vGj9/YzW8cpZAjmuguIPCYzCksc2JquxCSJpIbzP39ksqNNDTZLUueYYi/cGp1WXXlN BuHts6ORg6f8vkfY6mSdnxIXeU6Ik2I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Jc93oTzQ; spf=pass (imf26.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4A51560DCF; Sat, 30 Mar 2024 09:12:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48152C433F1; Sat, 30 Mar 2024 09:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711789955; bh=jzqu+nCzBGkiGSJEi1GM4Qmn/uIbNiavD6zRP6mXd0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jc93oTzQHnf/tqm8pAbU1d2/OQCtTzW4NWl1J7Oic+lZpNUfbKPSU9GgH560Q82Ec 7pZxeySC88QxynAxXjqdbbaH7iYjLncIuMgWKOoy/NlTeDhiZXX72B6/EuBDJ/n5mB hA2kyNsZ5wjA7ZdDWPe6Mcu69GxoX0YfmKZwtAmg= Date: Sat, 30 Mar 2024 10:12:31 +0100 From: Greg Kroah-Hartman To: Matthew Wilcox Cc: Liu Shixin , stable@vger.kernel.org, Andrew Morton , Sasha Levin , Dan Williams , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH stable-5.10] mm/memory-failure: fix an incorrect use of tail pages Message-ID: <2024033024-unusable-secret-6872@gregkh> References: <20240307124841.2838010-1-liushixin2@huawei.com> <026db58d-feea-8191-616a-3e6dca592786@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ai8788b6g51c6u6p7x4p97e7uwamtdih X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 83E3F140006 X-Rspam-User: X-HE-Tag: 1711789956-301026 X-HE-Meta: U2FsdGVkX1914rWHCUxZDib+I7K1QBud+P3g8XMZ/B233o0Hu+Bde2sUzrAGmvqca0oarwlTnckhshzx22+agdBjChh5wbB6QbvxrHB2y7H4l8Es6RweLGGgmWYiMUxv6QD6TAHGWT3j98RAzS2cx2U8shWaXMm4qqZrKMlpgC4ojQ+3g5lkVTSvAY36NdYLCd8ykX502GSr2lpBBV5rmtMvcbinsPl2R3ZZaMEpEIqFVG6uKgaAVZXpNTDjTWipCqIZbKNtYDMpMOek2ItCu/UTjSrd6UQct1D6RAUA5kRqNNXSV1fpYLDYqEdkbicWpnhO964K9ITnBQ6MIjrO2DtBU8y8ROmyPbDEn0CHuitx90++BuXw7mjvbqHs912Y5A0sNKdEfK8ByKic+5STGFGrREKcH5marao4herOBNLtbbos3jm+ZB9iqOiJNvtI9ohdxDyNKoTYW6cU3SoLijjWtkDNFOLt1U0J/DawxKUYOaR5hwOP9YB1+ojKhqjQDJdqToy+c77DGp0LnPjEAzmKCIeKl30pdr8gKs2R3+F+cGlElkyAwXy4y3VdDaVFeck4g9tzf9j1AYZ+inbsJWB4T2nUqPxjWpGOU1FXsUIaibw+DmL3Gu+ZuyoEnazZllDrpJwcqxJR79NH4yRjcs1aKS+Ikya9jqnPkwfS/yKa3mrBvsYBBD8pfPug5pz54ElJRECS+M7nbLBheJqi2o633UQg3LizCIXVDS1shrCBTXT6KSPrANWBx0wSidFqhVrJz39mcAD7DJvUboAaih3lDdZ/Mh1UyUfbNxrksIoif9sshk0KTf6D/uWv4KDT/ZvvSvdQfD7kgSBM5ftaRMxVWIFHH7VlYloBj4Q9UQUUwDCMwiV3Pmclm0EGR2KiOkvR/W54nqDtwkmw3TWGbndBZv9de8vSjMT5qXun0Ud1QxQIyoKnbFcrDD5pJh7z31jVp+j64pJwg4qyG0a tmUd1wFp 0DOqhvuUqJkSnG3oUP/OryE4Oh/gQ9bIfMGKe7FLPENnNFMjlOSCGAXpTBK5zp6PbxnX3ZcltvQVqqs1KBQ8Pb85vC5y2MBsXPL4JVX+E6eDJR7O53+dy5VLRFoEdwzGd+dQ43yiAzRN8+rx4tY/g3/WaQpq4KQuzPdgBgUSCNl906mHIhqWoAwXG5uLbZUOybOMPjCPSl/4m3w4slwVFp1PwKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 03:57:06AM +0000, Matthew Wilcox wrote: > On Mon, Mar 25, 2024 at 11:36:49AM +0800, Liu Shixin wrote: > > Hi, > > > > After backport commit c79c5a0a00a9 ("mm/memory-failure: check the mapcount of the precise page"), > > > > I got an error message as written on the patch. The problem can be fixed by the patch or just revert. > > > > Now I prefer to revert because I think it is related to folio and no impact in stable, or maybe I'm wrong. > > I checked out what is going wrong here, and Liu Shixin is correct. > > Commit c79c5a0a00a9 was incorrectly backported to v5.10 and > commit 70168fdc743b changees the page passed to try_to_unmap(). > It now passes the tail page, and should always have passed hpage. > Please apply the patch below to v5.10 (and any other trees that > c79c5a0a00a9 got backported to). All now queued up,t hanks. greg k-h