From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5DACD11DD for ; Thu, 28 Mar 2024 19:11:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C8416B0098; Thu, 28 Mar 2024 15:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07B586B0099; Thu, 28 Mar 2024 15:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E81E96B009A; Thu, 28 Mar 2024 15:11:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA5EB6B0098 for ; Thu, 28 Mar 2024 15:11:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 80A48C0E21 for ; Thu, 28 Mar 2024 19:11:13 +0000 (UTC) X-FDA: 81947390826.29.36D4C8E Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf27.hostedemail.com (Postfix) with ESMTP id 81A114001E for ; Thu, 28 Mar 2024 19:11:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Mmg7GS7D; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.167.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711653071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QYi3n+1dup0vmKpcwHd1ByrK/mila8jNJvnF9Ro8+/Y=; b=pKDJ08V78Qx5ILOk6bgXfqo92xjHUx13jxMlt0M595A8oNxutYqHk8i9seQtQldFIjoDW3 WxFZTXBOTw08qj9jZFKJzowtN+/LqpbQdkgALlZb/RwHcXCdKhAZd4zaf6HiIKeuGza6bA ihlOfUvR0tXlx3aHR6btGYzri84xCxI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711653071; a=rsa-sha256; cv=none; b=Kd+LVkBXgV5GT/h31q/9TB9Q/g26x/0eyjfJznrz2V9daRzV/DBPNVHUxjcmbbdkfbYEG+ js3XxvRhe07vQD5UVjtsWeQg5nWyNAEhTkH62I5pPEQ9bTNjOmqYQloRk8I2Aw+0E4LEPf 6fRLgW6wOt/6YIf/7Dkcp27vul+BJ/4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Mmg7GS7D; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.167.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3c38eced701so797431b6e.1 for ; Thu, 28 Mar 2024 12:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1711653070; x=1712257870; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QYi3n+1dup0vmKpcwHd1ByrK/mila8jNJvnF9Ro8+/Y=; b=Mmg7GS7DqQ/AVKXV55oQR+ZkMvS3tsX3qcSuKYMpxXR2hLVdn+8xChfipjv3A+f//X u1enQBc16Fs326jCxr5XO7tclPkkSldambfqL0Md+mEDt/TK6h5icp5Bucvxn886N8WR z1qQA9FYK/jPtjjQSfXX16+KwurWtRjN7isF6G4WfBuD1V7A0KOa2AXw0lWtgXO3Bp9w +MFYYx/ROaJVQV7lHAZBDsKl3NRIjiogsqR+AEi6r/9tXOCiSnCXCqq3kniu2M4D433o F/OB5ST3gSx5UEp8tb7+OCXn6koatZG8hFj60sPSi7zTQFEAJXSp6tlBQhjjlcNFFv7J W8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711653070; x=1712257870; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QYi3n+1dup0vmKpcwHd1ByrK/mila8jNJvnF9Ro8+/Y=; b=CQFxlAtYuRRLFfSuc7WwMudLViW0xICFnZFMJz1rFraL6No6fWEymCydIkiM2P80k6 82/CFPiXNK2uhtQ6TU30Qk0Mst97y4X8bsNWofN4vMFtvg3kemr+yZ478TGPpEhYJ1tj XIcFkDBPHX386iSKiJSadjB3tVHbZB5upPgTr2bRk9+IuNIW6FWHfxbkBk8lXAElFu42 YGrxpMPqPmcP/C/EBoTAcke4qsAq+lWSIJjvewk5xhDi3iIU3ZZGM48s/ZrxfyWHjj8z QubhWGRrJsil2+Ysbobpp+vucMP35hV8+pwFZd5ldlmlt+WI/o342MSnzBL7hV9Mt0pN oq3g== X-Forwarded-Encrypted: i=1; AJvYcCVQV3U3Azg2Sf0RvSdnz/J3aQ5NisH3U1gG82BgOzq9/zl5b+dv+3XI+Lamrp8AzDhUOWshLWUb0DJEOMlWj3FEFlA= X-Gm-Message-State: AOJu0YwqJ2ySX1wjej4X0jaqVJ19KuiA2siZJjT9DYiZXvXctdQt3x0G 5aTW5jzAMd+vgHiJAqnBH4S3hmS0PoEj0UIJnbu0DoX0BPNPKsH+VjB1lgp0SY8= X-Google-Smtp-Source: AGHT+IED6aKTx2u/XlyNAZMWz9pwnLPD+8mqkNcEiCkQXf6h24tspgZn3twTnL09ahR9madhXG75+g== X-Received: by 2002:a05:6808:4498:b0:3c3:cd7a:af8 with SMTP id eq24-20020a056808449800b003c3cd7a0af8mr234178oib.35.1711653070517; Thu, 28 Mar 2024 12:11:10 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:bb1f]) by smtp.gmail.com with ESMTPSA id eq16-20020a05622a5e1000b004316bafd1afsm869909qtb.3.2024.03.28.12.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:11:09 -0700 (PDT) Date: Thu, 28 Mar 2024 15:11:09 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled Message-ID: <20240328191109.GE7597@cmpxchg.org> References: <20240325235018.2028408-1-yosryahmed@google.com> <20240325235018.2028408-6-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325235018.2028408-6-yosryahmed@google.com> X-Stat-Signature: diiwppafnmc179z64sohgpzhamuq8d5y X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 81A114001E X-Rspam-User: X-HE-Tag: 1711653071-931619 X-HE-Meta: U2FsdGVkX1/5Nzzjp22tecWbB4f6e1UPAT7YNHC2QhO8+XISj73AinJf4/Auy3/R2CWS0wZtaikeA++7t7WP9Y2SDJdld0tEWVeMO5mHSd4Kz4hYrepw50vJuEdWneX5H+8DcyD0TMudcoUT7ttXTwwfXJmuftA7xBNhDeR1lEVPGqCPmyK7d5XBHuMBZ5nNKA+F0F6NXrdLvx+prV3MKqKfznek0Svr71iZwzMJd6UOmG1urioOCAevpCg6DViSe8vl/NWIESlsiENTrLUtCUFDqpIPyYLRkC14wYVND1oqDG2s4Hn8ywBNTobnuf5qx5ZkPvfGpRU/IbSCpOEbVze60jb5EN3dLz/i3ysByYkIN4u0tXaZfHPHTIFQZ4vU0elDB/J9ZkaQZyPP4rZL9APLnbUbFdMWaJwW1HUBof4zM3djV49qT8ufu3uJavRuik+2rtep5G54S5qK/OniUwZ51dvzol5as0T6pBeOpjmnGN4hGL0bFnj70TLsUNoBabWPdLeoLo+pOcx1vABxZhqZ8tOen82hINi8VIkKZhw+g0rdTiaAV8f/PqOyoveHO9ldP650CvW9vc22QY5Lsv3DBJvcvbLO5ZiOIywEP7sHHbudatgwSs70KE2pUh08HewuHSWR6U41qVKmx5QgHaxy0EFt6wZiX2G3jyJxaPXmK40XbVN67SHbIBQ9TrUg9EUg/RLt9j3DvpKx9g1bSmF63kkMeM7T15iqOcbaUXzBaB4jC8PUnBAnflkJlP+o3HdT3V/Ijy09GT1us0oiL1/Dt25JoKllhYgnIwUATbBXD8N6f5YvtbbLaWR2sLG7mn6r6KHcvE5xdIxC5LbEDtlb83ooNugAtlAw8z5P3SRucMeScNb6WPatgHsdk16UfyB2pM/RXf1CGNP4MxtEopa38raBF7g9KLShCOnBKoO6tvV0LELvwoN7V5lsbzwGOd6sBJAzjxnij8y6CXB Hw88yQPq ArvlQ2mg5wyPS4b+L8DWf2hR1Q21IEMEMW1tdkTRP5w+3rKszxpAiSnQ09+a+zpCSBsk6A4UY0YtkWUs+kYVbmIEU1rNAEF6nR7mfmsjBm99BCM8/CZUdmBdlr0LP0uw4TqL4Z5dRh6AMbOqD98MklOqCmLejJUV7BYeBwU0qNkMwWrIvGKPYogiEmMfrI3a5W0GfhOLd8hxT3uourXjfnXXGrB5gGQZxW8qlRXFB2ZayACsWYnIEFNKkc8EqdsI1xSKiv1tbrUdgOAbEhUGgldFdhviC55UvpgtSXpzRLYhBF+/NMZJgNT8sIOqAjvK/dhnrYXVB46cwCg+VD2QxOFQ/miEcac0MxsRjwYbwtb4Dw/BpESg12jzOpdBpQoUzxzb9Xd+SKC+39l43F6LoiXFe4WgdZBwXMuHjJPAG6Xu2Vns/mFX0NkVwMs04CmfOLdr80gzXCdCpRfrWsrpU+WHDvx7GSF0PkkRK2MoF7j0W0eb1UHcm7yXhuD2ojRSC1Jpbv4IBQLZq/xowmPws7zPGXthFJC0YCb40Baii5PhxwDDmZApLanvOAA2lRzx17/WpN4vjmmBHhaI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 11:50:13PM +0000, Yosry Ahmed wrote: > There is no logical reason to refuse storing same-filled pages more > efficiently and opt for compression. Remove the userspace knob. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner I also think the non_same_filled_pages_enabled option should go away. Both of these tunables are pretty bizarre.