From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BDACD11DD for ; Thu, 28 Mar 2024 16:38:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16BE26B00C3; Thu, 28 Mar 2024 12:38:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11C816B00C5; Thu, 28 Mar 2024 12:38:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFFD16B00C6; Thu, 28 Mar 2024 12:38:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE88D6B00C3 for ; Thu, 28 Mar 2024 12:38:50 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9364E40E90 for ; Thu, 28 Mar 2024 16:38:50 +0000 (UTC) X-FDA: 81947006820.27.AD216F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id CA51B120017 for ; Thu, 28 Mar 2024 16:38:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpJmKHxV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711643928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3fwXy5U2z+oy82+iSz42Pbn48a/yMNGGfWVYA/FiX5g=; b=idHZMaoWfmN7wGtoDuc3pmP4JJpz/SCrSGfQI9p954xsqdNHaByoXdUxm8a/pXk4Il06Ou uVWB7eDwVPzE/P6WX9BihTINsObTcGo/KgQf5+uzzvm1acIMEfaUmgwwE8VhQLjBqznPV7 fBhrkrzX1rlnh30N93ySDTwSmdgy6r0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpJmKHxV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711643929; a=rsa-sha256; cv=none; b=YJDA1PFtla1TyAC4T5B6kH42iNScbPztqZ41wMn41e6J9NkeIwDg/aE8wDXppz0Tm8wnlF IelsYkRmPU0wm5GMd6UzZ+I5KsCOXqq/UKS++bIsMh1Q7rpI9JmCULiqpMw+6aDjCGSjNp 88pCfkzbIfNcchkvjN1tnWwX1BUbf6s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711643928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3fwXy5U2z+oy82+iSz42Pbn48a/yMNGGfWVYA/FiX5g=; b=IpJmKHxVp/sGViaYg2SN35STdocApHaNTOL5sqw50LoG5mEDOGD17GQneOKOFX4fmjh6aP Elo8qDe+6yuuA7mhrXOKY5p0aUWYG4leQ0Zi5acIIaFUo9rLAHf4bSpPwehn6Fx3f84PI+ QYZg9ooobSvPMBgzcxMWdjVPehFIoRw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-QGlJapH-OIS5gE1sBxbDog-1; Thu, 28 Mar 2024 12:38:42 -0400 X-MC-Unique: QGlJapH-OIS5gE1sBxbDog-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF59780C799; Thu, 28 Mar 2024 16:38:39 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 900352166AF5; Thu, 28 Mar 2024 16:38:36 +0000 (UTC) From: David Howells To: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet Cc: David Howells , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 22/26] netfs, cachefiles: Implement helpers for new write code Date: Thu, 28 Mar 2024 16:34:14 +0000 Message-ID: <20240328163424.2781320-23-dhowells@redhat.com> In-Reply-To: <20240328163424.2781320-1-dhowells@redhat.com> References: <20240328163424.2781320-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CA51B120017 X-Stat-Signature: kbapkuubsemqowpu4k7tixn4gf5wttoj X-Rspam-User: X-HE-Tag: 1711643928-261143 X-HE-Meta: U2FsdGVkX19wXS13p86eQcVbRJNHjr9LeInJDweWQ0bIiEvajS/N4fCXamFW9ezqRB3TPTr2WYvVOCYPDnCNrDuaN/bs0Ux9ZLBbexo+ttkxABj9muwsa/zNG1wVvj5eIuKZt411hYb6HXr9n3iH5XhMKQ/kYosc2lZuqafTnAH/5evQy+l10u4Rit0MZ4jtwNmheMl1SpE4+tcuLwvWo3cJJ1kfSOjNvo1/WBBKB3edqizbG4QXP4IC/bL+h4QTK+he1O7e9vxd5t233YBvsPYym5zMns98yo/Zbk7XSRpm4uR4tOzoW7FmtIcuWryiSErEY4AzN8KpP8XUvMcGWfdOzi720rjLr6P0Xb7l5PF/uiUb0xTfflO0dHEO2GamxmJBFrpDZqqDQIvUlSjCG/V7vIFhxD1X0AvV4yR/QB8w6tgUhtImsbKz8nDdJdmpN2aUp5m8CqLFZwtj66vse9yasOVKkSxsqNG/CbcCBrEy3obwjDm/KZrd7hMs5jtb4fhitWyKGQ+DFoIff0o2J9qaHJbvF322Nqe8eboGIQEzKvmBSqLiEJFQgKlAV7ydgHUW5AkiwP8BMHpVdGK8OPxdyX4yD98wcZnV2fOEH2TOxGhzkaoElxtWQaRtyyRGaSI1z5onXlUN+TWMbm6tpfNIowL1b/5Aa83DN9LstJE8pIZ7vbiONQM82AMm8DrjoCNnyQ8jmA0JID2f00uLyQlXxqnWDFUDewONCQ+VcCw6LgJKlJq+lrIpIr7gwBUW5UToBrCcgEM7DM4AdKkpGZ/5dOChCvw6mG8PIQnxuO2G4Ko2mt0gAwJUL1zH3ra0M2CM1D52X9Qi2/VDHj8Hlu+47ACaegztEnqckOdi1ZdGZx9kCBHid7pgbO/UUqFPiCWihBMr55wnKytGFzwc2etG5remVxgyQLJErTSann422JDLHJu300LUQGleh6+xRpaVxHq4e6nohhfZDze 6TffPVVJ WC2J+jmTKKIxVNecXWMa6iKmyNs2xvhjV3mX1UlYnmThTsu3LE1/tyymzD+cOATtILzcPIMWVQd+QLwkvgoc9fqyWoq9TZystmoRLW8gJdfZGeWuDLm7p5iwssi02mXs492eZBRSAB7bRzXCs6QUytNHqlpFkmd6j2yx0LsG3eA04cy5OyH/IFFkVu6ruy3eoRyLyRva3JPIQsuF8XdeKoeaKBWeE9GHZzRuTdtR1+nLr8JIB2HWrJzyG+qywPQVziy13uwktX0V0nIOm0h+yH+mv5nkKZo8Rv4tZBFn02n1ZVtEXfaWmXpE025shSmDMt0O9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement the helpers for the new write code in cachefiles. There's now an optional ->prepare_write() that allows the filesystem to set the parameters for the next write, such as maximum size and maximum segment count, and an ->issue_write() that is called to initiate an (asynchronous) write operation. Signed-off-by: David Howells cc: Jeff Layton cc: netfs@lists.linux.dev cc: linux-erofs@lists.ozlabs.org cc: linux-fsdevel@vger.kernel.org --- fs/cachefiles/io.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/fs/cachefiles/io.c b/fs/cachefiles/io.c index 5ba5c7814fe4..437b24b0fd1c 100644 --- a/fs/cachefiles/io.c +++ b/fs/cachefiles/io.c @@ -622,6 +622,77 @@ static int cachefiles_prepare_write(struct netfs_cache_resources *cres, return ret; } +static void cachefiles_prepare_write_subreq(struct netfs_io_subrequest *subreq) +{ + struct netfs_io_request *wreq = subreq->rreq; + struct netfs_cache_resources *cres = &wreq->cache_resources; + + _enter("W=%x[%x] %llx", wreq->debug_id, subreq->debug_index, subreq->start); + + subreq->max_len = ULONG_MAX; + subreq->max_nr_segs = BIO_MAX_VECS; + + if (!cachefiles_cres_file(cres)) { + if (!fscache_wait_for_operation(cres, FSCACHE_WANT_WRITE)) + return netfs_prepare_write_failed(subreq); + if (!cachefiles_cres_file(cres)) + return netfs_prepare_write_failed(subreq); + } +} + +static void cachefiles_issue_write(struct netfs_io_subrequest *subreq) +{ + struct netfs_io_request *wreq = subreq->rreq; + struct netfs_cache_resources *cres = &wreq->cache_resources; + struct cachefiles_object *object = cachefiles_cres_object(cres); + struct cachefiles_cache *cache = object->volume->cache; + const struct cred *saved_cred; + size_t off, pre, post, len = subreq->len; + loff_t start = subreq->start; + int ret; + + _enter("W=%x[%x] %llx-%llx", + wreq->debug_id, subreq->debug_index, start, start + len - 1); + + /* We need to start on the cache granularity boundary */ + off = start & (CACHEFILES_DIO_BLOCK_SIZE - 1); + if (off) { + pre = CACHEFILES_DIO_BLOCK_SIZE - off; + if (pre >= len) { + netfs_write_subrequest_terminated(subreq, len, false); + return; + } + subreq->transferred += pre; + start += pre; + len -= pre; + iov_iter_advance(&subreq->io_iter, pre); + } + + /* We also need to end on the cache granularity boundary */ + post = len & (CACHEFILES_DIO_BLOCK_SIZE - 1); + if (post) { + len -= post; + if (len == 0) { + netfs_write_subrequest_terminated(subreq, post, false); + return; + } + iov_iter_truncate(&subreq->io_iter, len); + } + + cachefiles_begin_secure(cache, &saved_cred); + ret = __cachefiles_prepare_write(object, cachefiles_cres_file(cres), + &start, &len, len, true); + cachefiles_end_secure(cache, saved_cred); + if (ret < 0) { + netfs_write_subrequest_terminated(subreq, ret, false); + return; + } + + cachefiles_write(&subreq->rreq->cache_resources, + subreq->start, &subreq->io_iter, + netfs_write_subrequest_terminated, subreq); +} + /* * Clean up an operation. */ @@ -638,8 +709,10 @@ static const struct netfs_cache_ops cachefiles_netfs_cache_ops = { .end_operation = cachefiles_end_operation, .read = cachefiles_read, .write = cachefiles_write, + .issue_write = cachefiles_issue_write, .prepare_read = cachefiles_prepare_read, .prepare_write = cachefiles_prepare_write, + .prepare_write_subreq = cachefiles_prepare_write_subreq, .prepare_ondemand_read = cachefiles_prepare_ondemand_read, .query_occupancy = cachefiles_query_occupancy, };