From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20E3CD11DF for ; Thu, 28 Mar 2024 19:23:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345FD6B0096; Thu, 28 Mar 2024 15:23:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FF386B0099; Thu, 28 Mar 2024 15:23:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E4E86B009A; Thu, 28 Mar 2024 15:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0690B6B0096 for ; Thu, 28 Mar 2024 15:23:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 734DF14011A for ; Thu, 28 Mar 2024 19:23:56 +0000 (UTC) X-FDA: 81947422872.10.C69223B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 7C549140006 for ; Thu, 28 Mar 2024 19:23:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="FMMm7I/L"; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711653834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JzBS+/xVvFDhcJN1h5hnPEsa2ynBSFaXeLo5f0WBMPU=; b=hhrVYc4X3l4qOmw3k2byIKzs3ct3HneX7H11883H02j0vzmVTq8tVnhpu7kruKE1rLy8Op 1Y/T6HiTceqCvzaCA9UZlJEGfmqJ7ajvQjSXFBKgKmjuNY7kNHlbt/F+AgWbo4lZ1FyFDS kQNZmJHhylsgLXe1sJQYBc8i0dqKDs0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="FMMm7I/L"; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711653834; a=rsa-sha256; cv=none; b=SXwQ7GH0NdxLkhbqiZahnsi9QR5m46G+K2MVRCHmTjxZFHg+m2X2rI9frPa2xfNcRsLeH+ /ZO8MIxtGdC9LfLsaJS2SW56XXGLwD8fxXqJ9RVnK9cjTmDeT46oIwpDsOKlnOIltb3qCi VT3zCYmz2H/GiFzfZxZ3kvhbkLe6+68= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7297E61866; Thu, 28 Mar 2024 19:23:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA7B6C433F1; Thu, 28 Mar 2024 19:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711653833; bh=tcx4rokV5inKUefW+ngsLLPSFNOMgp1ujfya8z+v1X8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FMMm7I/LQg14E2kZhWOtK7FkrhQk+qoShv1oMXBR+paFWvhtwpW3zLjaZpIzuUIls QfYEDIGkonhzH9jI8vLznzLfSLepKnYGheW6f0U+k3Ni0dvIk8xoCe7WJE5s/GA/vc S8Yf+QpIbH6vM0GdO5Qz6qH/vF/Kq/3ei4Bmwd2E= Date: Thu, 28 Mar 2024 12:23:52 -0700 From: Andrew Morton To: Kent Overstreet Cc: Kemeng Shi , willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-Id: <20240328122352.a001a56aed97b01ac5931998@linux-foundation.org> In-Reply-To: References: <20240327155751.3536-1-shikemeng@huaweicloud.com> <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7C549140006 X-Rspam-User: X-Stat-Signature: fy867ufhdib415rb59ar5nffi8nad94p X-Rspamd-Server: rspam01 X-HE-Tag: 1711653834-547908 X-HE-Meta: U2FsdGVkX1/HnNsvXSc0UcFGgUhBLO5vHPADT6mtO4YqcxZa5fViCqkp/41MYjheiXCPBzt/afLazSXXSlS3jovGJqtXg4p0LHsyH/ayQMuR3thomJThhfD/0G3FYa1WvgiDcNgw52FtayHN0M7MkAUoxGJhRrWMcYztVgd4Q5L7+CGC82wAV+BmNaQFzYGrGJedP9ts8SjS2WofQVKhEuJylaP9Z+e/j7uvShPXYqQvWkU8iyHEm6v5iHQhoe5V35ea+eJIB5Pq27jWS1mZj6CmE4BDt4k0/GHCvwuNV5mxAi0IZPv6FZHbl8y/27FGj2r50VT0ZMLFa/EqPHp46gAVdVHEy7QKnheax7oiM+0J4bRW8od5pMtsMOp7d2cpVn5nb4VydNv7C0aJakSYugwqjZkpsvU/TfoXkQTnWRAm193mlPYvb1AzW3OfQg2aWlwRDO4wGDvioujNxjt6lbcTPNtVrrOqI13zXD7i1udQ3voRs6APBvwx+oP4Hy+3hzQs/69CQZ/e3l7CBsFol7hgK/xO5JFsF0rI+TJnFzg50p2mUnJ6L1vrxn/iH1OjL4EjLEJ3Aa3Q6GqfWTdYs/E4ouuFR6LXJiKGlB6fSsvKCHIyJTA4ZppFFE3UcIeqMnAv37AQpOASQfFNHpA+EBa03ClgJeNS/2n6qYW1S9KMI/GHAmrQZ07SoG6+arvXZUIQ/f5Zlg7EyAU4IU285hzQjlr4xoHUwM/uTSpkq3xjB2eSZuF2qPNPTr3219EAON0Gb40H5Yhs31O8jzPR7cp+y+BcUVCOthAqYuF6JiE9OrpS2cX05a7pSyvnGMopRnnaGClunfdNQ/fJ9AW250R4527ait2yBOPjfJLwLPkKXvGSU77Rbi9LHFBLu4RSbtv2RkYu5KBiw5siqetJZcofQWL+r51+CZevWM6TiaG2ZgYU9rSpl/FVh5QenvqyR5UH2Eni/hJYGeaDbTO dRYy7h8K EEf4p07S+N0WZSpCVQJpayw1fcPbJPuGGhnv833Dap0l8dXpq4LByxopgwFCTCiQPBPfT39agGmgriQOjycTjfyKS3wkaDlkZrZHGycPWV7Fa3r+QWDAQtz0mtRWO9udt0TTMG38le5BbJLxNFnE75b9YLyjX/afZUN39kztu9mEBUjZ84S2dJGsm7K6Ke72PEQmNP5yVBjM2oxbZofN+mArgpx4bhsNz/RfFeG6JIwE/48i1t57v6COezcqDaKTeO51TjVlHLrl/rh/2GQ/zPYLD12A82N8SjiOc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Mar 2024 15:15:03 -0400 Kent Overstreet wrote: > On Wed, Mar 27, 2024 at 10:40:10AM -0700, Andrew Morton wrote: > > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > > > > > This series tries to improve visilibity of writeback. > > > > Well... why? Is anyone usefully using the existing instrumentation? > > What is to be gained by expanding it further? What is the case for > > adding this code? > > > > I don't recall hearing of anyone using the existing debug > > instrumentation so perhaps we should remove it! > > Remove debug instrumentation!? Surely you just? Absolutely not. Any code in the kernel should have ongoing justification for remaining there. If no such justification exists, out it goes.