From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32981CD11DF for ; Thu, 28 Mar 2024 19:01:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94B306B008A; Thu, 28 Mar 2024 15:01:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D31F6B0092; Thu, 28 Mar 2024 15:01:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 774FA6B0095; Thu, 28 Mar 2024 15:01:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5BDE66B008A for ; Thu, 28 Mar 2024 15:01:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B85B9140D22 for ; Thu, 28 Mar 2024 19:01:48 +0000 (UTC) X-FDA: 81947367096.21.6F59254 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 541CDC0019 for ; Thu, 28 Mar 2024 19:01:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EuRHhQSu; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711652505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LzHJvfogbnZ7V35IfKtne+N2aEzgKrna74HazkohkkY=; b=0+17RAGUevhfac1uB9SqFmj1bTWBP0CbLY8mhPbij7o+xuuMJMCxgJv3IyGlq5zMu4GCuD 457PGcs6dmGXloUKaCsp9K296RbV6H0+vXrAYzGL1J8HcTFwoaulpmS8aNaOL7qaCu14oS 2v7H73s7ncl2PBWqj13WEh3JmXEJNvc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EuRHhQSu; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711652505; a=rsa-sha256; cv=none; b=7Gd3ouY/NssiZj9FS9uoFPGxXAPdb1GMV72iyR1T2u3S0YzMxYQocSLn1maYFcsRqNFu6s Imj2rkLfFX8+O3MushZH1tknnXqoLQXGTbOjaCiVL+BkG/PICYxbBmw/vGMg2gGxV8qyz3 KUQibwqXtCbQUgI72vBn+BbiGGeAOYA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F050A61851; Thu, 28 Mar 2024 19:01:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F78C433F1; Thu, 28 Mar 2024 19:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711652503; bh=75zJQi6/t8Bugee7Y/WvYhL+nXJNnuKScwY0EXrSoes=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EuRHhQSuhT6UhLje68IlwmCQqCGilcULpK7LoI7ffKimNB38kuwasGAwdmey5M3bK w76Dbmfxu5cMJPhJmPKXGTUSaluFio9ZuNxZZjD9m62mGWpZNm0O1s3PHo4jeQl/xU PchmtkI3nAt7scT0o5FtyP+3XAlYHJwqdV8wlpBc= Date: Thu, 28 Mar 2024 12:01:42 -0700 From: Andrew Morton To: David Hildenbrand Cc: peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: Re: [PATCH v4 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-Id: <20240328120142.32c6676dc7fbf1af82da5e58@linux-foundation.org> In-Reply-To: <372a9331-6d95-4083-9a8f-a4f714868bea@redhat.com> References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-7-peterx@redhat.com> <372a9331-6d95-4083-9a8f-a4f714868bea@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 541CDC0019 X-Stat-Signature: 4aca9kak1t4wumj5y4gpk1x7g5dowrrz X-Rspam-User: X-HE-Tag: 1711652504-722278 X-HE-Meta: U2FsdGVkX1+uAo8irQPP6XngXAsBrLUwyx5Qfh3XzI7VicQ905gDmTGx1LK/oloB8zhZ8+HrjZw3aVUjouI4loV03HicSx6NVuE6DQprv4oLSOM4dA92hJroVWemSQu95a2V9ArCvFanwFH3RMlZmSoi91FUSPSLpUkxJM5g2GlfiG3bqSFgU2IMCSFm9+jO/Hxkvf51th20EO4MYRdTrwFIVhaqvN7ahDevJfxHapYPJCEuyw7vzcMy0CSp/QYWyy3b/ZvuVixmNBv/TYpgjzRUf67+q/XqeIC+eoTeE/CXTRzYqOnVDrNxxknrKBREcL7f5FpPIVyoUn3/Fv5e7v4nIdYvPzKsnsUhJHvngFXCV3WgNW2DiI1FWVtEy42uJRVthttv7dFp/f40KvIUjwlQe2HmIQ6lcxGjikbgOI+3R44O5Or315XXJ1DygXreFQIZBgAsnjGbA/yRdmKGHiNCSZ9CvQKhzeziTp/LjPs9vDgdvsTcgFU24498ASCi235spaMKmpDP774G3DzJeYpMJJxh49dj+3m/w//GfkTXkWSU8rmBvI7MqbSx3OvlpL4/eXL/WGUh/NoJ0vq/uMmoZTN4Obe+ahV3N23NMVdM0/dfy1BF+2bqVppg6umG9pedL9MUGpbvAaNdFfyy5oTv7g2htK0PHlhy6K33pwkfJLo+7+g/SVr5iBeYNm9eU5RAXjnjRB4th428SEYjnAZRhM5/y42xhpyWpzgKC5tQq90OJnQ5OA48ptHip17NNIS/t4C9tymWDJVnciqPLGQtontkIa7H0v51eOdCPeuRod8PSTlN0BVi/kAebpuMl2B8aprHkb4/MhtX+ErkaDU6DSemEnqRJTCoXgJwcRw6cXzkFFRfOZSLN06+kXmqiQwL7MfYqoBne0rJfCa1I+rTvFO3CmmKwh4h1tigN/BYyLqYLQAzv7dXG6QwJvydEn6Bl7PNVprOHqu+k2O fsKZ9Jvb hPCyZzIr1TK8bDCM+VF10qXrFLbWXawEwWzgtVTSKH7IPmQnDadwP6CrDufMMQsesAGZAjgQbry3BJgYj5ylzq51QIqNFsjFXh/DP3IzD1ULJXfRcfOx7cvZmUEy/z8LrCY0hCTESeMbjesO4T7gWRwZEyZZCvTFUm3Z1tv/fA/w+eeIMVnBVLv8xY0JR0tg9o3EODSR/LkjEvsMAqznDAM8qRQ+iE3a6A3BvTIxtpB+kJqZJ0Nj6Apx1hjKPwvCImPGbhpuxeaJtQkX676v8XLq1QdqHVvWD+qb7e+Oy6wO66oE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Mar 2024 11:10:59 +0100 David Hildenbrand wrote: > @Andrew, you properly adjusted the code to remove the > gup_fast_folio_allowed() call instead of the folio_fast_pin_allowed() > call, but > > (1) the commit subject > (2) comment for gup_huge_pd() > > Still mention folio_fast_pin_allowed(). > > The patch "mm/gup: handle hugepd for follow_page()" then moves that > (outdated) comment. OK, thanks, I fixed all that up.