From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73931CD11DF for ; Thu, 28 Mar 2024 18:46:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D6726B0089; Thu, 28 Mar 2024 14:46:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05F296B008A; Thu, 28 Mar 2024 14:46:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1BB66B008C; Thu, 28 Mar 2024 14:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C076B6B0089 for ; Thu, 28 Mar 2024 14:46:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 88423A0B43 for ; Thu, 28 Mar 2024 18:46:19 +0000 (UTC) X-FDA: 81947328078.14.EC1FFED Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 6A1F712000C for ; Thu, 28 Mar 2024 18:46:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LdHR18D+; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711651578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JLmNHneVTccBuH89Q21rSlSXSR0gCPVh/+/67Hf4jKk=; b=oRBDwR9iRcrJVEDSiQE+tcAi6Ek+t2/qt9ce7yEBpovVUt6Pd220Dhrg7GuHaQExLIZc0L nsIa0hto3zs8rqDJGM5kSKK3QnKnw1PIxs9WgFjgP/f57LSTVaGMrKgzzaiUTL88Bmmh4R N+ghThY8t3yYjVtuFDtTMivuPbZld8U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711651578; a=rsa-sha256; cv=none; b=e+G/McjCfzB5nPDZ5Dw+gcDn2puJC1kFqtcqk6XMCjiOxHykmhfhHNGXavsOfrowUUt7NM pvINBAO3ojmcpZOjwNAy7p0yDQI6lPglgiHm0d+IdxSU1+Pl5J/htCXZzA/EuKZz2NnUrM UYgUYrP6mM46amnOOtg3PFHBecHgcpI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LdHR18D+; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D14ABCE102A; Thu, 28 Mar 2024 18:46:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5C88C433C7; Thu, 28 Mar 2024 18:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711651573; bh=r9sPgfprQr4ss5yOQRQ+LuOkNETi9+8h/ITL1cLkamo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LdHR18D+vl35xAZ8PoRaL+NhkViGAemYSCiROgu6PEwl0+nyTZD+42wut061xBmeC 6g3Ztc66LxXtoLnUUmXABlSFwF7Rg/ZXKi64ykyqyE41OcycuD1HdN2mGC9rnwiLv2 /isOduoShBIG+Ej4piZULRL6sIyoxXagFJqs7eGY= Date: Thu, 28 Mar 2024 11:46:12 -0700 From: Andrew Morton To: Naresh Kamboju Cc: open list , lkft-triage@lists.linaro.org, linux-mm , Linux Regressions , willy@infradead.org, Arnd Bergmann Subject: Re: next: sh: mm/cache-sh4.c:250:51: error: too few arguments to function 'folio_flags' Message-Id: <20240328114612.d60b7ad4eb552281bedbff10@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6A1F712000C X-Rspam-User: X-Stat-Signature: pq9imou66rh6f4m8mb7q5dwspg1ajade X-Rspamd-Server: rspam03 X-HE-Tag: 1711651577-806595 X-HE-Meta: U2FsdGVkX1/Xm6SdMlsDXgEkkSEyvg59CQTa+p8kTM2hrzbtfp2JXQkpdcUjaAe0+jj1l+MaAYJBXbBQgmg6zTQ6wUn8HNOEZ8j+tuS/1kdAp5m6KJa/fHg5jwlkI+gNwzU2jPkPHfWY/jx/HpORdblY20I+cyWBW3bUxDOVwPmaFu8q0BXAj8jVDmr8SjRce7Jl7BtaAqc3LXWT+BG5/LHpy4F7w36/lxpN0dri9Bh6uiL+Ux9VIZy9KVYdv8pHS1ky/zTOQ0O5ZcCM3lmVTQhtByr+gumqRM7JCeZPU881U02Pyibu5l17KmdlgOwpy3msmVcXQmJgiXxGN1Wq8HY8gD58kOqSQAw7ovbd9ttAetVxHSJCZmOquNqIf/mduUrTv6i87kl2c9WZoTlPX2Lemz4nBGI5ToKSF9tmh75n+Znb0wUHd40kWaqWasBzCpqyuVKgCVsXsh9AGrydPhsQ4xAX5XGc/2Ie27P8auXznXQe1IdMLVXDv8MjCvsgTsiyp4mmzsx1XMuW5mogh594WAGDONhJg5epZBae+rYWwo7lH/8pjBvoAJC2xqTGJusQRKuyUzVp/03u4GUwhHROOtqAYZDbazw/r5T2WfKUdKaK6/P4/NdLf2cz+AzZfzoGwcxx2mP1Cxj+AbNttUuEfJpTYVYy1kk/ODMpDNT8DS1Sjn4gLKDvckfSpCRq2IrVcHv1XIylygIxI6/zzkPxkjXeRz1f7oliAxD3ZQJTNxIirJ/Isu8MC7fzsIz1iUiUZSm9ItLHGC8zqjvMju+MnknrZxEP2sLa3UbxwP3fDLDUCV9x3TTqUCGq+ssEdctHGcuuBSbJYfzEYLb/Q9tIcXGjRefacbXMSmFeXTMsnJXRqSHtFu9dFX/6fISKH+2oJY4KP+H8vaFYQ2blyAMKQHW6KAFX7qkswAIUxt90/z6REFSqoWJ5oZQmRllFmyTgjnDoa62KqjHACyU 6ZzvNRot BIjAStPTkilwnQrCjP/5Y4iRHjUyOkQ6XpriEcU5xElCH7m+ipnLkliF5LXZ/Y43WOzwV9SxW4VXIwVdOROcq4L5wvzXCNS+k9Jp99e2JFAn0C9R5/5rMmuq7ekliaQ3nOoNAkApVyfm1HojGSWFyifOTDSRdz24iHZ+3UXlXXTT29XXIIGeZKgGvzHnzcAFlvqfkdoeR4wd3OesMTVzTRUsDu+YyOZ+nFJsrnNa8lRXef07J+SvtdTZwmXvDJE1t1X4HaU2hIGzBxZY4dAcK1F6NHmuPDwibCqKAwvewGIyjmwUqc6yclm40h6YOAEx5/UVw9QRftQsfSyI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Mar 2024 19:12:26 +0530 Naresh Kamboju wrote: > While building sh defconfig with gcc-11 the following build warnings / > errors noticed on Linux next-20240328 tag. > > sh: > build: > * gcc-11-shx3_defconfig - Failed > * gcc-11-dreamcast_defconfig - Failed > * gcc-11-defconfig - Failed > > Reported-by: Linux Kernel Functional Testing > > Build error: > --------- > arch/sh/kernel/cpu/sh4/fpu.c:389:6: warning: no previous prototype for > 'float_raise' [-Wmissing-prototypes] > 389 | void float_raise(unsigned int flags) > | ^~~~~~~~~~~ > arch/sh/kernel/cpu/sh4/fpu.c:394:5: warning: no previous prototype for > 'float_rounding_mode' [-Wmissing-prototypes] > 394 | int float_rounding_mode(void) > | ^~~~~~~~~~~~~~~~~~~ > In file included from include/linux/thread_info.h:27, > from include/asm-generic/preempt.h:5, > from ./arch/sh/include/generated/asm/preempt.h:1, > from include/linux/preempt.h:79, > from include/linux/spinlock.h:56, > from include/linux/mmzone.h:8, > from include/linux/gfp.h:7, > from include/linux/mm.h:7, > from arch/sh/mm/cache-sh4.c:14: > arch/sh/mm/cache-sh4.c: In function 'sh4_flush_cache_page': > arch/sh/mm/cache-sh4.c:250:51: error: too few arguments to function > 'folio_flags' > 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && > | ^~~~~~~~~~~ > Thanks. --- a/arch/sh/mm/cache-sh4.c~sh-remove-use-of-pg_arch_1-on-individual-pages-fix +++ a/arch/sh/mm/cache-sh4.c @@ -247,7 +247,7 @@ static void sh4_flush_cache_page(void *a * another ASID than the current one. */ map_coherent = (current_cpu_data.dcache.n_aliases && - test_bit(PG_dcache_clean, folio_flags(folio)) && + test_bit(PG_dcache_clean, folio_flags(folio, 0)) && page_mapped(page)); if (map_coherent) vaddr = kmap_coherent(page, address); _